From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F46C43381 for ; Fri, 8 Mar 2019 12:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B683C2085A for ; Fri, 8 Mar 2019 12:40:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552048843; bh=6ihPyvtQMtB38VaVl+P2cVykOPZQ4rjZGjTJ3Sgdp2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Y+7Dra0P94lXZAkHvr/5pzDuJun207WeHgbCqC50N/Yg96M7gdjH46nkF8nABl+ap uz0fN60cD0zIL+ZeroP9WpodMGiH0gqlecItptk5gdUIjS6fd0v1xsBlQCUcv94OlP NQ9MOil/XL8QNa1yJLjsqZom3u+ysuDGOZ1cnCs0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfCHMkn (ORCPT ); Fri, 8 Mar 2019 07:40:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:47856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbfCHMkn (ORCPT ); Fri, 8 Mar 2019 07:40:43 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2CDB20851; Fri, 8 Mar 2019 12:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552048842; bh=6ihPyvtQMtB38VaVl+P2cVykOPZQ4rjZGjTJ3Sgdp2k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0Z3e/ZCwLKD64A2qvKbo1bXNeaOZavv6wrbECLO9g+SEbWp8cc571iRyh4hzNFBHq xzSQRD9GvP7L9PMUtwvcK694HdOrZ2LHv1rccacT0A9+/DINyj74exC4hEOy1FNQCL LytPh97u3HweOOLocFRFEn83s2PV2isDay/bV+14= Date: Fri, 8 Mar 2019 13:40:39 +0100 From: Greg KH To: Thibaut Sautereau Cc: stable@vger.kernel.org, Thibaut Sautereau , YueHaibing , Al Viro Subject: Re: [PATCH] exec: Fix mem leak in kernel_read_file Message-ID: <20190308124039.GC13818@kroah.com> References: <20190304221738.GA3189@gandi.net> <20190305062020.GA18909@kroah.com> <20190305090039.GB3189@gandi.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190305090039.GB3189@gandi.net> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Mar 05, 2019 at 10:00:39AM +0100, Thibaut Sautereau wrote: > On Tue, Mar 05, 2019 at 07:20:20AM +0100, Greg KH wrote: > > On Mon, Mar 04, 2019 at 11:17:38PM +0100, Thibaut Sautereau wrote: > > > Commit f612acfae86af7ecad754ae6a46019be9da05b8e upstream > > > ("exec: Fix mem leak in kernel_read_file"), addressing CVE-2019-8980, > > > should be applied to 4.20, 4.19, 4.14 and 4.9 stable kernels. > > > > Any reason you didn't cc: the authors of that patch? > > No, I just forgot, sorry for that. > > > And as it _just_ went into Linus's tree today, give us a few weeks to > > get it backported... > > > > Also, it's just a "normal" syzbot fix, for a very rare case, why is this > > a CVE? > > I don't know (I'm not the one who requested a CVE), but I saw that this > patch had been backported in Arch Linux's kernels to address > CVE-2019-8980 [1] and that stable@kernel.org hadn't been put in Cc:. > > As the fix was already waiting in a pull-request [2] from Al Viro, I > thought it was too late to notice the author about Ccing stable, > therefore I followed option 2 of > Documentation/process/stable-kernel-rules.rst to ensure it would not > fall through the cracks. > > If that was the wrong way to do it, please tell me what I should have > done in this case. No, this is fine, just next time you should cc: the developers as well. Also, this needs to go to 5.0.y, now queued up. greg k-h