From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH] multipath: set discard and norot queue flags on the multipath stacking device
Date: Fri, 8 Mar 2019 14:41:50 +0100 [thread overview]
Message-ID: <20190308134150.GA18554@lst.de> (raw)
In-Reply-To: <20190226225550.30378-1-sagi@grimberg.me>
On Tue, Feb 26, 2019@02:55:50PM -0800, Sagi Grimberg wrote:
> If the underlying device supports discard we set it and clear it otherwise.
> Without this blkdiscard doesn't work on a multipath device node.
>
> Also while we're at it, unconditionally set non rotational queue flag to
> make schedulers do the right thing.
QUEUE_FLAG_NONROT is already set by nvme_mpath_alloc_disk.
For discard don't we also need to the limits? Also what about
Write Zeroes?
prev parent reply other threads:[~2019-03-08 13:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 22:55 [PATCH] multipath: set discard and norot queue flags on the multipath stacking device Sagi Grimberg
2019-03-08 13:41 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308134150.GA18554@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.