From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:44376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h2Jgk-0000tN-Bt for qemu-devel@nongnu.org; Fri, 08 Mar 2019 12:53:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h2Jgj-0003tG-LS for qemu-devel@nongnu.org; Fri, 08 Mar 2019 12:53:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51270) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h2Jgj-0003t0-En for qemu-devel@nongnu.org; Fri, 08 Mar 2019 12:53:41 -0500 Date: Fri, 8 Mar 2019 14:53:36 -0300 From: Eduardo Habkost Message-ID: <20190308175336.GF8899@habkost.net> References: <20190214031004.32522-1-stefanha@redhat.com> <20190214031004.32522-3-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190214031004.32522-3-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/2] hostmem-file: reject invalid pmem file sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Igor Mammedov , Wei Yang , Zhang Yi On Thu, Feb 14, 2019 at 11:10:04AM +0800, Stefan Hajnoczi wrote: > Guests started with NVDIMMs larger than the underlying host file produce > confusing errors inside the guest. This happens because the guest > accesses pages beyond the end of the file. > > Check the pmem file size on startup and print a clear error message if > the size is invalid. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1669053 > Cc: Wei Yang > Cc: Zhang Yi > Cc: Eduardo Habkost > Cc: Igor Mammedov > Signed-off-by: Stefan Hajnoczi I've just noticed this wasn't picked up on my previous pull request. I'm queueing this on machine-next, now. -- Eduardo