From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/i915/icl: use a function pointer
 for pll_write when enabling
Date: Fri, 8 Mar 2019 22:19:54 +0200
Message-ID: <20190308201954.GW3888@intel.com>
References: <20190306012636.18619-1-lucas.demarchi@intel.com>
 <20190306012636.18619-3-lucas.demarchi@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 05D9E6E3D9
 for <intel-gfx@lists.freedesktop.org>; Fri,  8 Mar 2019 20:19:57 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190306012636.18619-3-lucas.demarchi@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMDU6MjY6MzNQTSAtMDgwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IFRoaXMgYWxsb3dzIHVzIHRvIHNoYXJlIHRoZSBpY2xfcGxsX2VuYWJsZSgpIGJl
dHdlZW4gdGhlIGRpZmZlcmVudCB0eXBlcwo+IG9mIFBMTCB3aGlsZSBhbGxvd2luZyB0aGUgY2Fs
bGVyIHRvIGRpZmZlcmVudGlhdGUgaG93IHRvIHdyaXRlIHRoZQo+IHJlZ2lzdGVycy4KPiAKPiBT
aWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4K
PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8IDE4ICsrKysr
KysrLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxMCBkZWxl
dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBs
bF9tZ3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMKPiBpbmRleCAz
YjNkZTk5NzU2ZDYuLjU1MTFiYzIzZWEzZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZHBsbF9tZ3IuYwo+IEBAIC0zMTE4LDkgKzMxMTgsMTAgQEAgc3RhdGljIHZvaWQgaWNsX21nX3Bs
bF93cml0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICBzdGF0aWMg
dm9pZCBpY2xfcGxsX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
IAkJCSAgIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsLAo+IC0JCQkgICBpOTE1X3JlZ190
IGVuYWJsZV9yZWcpCj4gKwkJCSAgIGk5MTVfcmVnX3QgZW5hYmxlX3JlZywKPiArCQkJICAgdm9p
ZCAoKnBsbF93cml0ZSkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkJ
CSAgICAgc3RydWN0IGludGVsX3NoYXJlZF9kcGxsICpwbGwpKQo+ICB7Cj4gLQljb25zdCBlbnVt
IGludGVsX2RwbGxfaWQgaWQgPSBwbGwtPmluZm8tPmlkOwo+ICAJdTMyIHZhbDsKPiAgCj4gIAl2
YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7Cj4gQEAgLTMxMzMsMTIgKzMxMzQsOSBAQCBzdGF0
aWMgdm9pZCBpY2xfcGxsX2VuYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gIAkgKi8KPiAgCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwgZW5hYmxl
X3JlZywgUExMX1BPV0VSX1NUQVRFLAo+ICAJCQkJICAgIFBMTF9QT1dFUl9TVEFURSwgMSkpCj4g
LQkJRFJNX0VSUk9SKCJQTEwgJWQgUG93ZXIgbm90IGVuYWJsZWRcbiIsIGlkKTsKPiArCQlEUk1f
RVJST1IoIlBMTCAlZCBQb3dlciBub3QgZW5hYmxlZFxuIiwgcGxsLT5pbmZvLT5pZCk7Cj4gIAo+
IC0JaWYgKGludGVsX2RwbGxfaXNfY29tYm9waHkoaWQpIHx8IGlkID09IERQTExfSURfSUNMX1RC
VFBMTCkKPiAtCQlpY2xfZHBsbF93cml0ZShkZXZfcHJpdiwgcGxsKTsKPiAtCWVsc2UKPiAtCQlp
Y2xfbWdfcGxsX3dyaXRlKGRldl9wcml2LCBwbGwpOwo+ICsJcGxsX3dyaXRlKGRldl9wcml2LCBw
bGwpOwoKSG1tLiBXb3VsZCBpdCBiZSBjbGVhbmVyIHRvIGp1c3QgZXhyYWN0IHRoZSBwbGwgcG93
ZXIKZW5hYmxlL2Rpc2FibGUgYW5kIHBsbCBlbmFibGUvZGlzYWJsZSBwYXJ0cyBpbnRvIHNtYWxs
IGhlbHBlcnM/Ckl0IGxvb2tzIGxpa2UgbGlrZSBnbGsvY25sIGFsc28gZm9sbG93IHRoaXMgc2Ft
ZSBwYXR0ZXJuLCBzbwp0aGVyZSBtYXkgYmUgYSBjaGFuY2UgdG8gcmV1c2UgdGhlIGNvZGUgb24g
dGhvc2UgcGxhdGZvcm1zCmFzIHdlbGwuCgo+ICAKPiAgCS8qCj4gIAkgKiBEVkZTIHByZSBzZXF1
ZW5jZSB3b3VsZCBiZSBoZXJlLCBidXQgaW4gb3VyIGRyaXZlciB0aGUgY2RjbGsgY29kZQo+IEBA
IC0zMTUyLDcgKzMxNTAsNyBAQCBzdGF0aWMgdm9pZCBpY2xfcGxsX2VuYWJsZShzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lz
dGVyKGRldl9wcml2LCBlbmFibGVfcmVnLCBQTExfTE9DSywgUExMX0xPQ0ssCj4gIAkJCQkgICAg
MSkpIC8qIDYwMHVzIGFjdHVhbGx5LiAqLwo+IC0JCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2Nr
ZWRcbiIsIGlkKTsKPiArCQlEUk1fRVJST1IoIlBMTCAlZCBub3QgbG9ja2VkXG4iLCBwbGwtPmlu
Zm8tPmlkKTsKPiAgCj4gIAkvKiBEVkZTIHBvc3Qgc2VxdWVuY2Ugd291bGQgYmUgaGVyZS4gU2Vl
IHRoZSBjb21tZW50IGFib3ZlLiAqLwo+ICB9Cj4gQEAgLTMxNjIsNyArMzE2MCw3IEBAIHN0YXRp
YyB2b2lkIGNvbWJvX3BsbF9lbmFibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+ICB7Cj4gIAlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBpY2xfcGxsX2lkX3RvX2VuYWJsZV9y
ZWcocGxsLT5pbmZvLT5pZCk7Cj4gIAo+IC0JaWNsX3BsbF9lbmFibGUoZGV2X3ByaXYsIHBsbCwg
ZW5hYmxlX3JlZyk7Cj4gKwlpY2xfcGxsX2VuYWJsZShkZXZfcHJpdiwgcGxsLCBlbmFibGVfcmVn
LCBpY2xfZHBsbF93cml0ZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2b2lkIG1nX3BsbF9lbmFibGUo
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IEBAIC0zMTcxLDcgKzMxNjksNyBA
QCBzdGF0aWMgdm9pZCBtZ19wbGxfZW5hYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdiwKPiAgCWk5MTVfcmVnX3QgZW5hYmxlX3JlZyA9Cj4gIAkJTUdfUExMX0VOQUJMRShpY2xf
cGxsX2lkX3RvX3RjX3BvcnQocGxsLT5pbmZvLT5pZCkpOwo+ICAKPiAtCWljbF9wbGxfZW5hYmxl
KGRldl9wcml2LCBwbGwsIGVuYWJsZV9yZWcpOwo+ICsJaWNsX3BsbF9lbmFibGUoZGV2X3ByaXYs
IHBsbCwgZW5hYmxlX3JlZywgaWNsX21nX3BsbF93cml0ZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyB2
b2lkIGljbF9wbGxfZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g
LS0gCj4gMi4yMC4xCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==