All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Duszynski <tduszyns@gmail.com>
To: Anderson Reis <andersonreisrosa@gmail.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, matt.ranostay@konsulko.com,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-usp@googlegroups.com,
	Lucas Oshiro <lucasseikioshiro@gmail.com>
Subject: Re: [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses
Date: Fri, 8 Mar 2019 22:04:26 +0100	[thread overview]
Message-ID: <20190308210425.GB32641@arch> (raw)
In-Reply-To: <20190308194655.5983-2-anderson.reis.rosa@usp.com>

On Fri, Mar 08, 2019 at 04:46:52PM -0300, Anderson Reis wrote:
> From: Lucas Oshiro <lucasseikioshiro@gmail.com>
>
> Remove unnecessary parentheses on line 116, and solve these checkpatch.pl

No need to explicitly point finger at changed lines. This is what
context lines are for.

> CHECKs:
>
> - lmp91000.c:116: CHECK: Unnecessary parentheses around 'state != channel'
> - lmp91000.c:116: CHECK: Unnecessary parentheses around 'channel == LMP91000_REG_MODECN_TEMP'
>
> Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>
> Signed-off-by: Anderson Reis <andersonreisrosa@gmail.com>
> ---
>  drivers/iio/potentiostat/lmp91000.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/potentiostat/lmp91000.c b/drivers/iio/potentiostat/lmp91000.c
> index 90e895adf997..03d277621861 100644
> --- a/drivers/iio/potentiostat/lmp91000.c
> +++ b/drivers/iio/potentiostat/lmp91000.c
> @@ -113,7 +113,7 @@ static int lmp91000_read(struct lmp91000_data *data, int channel, int *val)
>  		return -EINVAL;
>
>  	/* delay till first temperature reading is complete */
> -	if ((state != channel) && (channel == LMP91000_REG_MODECN_TEMP))
> +	if (state != channel && channel == LMP91000_REG_MODECN_TEMP)
>  		usleep_range(3000, 4000);
>
>  	data->chan_select = channel != LMP91000_REG_MODECN_3LEAD;
> --
> 2.20.1
>

  reply	other threads:[~2019-03-08 21:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 19:46 [PATCH v2 0/4] iio:potentiostat:lmp91000: Adjust codestyle, and minor cleanup changes Anderson Reis
2019-03-08 19:46 ` [PATCH v2 1/4] iio:potentiostat:lmp91000: remove unnecessary parentheses Anderson Reis
2019-03-08 21:04   ` Tomasz Duszynski [this message]
     [not found]     ` <CAJut9009qPt50o4CDNpkZ=NQVetivYHJMi2pY_DrDUk=WN=XMw@mail.gmail.com>
2019-03-09 18:44       ` Jonathan Cameron
2019-03-08 19:46 ` [PATCH v2 2/4] iio:potentiostat:lmp91000: reduce line width and remove blank line Anderson Reis
2019-03-09 18:45   ` Jonathan Cameron
2019-03-08 19:46 ` [PATCH v2 3/4] iio:potentiostat:lmp91000: invert if statement Anderson Reis
2019-03-09 18:46   ` Jonathan Cameron
2019-03-09 18:48     ` Jonathan Cameron
2019-03-08 19:46 ` [PATCH v2 4/4] iio:potentiostat:lmp91000: change dev_err message Anderson Reis
2019-03-09 18:49   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190308210425.GB32641@arch \
    --to=tduszyns@gmail.com \
    --cc=andersonreisrosa@gmail.com \
    --cc=jic23@kernel.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucasseikioshiro@gmail.com \
    --cc=matt.ranostay@konsulko.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.