From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Sort ICL PCI IDs
Date: Fri, 8 Mar 2019 13:17:51 -0800 [thread overview]
Message-ID: <20190308211751.GG22115@intel.com> (raw)
In-Reply-To: <20190307205656.12104-1-jose.souza@intel.com>
On Thu, Mar 07, 2019 at 12:56:55PM -0800, José Roberto de Souza wrote:
> Lets keep it sorted to make easy to spot missing PCI IDs.
Hmm... In my opinion leaving it as the identical order
of the spec is the way to make it easier to spot if we missed
something...
Otherwise when reviewing I have to stop and sort one or another.
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> include/drm/i915_pciids.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index d2fad7b0fcf6..be735811591d 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -459,16 +459,16 @@
> #define INTEL_ICL_11_IDS(info) \
> INTEL_VGA_DEVICE(0x8A50, info), \
> INTEL_VGA_DEVICE(0x8A51, info), \
> - INTEL_VGA_DEVICE(0x8A5C, info), \
> - INTEL_VGA_DEVICE(0x8A5D, info), \
> - INTEL_VGA_DEVICE(0x8A59, info), \
> - INTEL_VGA_DEVICE(0x8A58, info), \
> INTEL_VGA_DEVICE(0x8A52, info), \
> + INTEL_VGA_DEVICE(0x8A56, info), \
> + INTEL_VGA_DEVICE(0x8A57, info), \
> + INTEL_VGA_DEVICE(0x8A58, info), \
> + INTEL_VGA_DEVICE(0x8A59, info), \
> INTEL_VGA_DEVICE(0x8A5A, info), \
> INTEL_VGA_DEVICE(0x8A5B, info), \
> - INTEL_VGA_DEVICE(0x8A57, info), \
> - INTEL_VGA_DEVICE(0x8A56, info), \
> - INTEL_VGA_DEVICE(0x8A71, info), \
> - INTEL_VGA_DEVICE(0x8A70, info)
> + INTEL_VGA_DEVICE(0x8A5C, info), \
> + INTEL_VGA_DEVICE(0x8A5D, info), \
> + INTEL_VGA_DEVICE(0x8A70, info), \
> + INTEL_VGA_DEVICE(0x8A71, info)
>
> #endif /* _I915_PCIIDS_H */
> --
> 2.21.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-03-08 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 20:56 [PATCH 1/2] drm/i915: Sort ICL PCI IDs José Roberto de Souza
2019-03-07 20:56 ` [PATCH 2/2] drm/i915: Add new ICL PCI ID José Roberto de Souza
2019-03-08 21:23 ` Rodrigo Vivi
2019-03-07 21:48 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Sort ICL PCI IDs Patchwork
2019-03-07 23:58 ` ✓ Fi.CI.IGT: " Patchwork
2019-03-08 21:17 ` Rodrigo Vivi [this message]
2019-03-08 21:41 ` [PATCH 1/2] " Souza, Jose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308211751.GG22115@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.