From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by arago-project.org (Postfix) with ESMTPS id 1172952987 for ; Fri, 8 Mar 2019 22:14:28 +0000 (UTC) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x28MELsK116182 for ; Fri, 8 Mar 2019 16:14:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1552083261; bh=X+3z3zhdMVQTXn+4PInVgnmPqHhRQ/mRM0loy9Jn7Kc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=GoMInfa43MJBxYZzIfmNqiHRi+uuYqk4Cz/vXgaxS+au318uhzoExCPQxy2JSpGmJ XluaEVvPRNni0jxvOWdW4qpTThan2B8OpdFHKFtaiH/7m29yCsotwf7Nhc2c4DOzkW f95NkRGIWaCt+Nykr6UXqKmIpDH7DiPhYzF6jvio= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x28MELfx025682 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 8 Mar 2019 16:14:21 -0600 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 8 Mar 2019 16:14:20 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Fri, 8 Mar 2019 16:14:20 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x28MEKrc014985; Fri, 8 Mar 2019 16:14:20 -0600 Date: Fri, 8 Mar 2019 17:14:20 -0500 From: Denys Dmytriyenko To: "Xu, Jianzhong" Message-ID: <20190308221420.GD26510@beryl> References: <1552051785-31309-1-git-send-email-xuj@ti.com> <20190308210758.GC26510@beryl> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: "meta-arago@arago-project.org" Subject: Re: [PATCH v3] tidl-utils: add new features; change license checksum X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Mar 2019 22:14:29 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Yes, looks fine. Thanks. On Fri, Mar 08, 2019 at 04:59:28PM -0500, Xu, Jianzhong wrote: > How about this commit message: > > tidl-utils: 1. update to add new features to TIDL import tool > - ONNX > - Tensorflow 1.7 and above > - linking with OpenCV for ARM build > 2. change license checksum by only calculating license header in itidl_ti.h > since this file has changed and will likely change in future. > > -----Original Message----- > From: Dmytriyenko, Denys > Sent: Friday, March 08, 2019 4:08 PM > To: Xu, Jianzhong > Cc: meta-arago@arago-project.org > Subject: Re: [meta-arago] [PATCH v3] tidl-utils: add new features; change license checksum > > The gold rule of every commit message is to answer the "Why?" question, not > "What?". The code change in the patch itself covers "What?", the commit > message should explain "Why?" - why those changes are being made? > > Let's see: > > add new features; > > Update to add new features, fine. > > > > change license checksum > > Yeah, the license checksum is being changed, but why? > > We've just gone through the same excercise with Mahesh, just on meta-ti list: > https://lists.yoctoproject.org/pipermail/meta-ti/2019-March/thread.html > > > On Fri, Mar 08, 2019 at 08:29:45AM -0500, Jianzhong Xu wrote: > > Signed-off-by: Jianzhong Xu > > --- > > Change from previous version of patch: commit message modification > > --- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb | 8 ++++---- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb | 2 +- > > meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc | 2 +- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > index 1291f9d..bef2d1a 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-import_git.bb > > @@ -5,10 +5,10 @@ DESCRIPTION = "TIDL import tool is using protobuf to read and parse information > > require ./tidl-utils.inc > > > > LICENSE = "BSD-3" > > -LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;md5=7baa68fec0aadbac92c3b41b283d26c4" > > +LIC_FILES_CHKSUM = "file://modules/ti_dl/inc/itidl_ti.h;beginline=1;endline=34;md5=cabe1fdaabfa0d85dc5544566b0e2425" > > > > -PV = "01.00.00.00" > > -PR = "r1" > > +PV = "01.01.00.00" > > +PR = "r0" > > > > S = "${WORKDIR}/git/src/importTool/" > > > > @@ -21,7 +21,7 @@ EXTRA_OEMAKE += "CORE=eve" > > EXTRA_OEMAKE += "TARGET_BUILD=release" > > EXTRA_OEMAKE += "TARGET_PLATFORM=PC" > > > > -EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include" > > +EXTRA_MAKE_ARGS = "PLATFORM_BUILD=x86 LINUXENV=x86 LINUX_IMPORT_TOOL=64BIT PROTOBUF_LIB_DIR=${STAGING_DIR_NATIVE}/usr/lib PROTOBUF_INC_DIR=${STAGING_DIR_NATIVE}/usr/include" > > EXTRA_MAKE_ARGS_class-target = "LINUX_BUILD_TOOLS=${TOOLCHAIN_PATH}/bin/${TARGET_PREFIX} PROTOBUF_LIB_DIR=${STAGING_LIBDIR} PROTOBUF_INC_DIR=${STAGING_INCDIR} LINUXENV=oearm" > > > > EXTRA_OEMAKE += "${EXTRA_MAKE_ARGS}" > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > index e065e17..69b6e29 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.bb > > @@ -5,7 +5,7 @@ LICENSE = "TI-TFL" > > > > require ./tidl-utils.inc > > > > -PV = "1.0.0.1" > > +PV = "1.0.1.0" > > INC_PR = "r0" > > > > LIC_FILES_CHKSUM = "file://docs/LICENSE.txt;md5=a93aa5af7a3bbbb6fb34c8df59efaa5c" > > diff --git a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > index 37ce84d..9ccabdd 100644 > > --- a/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > +++ b/meta-arago-extras/recipes-ti/tidl-utils/tidl-utils.inc > > @@ -1,2 +1,2 @@ > > SRC_URI = "git://git.ti.com/tidl/tidl-utils.git;protocol=git;branch=master" > > -SRCREV = "0021b6f15ee4a1a8919905429a5045fd02afe5b1" > > +SRCREV = "057984b05e143a4740ecec3dd28cfa082927b897" > > -- > > 1.9.1 > > > > _______________________________________________ > > meta-arago mailing list > > meta-arago@arago-project.org > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago