From: Al Viro <viro@zeniv.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>
Subject: Re: [GIT PULL] Support for the io_uring IO interface
Date: Sat, 9 Mar 2019 03:03:44 +0000 [thread overview]
Message-ID: <20190309030343.GF2217@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAHk-=whCvMXSbuDmPAZ1sHzuQFxzuVsrh4Q8rQmB9nooP8QOKA@mail.gmail.com>
On Fri, Mar 08, 2019 at 03:36:46PM -0800, Linus Torvalds wrote:
> I'm getting the very strong signal that this code had all the logic
> taken from fs/aio.c, bugs and all.
Definitely.
> Al has patches to fix the aio.c cases. I very much suspect some very
> similar patches are needed in fs/io_ring.c.
Very likely so. BTW, another lovely problem is that read from
a registered AF_UNIX socket really needs an extra reference to
struct file that would *NOT* be covered by ->inflight. Otherwise
we are asking for serious trouble with garbage collector...
next prev parent reply other threads:[~2019-03-09 3:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 16:13 [GIT PULL] Support for the io_uring IO interface Jens Axboe
2019-03-06 20:05 ` Jens Axboe
2019-03-08 22:55 ` Linus Torvalds
2019-03-08 23:36 ` Linus Torvalds
2019-03-08 23:52 ` Linus Torvalds
2019-03-09 0:08 ` Linus Torvalds
2019-03-09 4:25 ` Jens Axboe
2019-03-09 4:33 ` Linus Torvalds
2019-03-09 4:39 ` Jens Axboe
2019-03-09 5:41 ` Linus Torvalds
2019-03-12 21:52 ` Jens Axboe
2019-03-09 3:03 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-03-04 1:53 Jens Axboe
2019-03-04 2:34 ` Linus Torvalds
2019-03-04 3:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309030343.GF2217@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=linux-aio@kvack.org \
--cc=linux-block@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.