From: Wolfram Sang <wsa@the-dreams.de>
To: Louis Taylor <louis@kragniz.eu>
Cc: jdelvare@suse.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
ndesaulniers@google.com, jflat@chromium.org
Subject: Re: [PATCH] i2c: sis630: correct format strings
Date: Sat, 9 Mar 2019 10:54:46 +0100 [thread overview]
Message-ID: <20190309095446.GE1340@kunai> (raw)
In-Reply-To: <20190302141836.24638-1-louis@kragniz.eu>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Sat, Mar 02, 2019 at 02:18:36PM +0000, Louis Taylor wrote:
> When compiling with -Wformat, clang warns:
>
> drivers/i2c/busses/i2c-sis630.c:482:4: warning: format specifies type
> 'unsigned short' but the argument has type 'int' [-Wformat]
> smbus_base + SMB_STS,
> ^~~~~~~~~~~~~~~~~~~~
>
> drivers/i2c/busses/i2c-sis630.c:483:4: warning: format specifies type
> 'unsigned short' but the argument has type 'int' [-Wformat]
> smbus_base + SMB_STS + SIS630_SMB_IOREGION - 1);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> drivers/i2c/busses/i2c-sis630.c:531:37: warning: format specifies type
> 'unsigned short' but the argument has type 'int' [-Wformat]
> "SMBus SIS630 adapter at %04hx", smbus_base + SMB_STS);
> ~~~~~ ^~~~~~~~~~~~~~~~~~~~
>
> This patch fixes the format strings to use the format type for int.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Louis Taylor <louis@kragniz.eu>
Changed Jean's SoB to Rev-by and applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-03-09 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 14:18 [PATCH] i2c: sis630: correct format strings Louis Taylor
2019-03-04 18:16 ` Nick Desaulniers
2019-03-06 8:58 ` Jean Delvare
2019-03-09 9:54 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309095446.GE1340@kunai \
--to=wsa@the-dreams.de \
--cc=clang-built-linux@googlegroups.com \
--cc=jdelvare@suse.com \
--cc=jflat@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis@kragniz.eu \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.