From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 909DAC43381 for ; Sat, 9 Mar 2019 16:19:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E4882081B for ; Sat, 9 Mar 2019 16:19:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f8KOjUaU"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3e2kTX06" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E4882081B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FsAEs/phihABuL7VsGG12cq6gu9CceKX0+zo2dH0ANQ=; b=f8KOjUaUMkffDq ZK71YdRJF5k/t1kAmV+bD1OX7QT6MeVPmhnWsHW/nAwtNLrPY4ReN9v0z8WXP47l+JtN66lX2H2S5 BnGnnq9C3/W3+fxoX6EJsJl9S0SzD7DYBPBeGQAh0J/qeZcoC4KGLvLMzT0/FUv0GO+w78akywvvs Xecqb4tHDS9Lkn8g8nHMFqvthWTMasT3+YgtGA3L+bGikIEr7Lf1Sv5XI2016pR9p8YgXhlaXn4GR kGI+7tPVBXCClS9I6nGypvG6dx0LkhA8ha76XdbLHqbC43BfJOgQu0k2YxwAodpQ7uU9Qrg2ywyCn IroZQRsEvJRZtuZDYkBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2eh0-0001pP-Op; Sat, 09 Mar 2019 16:19:22 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2egx-0001p6-3Q for linux-arm-kernel@lists.infradead.org; Sat, 09 Mar 2019 16:19:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3LaHrgLeaPGmxpLltQIlj1BIy7Ub2V76F5fHZgYA9yQ=; b=3e2kTX068ob6pitnIyEMKyB0jx XrbDAYjnhL9a+DZTAGIkc7kTZK6PABqhSkMEuNG3obXbxmmO0SF8thb3lxeXW1IRarX2MtsrO2Mlr +cC/DOxycfLmoJmg3H6CRuC2c6wVVbR08DqndYWABa94BtIb3PWy2IkqZO48ssMiuQfs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h2egq-00018t-Dt; Sat, 09 Mar 2019 17:19:12 +0100 Date: Sat, 9 Mar 2019 17:19:12 +0100 From: Andrew Lunn To: Harini Katakam Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Message-ID: <20190309161912.GD9000@lunn.ch> References: <958bb823-3dc8-607f-3c38-3d902acb85a8@gmail.com> <20190219172515.GC13075@lunn.ch> <9cb2f7a8-a8cf-ef80-d260-cc67c072b5c5@xilinx.com> <8bb813fb-102b-00c9-fb6f-a3e928965051@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190309_081919_294202_0A09A77C X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , netdev@vger.kernel.org, Michal Simek , linux-kernel@vger.kernel.org, Paul Kocialkowski , Thomas Petazzoni , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Related to this, I have a query on how the DT node for gmii2rgmii should look. > One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use > this piece of code to register this mdiobus: > + mdio_np = of_get_child_by_name(np, "mdio"); > + if (mdio_np) { > + of_node_put(mdio_np); > + err = of_mdiobus_register(bp->mii_bus, mdio_np); > + if (err) > + goto err_out_unregister_bus; > > And the DT node looks like this: > ethernet { > phy-mode = "gmii"; > phy-handle = <&extphy>; > > mdio { > extphy { > reg = ; > }; > gmii_to_rgmii{ > compatible = "xlnx,gmii-to-rgmii-1.0"; > phy-handle = <&extphy>; > reg = ; > }; > }; > }; Hi Harini You have this setup: MAC <==> GMII2RGMII <==> RGMII_PHY So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'. Feel free to submit a patch extending Documentation/devicetree/bindings/net/xilinx_gmii2rgmii.txt to include a MAC node, etc. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68733C43381 for ; Sat, 9 Mar 2019 16:19:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2292D2081B for ; Sat, 9 Mar 2019 16:19:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="3e2kTX06" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726402AbfCIQTU (ORCPT ); Sat, 9 Mar 2019 11:19:20 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50616 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbfCIQTU (ORCPT ); Sat, 9 Mar 2019 11:19:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3LaHrgLeaPGmxpLltQIlj1BIy7Ub2V76F5fHZgYA9yQ=; b=3e2kTX068ob6pitnIyEMKyB0jx XrbDAYjnhL9a+DZTAGIkc7kTZK6PABqhSkMEuNG3obXbxmmO0SF8thb3lxeXW1IRarX2MtsrO2Mlr +cC/DOxycfLmoJmg3H6CRuC2c6wVVbR08DqndYWABa94BtIb3PWy2IkqZO48ssMiuQfs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1h2egq-00018t-Dt; Sat, 09 Mar 2019 17:19:12 +0100 Date: Sat, 9 Mar 2019 17:19:12 +0100 From: Andrew Lunn To: Harini Katakam Cc: Michal Simek , Paul Kocialkowski , Florian Fainelli , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "David S . Miller" , Thomas Petazzoni , Heiner Kallweit Subject: Re: [PATCH RESEND net] net: phy: xgmiitorgmii: Support generic PHY status read Message-ID: <20190309161912.GD9000@lunn.ch> References: <958bb823-3dc8-607f-3c38-3d902acb85a8@gmail.com> <20190219172515.GC13075@lunn.ch> <9cb2f7a8-a8cf-ef80-d260-cc67c072b5c5@xilinx.com> <8bb813fb-102b-00c9-fb6f-a3e928965051@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Related to this, I have a query on how the DT node for gmii2rgmii should look. > One of the users of gmii2rgmii is Cadence macb driver. In Xilinx tree, we use > this piece of code to register this mdiobus: > + mdio_np = of_get_child_by_name(np, "mdio"); > + if (mdio_np) { > + of_node_put(mdio_np); > + err = of_mdiobus_register(bp->mii_bus, mdio_np); > + if (err) > + goto err_out_unregister_bus; > > And the DT node looks like this: > ethernet { > phy-mode = "gmii"; > phy-handle = <&extphy>; > > mdio { > extphy { > reg = ; > }; > gmii_to_rgmii{ > compatible = "xlnx,gmii-to-rgmii-1.0"; > phy-handle = <&extphy>; > reg = ; > }; > }; > }; Hi Harini You have this setup: MAC <==> GMII2RGMII <==> RGMII_PHY So you want the MAC phy-handle to point to the gmii_to_rgmii 'PHY'. Feel free to submit a patch extending Documentation/devicetree/bindings/net/xilinx_gmii2rgmii.txt to include a MAC node, etc. Andrew