From: Jonathan Cameron <jic23@kernel.org>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Matt Ranostay <matt.ranostay@konsulko.com>
Subject: Re: [PATCH] iio: proximity: as3935: fix use-after-free on device remove
Date: Sat, 9 Mar 2019 18:24:49 +0000 [thread overview]
Message-ID: <20190309182449.45cd1b28@archlinux> (raw)
In-Reply-To: <CAGngYiUGcKrs86_ZARgfZxC_4hOAhW-e69GMpK6yAJMjHrYs6Q@mail.gmail.com>
On Fri, 8 Mar 2019 12:49:30 -0500
Sven Van Asbroeck <thesven73@gmail.com> wrote:
> On Fri, Mar 8, 2019 at 12:13 PM Jonathan Cameron
> <jonathan.cameron@huawei.com> wrote:
> >
> > Your description makes it clear that there are multiple things in the patch.
> > Don't do a 'while we were here' in a patch doing something else please.
> > Separate patches.
> >
>
> The proposed solution (adding devm_) fixes multiple issues, so that can stay
> as a single patch, right?
>
> It's the 'while we're here' you'd like to see removed? Can do.
That's the one. Just the & removal. The rest makes sense in
one patch as you say.
Jonathan
prev parent reply other threads:[~2019-03-09 18:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 17:45 [PATCH] iio: proximity: as3935: fix use-after-free on device remove Sven Van Asbroeck
2019-03-08 17:12 ` Jonathan Cameron
2019-03-08 17:49 ` Sven Van Asbroeck
2019-03-09 18:24 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309182449.45cd1b28@archlinux \
--to=jic23@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=pmeerw@pmeerw.net \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.