All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S . Tsirkin" <mst@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	qemu-devel@nongnu.org, "Hervé Poussineau" <hpoussin@reactos.org>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	"Aleksandar Markovic" <amarkovic@wavecomp.com>,
	"Aleksandar Rikalo" <arikalo@wavecomp.com>,
	"Aurelien Jarno" <aurelien@aurel32.net>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>
Subject: [Qemu-devel] [PATCH 8/8] hw/i386: Move ACPI_SMBUS out of I440FX (Kconfig)
Date: Mon, 11 Mar 2019 00:53:51 +0100	[thread overview]
Message-ID: <20190310235351.1863-9-philmd@redhat.com> (raw)
In-Reply-To: <20190310235351.1863-1-philmd@redhat.com>

The SMBus interface is a slow bus not related to the i440fx
northbridge, it comes from the PIIX3 southbridge.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
index 56e72abb8c..9ac833b930 100644
--- a/hw/i386/Kconfig
+++ b/hw/i386/Kconfig
@@ -51,7 +51,6 @@ config I440FX
     bool
     select PC_PCI
     select PC_ACPI
-    select ACPI_SMBUS
     select DIMM
     select SMBIOS
     select VMPORT
@@ -68,6 +67,7 @@ config ISAPC
     select PIIX3
     # QEMU isapc weirdness: it uses PIIX3 with ACPI features from PIIX4
     select ACPI_PIIX4
+    select ACPI_SMBUS
 
 config Q35
     bool
-- 
2.20.1

  parent reply	other threads:[~2019-03-10 23:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-10 23:53 [Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 1/8] hw/i2c: The ACPI_SMBUS Kconfig depends on ACPI Philippe Mathieu-Daudé
2019-03-11  0:27   ` Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 2/8] hw/input: Add 8042 PS/2 Keyboard Controller to Kconfig Philippe Mathieu-Daudé
2019-03-11  6:47   ` Thomas Huth
2019-03-11 11:14     ` Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 3/8] hw/southbridge: Add the PIIX chipset " Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 4/8] hw/southbridge: Add the PIIX3 " Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 5/8] hw/southbridge: Cleanup the PIIX4 chipset in Kconfig Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 6/8] hw/southbridge: Add ACPI_PIIX4 to Kconfig Philippe Mathieu-Daudé
2019-03-10 23:53 ` [Qemu-devel] [PATCH 7/8] hw/i386: The 'isapc' machine is built around a PIIX3 southbridge Philippe Mathieu-Daudé
2019-03-10 23:53 ` Philippe Mathieu-Daudé [this message]
2019-03-11  3:54 ` [Qemu-devel] [PATCH 0/8] Kconfig: Clean up the PIIX southbridge devices no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190310235351.1863-9-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=amarkovic@wavecomp.com \
    --cc=arikalo@wavecomp.com \
    --cc=aurelien@aurel32.net \
    --cc=ehabkost@redhat.com \
    --cc=hpoussin@reactos.org \
    --cc=imammedo@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.