All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v1 1/3] staging: rtl8192e: add SPDX GPL-2.0+ license identifier
Date: Mon, 11 Mar 2019 04:04:49 +0100	[thread overview]
Message-ID: <20190311030449.GA17063@kroah.com> (raw)
In-Reply-To: <20190311000702.12740-2-jbi.octave@gmail.com>

On Mon, Mar 11, 2019 at 12:07:00AM +0000, Jules Irenge wrote:
> Add the SPDX GPL-2.0+ license identifier to fix checkpatch.pl warning
> Issue found by checkpatch.pl warning:
> "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/rtl8192e/dot11d.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c
> index 68f53013cb95..74adb45efe73 100644
> --- a/drivers/staging/rtl8192e/dot11d.c
> +++ b/drivers/staging/rtl8192e/dot11d.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0+

Why did you pick this specific license?  It does not seem to match the
license text in this file at all.

Be _VERY_ careful when doing stuff like this.  If you get the license
wrong, lawyers can get mad at you :(

Also, the file name "dot11d.c" should be in the subject line, as you are
not adding the identifer to the whole driver, only one file.

Please fix this up and resend the whole series.

thanks,

greg k-h


  reply	other threads:[~2019-03-11  3:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-11  0:06 [PATCH v1 0/3] SPDX cleanups and line over 80 characters fix Jules Irenge
2019-03-11  0:07 ` [PATCH v1 1/3] staging: rtl8192e: add SPDX GPL-2.0+ license identifier Jules Irenge
2019-03-11  3:04   ` Greg KH [this message]
2019-03-11 22:15     ` Jules Octave
2019-03-11 22:40       ` Greg KH
2019-03-11 22:55         ` Jules Octave
2019-03-11  0:07 ` [PATCH v1 2/3] staging: rtl8192e: remove license boilerplate text Jules Irenge
2019-03-11  0:07 ` [PATCH v1 3/3] staging: rtl8192e: fix line over 80 characters warning Jules Irenge
2019-03-11  3:07   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190311030449.GA17063@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.