From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 11 Mar 2019 08:11:27 +0000 Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Message-Id: <20190311081127.GC2434@kadam> List-Id: References: <20190309214852.12233-1-dante.paz@gmail.com> In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dante Paz Cc: devel@driverdev.osuosl.org, Dante Paz , linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, leobras.c@gmail.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, renatoys08@gmail.com On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote: > From: Dante Paz > > Style and coding function issues were corrected, by avoiding macro functions with a conflicting coding style. > Signed-off-by: Dante Paz Line too long. No blank. Fix indenting. It's not really clear what you're trying to do actually... You need to sell your patch a bit to try convince us that it's worth applying. regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Date: Mon, 11 Mar 2019 11:11:27 +0300 Message-ID: <20190311081127.GC2434@kadam> References: <20190309214852.12233-1-dante.paz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id 155E5892E2 for ; Mon, 11 Mar 2019 08:12:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dante Paz Cc: devel@driverdev.osuosl.org, Dante Paz , linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, leobras.c@gmail.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, renatoys08@gmail.com List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBNYXIgMDksIDIwMTkgYXQgMDY6NDg6NTJQTSAtMDMwMCwgRGFudGUgUGF6IHdyb3Rl Ogo+IEZyb206IERhbnRlIFBheiA8ZHBhekB1bmMuZWR1LmFyPgo+IAo+ICAgICBTdHlsZSBhbmQg Y29kaW5nIGZ1bmN0aW9uIGlzc3VlcyB3ZXJlIGNvcnJlY3RlZCwgYnkgYXZvaWRpbmcgbWFjcm8g ZnVuY3Rpb25zIHdpdGggYSBjb25mbGljdGluZyBjb2Rpbmcgc3R5bGUuCj4gICAgIFNpZ25lZC1v ZmYtYnk6IERhbnRlIFBheiA8ZHBhekB1bmMuZWR1LmFyPgoKTGluZSB0b28gbG9uZy4gIE5vIGJs YW5rLiAgRml4IGluZGVudGluZy4KCkl0J3Mgbm90IHJlYWxseSBjbGVhciB3aGF0IHlvdSdyZSB0 cnlpbmcgdG8gZG8gYWN0dWFsbHkuLi4gIFlvdSBuZWVkIHRvCnNlbGwgeW91ciBwYXRjaCBhIGJp dCB0byB0cnkgY29udmluY2UgdXMgdGhhdCBpdCdzIHdvcnRoIGFwcGx5aW5nLgoKcmVnYXJkcywK ZGFuIGNhcnBlbnRlcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVs