From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Mon, 11 Mar 2019 08:18:14 +0000 Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Message-Id: <20190311081814.GD2434@kadam> List-Id: References: <20190309214852.12233-1-dante.paz@gmail.com> In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dante Paz Cc: devel@driverdev.osuosl.org, Dante Paz , linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, leobras.c@gmail.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, renatoys08@gmail.com I feel like you need to break the patch up a bit and do the white space fixes separate from the other changes. (Probably you're going to have to redo this several times because it's hard to review when it's so mixed up with multiple changes at the same time). regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH] FBTFT: fbtft-bus: Fix code style problems Date: Mon, 11 Mar 2019 11:18:14 +0300 Message-ID: <20190311081814.GD2434@kadam> References: <20190309214852.12233-1-dante.paz@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id 97ACE8928D for ; Mon, 11 Mar 2019 08:18:32 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190309214852.12233-1-dante.paz@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dante Paz Cc: devel@driverdev.osuosl.org, Dante Paz , linux-fbdev@vger.kernel.org, nishadkamdar@gmail.com, leobras.c@gmail.com, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, renatoys08@gmail.com List-Id: dri-devel@lists.freedesktop.org SSBmZWVsIGxpa2UgeW91IG5lZWQgdG8gYnJlYWsgdGhlIHBhdGNoIHVwIGEgYml0IGFuZCBkbyB0 aGUgd2hpdGUKc3BhY2UgZml4ZXMgc2VwYXJhdGUgZnJvbSB0aGUgb3RoZXIgY2hhbmdlcy4KCihQ cm9iYWJseSB5b3UncmUgZ29pbmcgdG8gaGF2ZSB0byByZWRvIHRoaXMgc2V2ZXJhbCB0aW1lcyBi ZWNhdXNlIGl0J3MKaGFyZCB0byByZXZpZXcgd2hlbiBpdCdzIHNvIG1peGVkIHVwIHdpdGggbXVs dGlwbGUgY2hhbmdlcyBhdCB0aGUgc2FtZQp0aW1lKS4KCnJlZ2FyZHMsCmRhbiBjYXJwZW50ZXIK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==