From: Stanislaw Gruszka <sgruszka@redhat.com>
To: yhchuang@realtek.com
Cc: kvalo@codeaurora.org, johannes@sipsolutions.net,
gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
Larry.Finger@lwfinger.net, pkshih@realtek.com,
tehuang@realtek.com, briannorris@chromium.org
Subject: Re: [PATCH v7 09/14] rtw88: chip files
Date: Mon, 11 Mar 2019 14:17:21 +0100 [thread overview]
Message-ID: <20190311131720.GA6089@redhat.com> (raw)
In-Reply-To: <1552139302-20476-10-git-send-email-yhchuang@realtek.com>
On Sat, Mar 09, 2019 at 09:48:17PM +0800, yhchuang@realtek.com wrote:
> + rtw_write32s_mask(rtwdev, REG_RFESEL8, MASKBYTE1, 0x57);
Using of 0xff00 would more readable for average developer than MASKBYTE1
IMHO all of those MASK* defines should be removed and replaced by hex
numbers or GENMASK() makro for non-standard masks like 0x3fe0 .
> + rtw_write32_mask(rtwdev, REG_CCASEL, MASKDWORD, reg82c);
MASKDWORD is 0xffffffff (all bits of 32 bit word), rtw_write32_mask()
can be just replaced by rtw_write32().
Stanislaw
next prev parent reply other threads:[~2019-03-11 13:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 13:48 [PATCH v7 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips yhchuang
2019-03-09 13:48 ` [PATCH v7 01/14] rtw88: main files yhchuang
2019-03-11 13:11 ` Stanislaw Gruszka
2019-03-11 13:14 ` Kalle Valo
2019-03-11 13:19 ` Stanislaw Gruszka
2019-03-11 13:32 ` Kalle Valo
2019-03-09 13:48 ` [PATCH v7 02/14] rtw88: core files yhchuang
2019-03-09 13:48 ` [PATCH v7 03/14] rtw88: hci files yhchuang
2019-03-11 12:50 ` Stanislaw Gruszka
2019-03-11 12:52 ` Johannes Berg
2019-03-09 13:48 ` [PATCH v7 04/14] rtw88: trx files yhchuang
2019-03-09 13:48 ` [PATCH v7 05/14] rtw88: mac files yhchuang
2019-03-09 13:48 ` [PATCH v7 06/14] rtw88: fw and efuse files yhchuang
2019-03-09 13:48 ` [PATCH v7 07/14] rtw88: phy files yhchuang
2019-03-09 13:48 ` [PATCH v7 08/14] rtw88: debug files yhchuang
2019-03-09 13:48 ` [PATCH v7 09/14] rtw88: chip files yhchuang
2019-03-11 13:17 ` Stanislaw Gruszka [this message]
2019-03-09 13:48 ` [PATCH v7 10/14] rtw88: 8822B init table yhchuang
2019-03-09 13:48 ` [PATCH v7 11/14] rtw88: 8822C " yhchuang
2019-03-09 13:48 ` [PATCH v7 12/14] rtw88: Kconfig & Makefile yhchuang
2019-03-09 13:48 ` [PATCH v7 13/14] rtw88: add MAINTAINERS entry yhchuang
2019-03-11 13:48 ` [PATCH v7 00/14] rtw88: mac80211 driver for Realtek 802.11ac wireless network chips Kalle Valo
2019-03-11 13:58 ` Stanislaw Gruszka
2019-03-12 5:14 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190311131720.GA6089@redhat.com \
--to=sgruszka@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.