From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE8B4C43381 for ; Mon, 11 Mar 2019 14:01:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FD7520857 for ; Mon, 11 Mar 2019 14:01:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552312904; bh=6wcilqyb4aQjpqrmBwUx6Nq4jANm14HdWg0P1G0r0cA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Iic1M5F7DRh8oh4Rw0P0on79NYpVWdjh+T3iEVegFe5pVOrT94q6hVO/SQsUvqTFt y8cJxF643fN1wiR8RNe/ivMDvwedUoBqVzSDgOL2MyiZJH9IwL6wuifnpfX6FJUhq0 KnSW0L83ANIjJwLGkP96/D2/blgyNIL07S+nA1sA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727498AbfCKOBo (ORCPT ); Mon, 11 Mar 2019 10:01:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:52506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726897AbfCKOBn (ORCPT ); Mon, 11 Mar 2019 10:01:43 -0400 Received: from localhost (50-82-46-41.client.mchsi.com [50.82.46.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE9CB20657; Mon, 11 Mar 2019 14:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552312902; bh=6wcilqyb4aQjpqrmBwUx6Nq4jANm14HdWg0P1G0r0cA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FoK0VlP1j9uDENp2jAxHMZTD32jb4E+85bPq35zxVvJhY1W2BrRkUt7wXYixaGpBw OoBMhgKtDLKaE/SzOHQQ25gpKG3cU32nEMPzeE6qjmavyHw0o3ufwCoES11GWo5ypA nProHHmU5vh8VUsT7SGnRT8Q2FiNaAZcfbGOXie8= Date: Mon, 11 Mar 2019 09:01:40 -0500 From: Bjorn Helgaas To: "Z.q. Hou" Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "l.subrahmanya@mobiveil.co.in" , "shawnguo@kernel.org" , Leo Li , "lorenzo.pieralisi@arm.com" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , Mingkai Hu , "M.h. Lian" , Xiaowei Bao Subject: Re: [PATCHv4 24/28] PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs Message-ID: <20190311140140.GA161843@google.com> References: <20190311093130.7209-1-Zhiqiang.Hou@nxp.com> <20190311093130.7209-25-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190311093130.7209-25-Zhiqiang.Hou@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Mar 11, 2019 at 09:33:16AM +0000, Z.q. Hou wrote: > From: Hou Zhiqiang > > This PCIe controller is based on the Mobiveil GPEX IP, which is > compatible with the PCI Express™ Base Specification, Revision 4.0. > > Signed-off-by: Hou Zhiqiang > Reviewed-by: Minghuan Lian > --- > V4: > - no change > > drivers/pci/controller/mobiveil/Kconfig | 10 + > drivers/pci/controller/mobiveil/Makefile | 1 + > .../controller/mobiveil/pci-layerscape-gen4.c | 254 ++++++++++++++++++ > .../pci/controller/mobiveil/pcie-mobiveil.h | 16 +- > 4 files changed, 279 insertions(+), 2 deletions(-) > create mode 100644 drivers/pci/controller/mobiveil/pci-layerscape-gen4.c > > diff --git a/drivers/pci/controller/mobiveil/Kconfig b/drivers/pci/controller/mobiveil/Kconfig > index 64343c07bfed..3ddb7d6163a9 100644 > --- a/drivers/pci/controller/mobiveil/Kconfig > +++ b/drivers/pci/controller/mobiveil/Kconfig > @@ -21,4 +21,14 @@ config PCIE_MOBIVEIL_PLAT > Soft IP. It has up to 8 outbound and inbound windows > for address translation and it is a PCIe Gen4 IP. > > +config PCI_LAYERSCAPE_GEN4 > + bool "Freescale Layerscpe PCIe Gen4 controller" "Layerscape" > + depends on PCI > + depends on OF && (ARM64 || ARCH_LAYERSCAPE) > + depends on PCI_MSI_IRQ_DOMAIN > + select PCIE_MOBIVEIL_HOST > + help > + Say Y here if you want PCIe Gen4 controller support on > + Layerscape SoCs. The PCIe controller can work in RC or > + EP mode according to RCW[HOST_AGT_PEX] setting. > endmenu > diff --git a/drivers/pci/controller/mobiveil/Makefile b/drivers/pci/controller/mobiveil/Makefile > index 9fb6d1c6504d..ff66774ccac4 100644 > --- a/drivers/pci/controller/mobiveil/Makefile > +++ b/drivers/pci/controller/mobiveil/Makefile > @@ -2,3 +2,4 @@ > obj-$(CONFIG_PCIE_MOBIVEIL) += pcie-mobiveil.o > obj-$(CONFIG_PCIE_MOBIVEIL_HOST) += pcie-mobiveil-host.o > obj-$(CONFIG_PCIE_MOBIVEIL_PLAT) += pcie-mobiveil-plat.o > +obj-$(CONFIG_PCI_LAYERSCAPE_GEN4) += pci-layerscape-gen4.o > diff --git a/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c > new file mode 100644 > index 000000000000..174cbcac4059 > --- /dev/null > +++ b/drivers/pci/controller/mobiveil/pci-layerscape-gen4.c > @@ -0,0 +1,254 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * PCIe host controller driver for NXP Layerscape SoCs It would be nice to make "NXP Layerscape SoCs" a little more specific so we can tell how it's different from the existing pci-layerscape.c that says "Freescale Layerscape SoCs". I assume this driver only works with gen4 parts. > + * Copyright 2018 NXP s/2018/2019/ > + * > + * Author: Zhiqiang Hou > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "pcie-mobiveil.h" > + > +/* LUT and PF control registers */ > +#define PCIE_LUT_OFF (0x80000) > +#define PCIE_PF_OFF (0xc0000) > +#define PCIE_PF_INT_STAT (0x18) > +#define PF_INT_STAT_PABRST (31) You mix constants that are - the bit position (like this), and - the actual bit mask, like PAB_INTP_RESET Pick one and use a single style. My personal preference is a plain hex bit mask, e.g., #define PF_INT_STAT_PABRST 0x80000000 #define PAB_INTP_RESET 0x00000002 But some people like BIT() or the style you used for PAB_INTP_RESET: #define PAB_INTP_RESET BIT(1) #define PAB_INTP_RESET (0x1 << 1) I definitely don't like the simple bit position like this: #define PF_INT_STAT_PABRST 31 because that means you have to repeat things like "1 << PF_INT_STAT_PABRST" everywhere you use it. > +#define PCIE_PF_DBG (0x7fc) > +#define PF_DBG_LTSSM_MASK (0x3f) > +#define PF_DBG_WE (31) > +#define PF_DBG_PABR (27) Parens are not needed around single constants like these. > +#define LS_PCIE_G4_LTSSM_L0 0x2d /* L0 state */ > + > +#define to_ls_pcie_g4(x) platform_get_drvdata((x)->pdev) > + > +struct ls_pcie_g4 { > + struct mobiveil_pcie *pci; > + struct delayed_work dwork; > + int irq; > +}; > + > +static inline u32 ls_pcie_g4_lut_readl(struct ls_pcie_g4 *pcie, u32 off) > +{ > + return ioread32(pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF + off); > +} > + > +static inline void ls_pcie_g4_lut_writel(struct ls_pcie_g4 *pcie, > + u32 off, u32 val) > +{ > + iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_LUT_OFF + off); > +} > + > +static inline u32 ls_pcie_g4_pf_readl(struct ls_pcie_g4 *pcie, u32 off) > +{ > + return ioread32(pcie->pci->csr_axi_slave_base + PCIE_PF_OFF + off); > +} > + > +static inline void ls_pcie_g4_pf_writel(struct ls_pcie_g4 *pcie, > + u32 off, u32 val) > +{ > + iowrite32(val, pcie->pci->csr_axi_slave_base + PCIE_PF_OFF + off); > +} > + > +static bool ls_pcie_g4_is_bridge(struct ls_pcie_g4 *pcie) > +{ > + struct mobiveil_pcie *mv_pci = pcie->pci; > + u32 header_type; > + > + header_type = csr_readb(mv_pci, PCI_HEADER_TYPE); > + header_type &= 0x7f; > + > + return header_type == PCI_HEADER_TYPE_BRIDGE; > +} > + > +static int ls_pcie_g4_link_up(struct mobiveil_pcie *pci) > +{ > + struct ls_pcie_g4 *pcie = to_ls_pcie_g4(pci); > + u32 state; > + > + state = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG); > + state = state & PF_DBG_LTSSM_MASK; > + > + if (state == LS_PCIE_G4_LTSSM_L0) > + return 1; > + > + return 0; > +} > + > +static void ls_pcie_g4_reinit_hw(struct ls_pcie_g4 *pcie) > +{ > + struct mobiveil_pcie *mv_pci = pcie->pci; > + u32 val, act_stat; > + int to = 100; > + > + /* Poll for pab_csb_reset to set and PAB activity to clear */ > + do { > + usleep_range(10, 15); > + val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_INT_STAT); > + act_stat = csr_readl(mv_pci, PAB_ACTIVITY_STAT); > + } while (((val & 1 << PF_INT_STAT_PABRST) == 0 || act_stat) && to--); > + if (to < 0) { > + dev_err(&mv_pci->pdev->dev, "poll PABRST&PABACT timeout\n"); > + return; > + } > + > + /* clear PEX_RESET bit in PEX_PF0_DBG register */ > + val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG); > + val |= 1 << PF_DBG_WE; > + ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val); > + > + val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG); > + val |= 1 << PF_DBG_PABR; > + ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val); > + > + val = ls_pcie_g4_pf_readl(pcie, PCIE_PF_DBG); > + val &= ~(1 << PF_DBG_WE); > + ls_pcie_g4_pf_writel(pcie, PCIE_PF_DBG, val); > + > + mobiveil_host_init(mv_pci, true); > + > + to = 100; > + while (!ls_pcie_g4_link_up(mv_pci) && to--) > + usleep_range(200, 250); > + if (to < 0) > + dev_err(&mv_pci->pdev->dev, "PCIe link trainning timeout\n"); s/trainning/training/ > +} > + > +static irqreturn_t ls_pcie_g4_handler(int irq, void *dev_id) Function name should include "irq_handler" or "isr". Run git grep request_irq drivers/pci/controller/ and follow the existing conventions. > +{ > + struct ls_pcie_g4 *pcie = (struct ls_pcie_g4 *)dev_id; > + struct mobiveil_pcie *mv_pci = pcie->pci; > + u32 val; > + > + val = csr_readl(mv_pci, PAB_INTP_AMBA_MISC_STAT); > + if (!val) > + return IRQ_NONE; > + > + if (val & PAB_INTP_RESET) > + schedule_delayed_work(&pcie->dwork, msecs_to_jiffies(1)); > + > + csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_STAT); > + > + return IRQ_HANDLED; > +} > + > +static int ls_pcie_g4_interrupt_init(struct mobiveil_pcie *mv_pci) > +{ > + struct ls_pcie_g4 *pcie = to_ls_pcie_g4(mv_pci); > + u32 val; > + int ret; > + > + pcie->irq = platform_get_irq_byname(mv_pci->pdev, "intr"); > + if (pcie->irq < 0) { > + dev_err(&mv_pci->pdev->dev, "Can't get 'intr' irq.\n"); When you use &mv_pci->pdev->dev more than once, as you do here, please add struct device *dev = &mv_pci->pdev->dev; and use "dev" instead of repeating the whole "&mv_pci->pdev->dev" expression. s/irq./IRQ/ (Capitalize IRQ and omit period) > + return pcie->irq; > + } > + ret = devm_request_irq(&mv_pci->pdev->dev, pcie->irq, > + ls_pcie_g4_handler, IRQF_SHARED, > + mv_pci->pdev->name, pcie); > + if (ret) { > + dev_err(&mv_pci->pdev->dev, "Can't register PCIe IRQ.\n"); Omit period from message and maybe include the IRQ number. All your messages should start with lower-case or all should start with upper-case (the two in this function are capitalized, but the others are not). > + return ret; > + } > + > + /* Enable interrupts */ > + val = PAB_INTP_INTX_MASK | PAB_INTP_MSI | PAB_INTP_RESET | > + PAB_INTP_PCIE_UE | PAB_INTP_IE_PMREDI | PAB_INTP_IE_EC; > + csr_writel(mv_pci, val, PAB_INTP_AMBA_MISC_ENB); > + > + return 0; > +} > + > +static void ls_pcie_g4_reset(struct work_struct *work) > +{ > + struct delayed_work *dwork = container_of(work, struct delayed_work, > + work); > + struct ls_pcie_g4 *pcie = container_of(dwork, struct ls_pcie_g4, dwork); > + struct mobiveil_pcie *mv_pci = pcie->pci; > + u16 ctrl; > + > + ctrl = csr_readw(mv_pci, PCI_BRIDGE_CONTROL); > + ctrl &= ~PCI_BRIDGE_CTL_BUS_RESET; > + csr_writew(mv_pci, ctrl, PCI_BRIDGE_CONTROL); > + ls_pcie_g4_reinit_hw(pcie); > +} > + > +static struct mobiveil_rp_ops ls_pcie_g4_rp_ops = { > + .interrupt_init = ls_pcie_g4_interrupt_init, > +}; > + > +static const struct mobiveil_pab_ops ls_pcie_g4_pab_ops = { > + .link_up = ls_pcie_g4_link_up, > +}; > + > +static int __init ls_pcie_g4_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct mobiveil_pcie *mv_pci; > + struct ls_pcie_g4 *pcie; > + struct device_node *np = dev->of_node; > + int ret; > + > + if (!of_parse_phandle(np, "msi-parent", 0)) { > + dev_err(dev, "failed to find msi-parent\n"); > + return -EINVAL; > + } > + > + pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL); > + if (!pcie) > + return -ENOMEM; > + > + mv_pci = devm_kzalloc(dev, sizeof(*mv_pci), GFP_KERNEL); > + if (!mv_pci) > + return -ENOMEM; > + > + mv_pci->pdev = pdev; > + mv_pci->ops = &ls_pcie_g4_pab_ops; > + mv_pci->rp.ops = &ls_pcie_g4_rp_ops; > + pcie->pci = mv_pci; > + > + platform_set_drvdata(pdev, pcie); > + > + INIT_DELAYED_WORK(&pcie->dwork, ls_pcie_g4_reset); > + > + ret = mobiveil_pcie_host_probe(mv_pci); > + if (ret) { > + dev_err(dev, "fail to probe!\n"); > + return ret; > + } > + > + if (!ls_pcie_g4_is_bridge(pcie)) > + return -ENODEV; > + > + return 0; > +} > + > +static const struct of_device_id ls_pcie_g4_of_match[] = { > + { .compatible = "fsl,lx2160a-pcie", }, > + { }, > +}; > + > +static struct platform_driver ls_pcie_g4_driver = { > + .driver = { > + .name = "layerscape-pcie-gen4", > + .of_match_table = ls_pcie_g4_of_match, > + .suppress_bind_attrs = true, > + }, > +}; > + > +builtin_platform_driver_probe(ls_pcie_g4_driver, ls_pcie_g4_probe); > diff --git a/drivers/pci/controller/mobiveil/pcie-mobiveil.h b/drivers/pci/controller/mobiveil/pcie-mobiveil.h > index 0f5303962e88..0ccd6cee5f8f 100644 > --- a/drivers/pci/controller/mobiveil/pcie-mobiveil.h > +++ b/drivers/pci/controller/mobiveil/pcie-mobiveil.h > @@ -41,6 +41,8 @@ > #define PAGE_LO_MASK 0x3ff > #define PAGE_SEL_OFFSET_SHIFT 10 > > +#define PAB_ACTIVITY_STAT 0x81c > + > #define PAB_AXI_PIO_CTRL 0x0840 > #define APIO_EN_MASK 0xf > > @@ -49,8 +51,18 @@ > > #define PAB_INTP_AMBA_MISC_ENB 0x0b0c > #define PAB_INTP_AMBA_MISC_STAT 0x0b1c > -#define PAB_INTP_INTX_MASK 0x01e0 > -#define PAB_INTP_MSI_MASK 0x8 > +#define PAB_INTP_RESET (0x1 << 1) > +#define PAB_INTP_MSI (0x1 << 3) > +#define PAB_INTP_INTA (0x1 << 5) > +#define PAB_INTP_INTB (0x1 << 6) > +#define PAB_INTP_INTC (0x1 << 7) > +#define PAB_INTP_INTD (0x1 << 8) > +#define PAB_INTP_PCIE_UE (0x1 << 9) > +#define PAB_INTP_IE_PMREDI (0x1 << 29) > +#define PAB_INTP_IE_EC (0x1 << 30) > +#define PAB_INTP_MSI_MASK PAB_INTP_MSI > +#define PAB_INTP_INTX_MASK (PAB_INTP_INTA | PAB_INTP_INTB |\ > + PAB_INTP_INTC | PAB_INTP_INTD) > > #define PAB_AXI_AMAP_CTRL(win) PAB_REG_ADDR(0x0ba0, win) > #define WIN_ENABLE_SHIFT 0 > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2476FC43381 for ; Mon, 11 Mar 2019 14:02:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7AF820657 for ; Mon, 11 Mar 2019 14:02:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZBzVNpAz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FoK0VlP1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7AF820657 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GaJhG34K58YGxJgSac6/XI8u6LrfN7zxVndMZ2JPRhA=; b=ZBzVNpAztJ9oeh vKyN7VGqyIe1//lSXYJQ/ybTcJEnbzCz5llxvI/yhf7AAVWUwjYPX8WCBjXugky010vrzM/6jaXJC yvLawu/Ag/O88mFUMpXJrGaq3abN+np4uGcOZERyUByI8DLgvEwIjf5avG9QoP3KXHUSVqR79PaU4 qGor7y3/L1Xn8G4MvaRUOh+0Xr9Fw9MY2sU3yz2MvV5XYHYB7qkHtqwQQczG0qIHt9x9wl6PnCNOJ jEyG76V5OLK1wdfii9/08ascbp6PbMgTQXl/emjclAyK9Cv77asHHC0MPy0Cg4/widpGKVXYpN/yJ pXPmNLqBhKvK9mJVunSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3LV0-0008NN-E2; Mon, 11 Mar 2019 14:01:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3LUs-0008Lo-HO for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2019 14:01:48 +0000 Received: from localhost (50-82-46-41.client.mchsi.com [50.82.46.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE9CB20657; Mon, 11 Mar 2019 14:01:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552312902; bh=6wcilqyb4aQjpqrmBwUx6Nq4jANm14HdWg0P1G0r0cA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FoK0VlP1j9uDENp2jAxHMZTD32jb4E+85bPq35zxVvJhY1W2BrRkUt7wXYixaGpBw OoBMhgKtDLKaE/SzOHQQ25gpKG3cU32nEMPzeE6qjmavyHw0o3ufwCoES11GWo5ypA nProHHmU5vh8VUsT7SGnRT8Q2FiNaAZcfbGOXie8= Date: Mon, 11 Mar 2019 09:01:40 -0500 From: Bjorn Helgaas To: "Z.q. Hou" Subject: Re: [PATCHv4 24/28] PCI: mobiveil: add PCIe Gen4 RC driver for NXP Layerscape SoCs Message-ID: <20190311140140.GA161843@google.com> References: <20190311093130.7209-1-Zhiqiang.Hou@nxp.com> <20190311093130.7209-25-Zhiqiang.Hou@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190311093130.7209-25-Zhiqiang.Hou@nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190311_070142_616340_CC332B48 X-CRM114-Status: GOOD ( 30.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , Xiaowei Bao , "linux-pci@vger.kernel.org" , "l.subrahmanya@mobiveil.co.in" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , Leo Li , "M.h. Lian" , "robh+dt@kernel.org" , Mingkai Hu , "catalin.marinas@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXIgMTEsIDIwMTkgYXQgMDk6MzM6MTZBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6 Cj4gRnJvbTogSG91IFpoaXFpYW5nIDxaaGlxaWFuZy5Ib3VAbnhwLmNvbT4KPiAKPiBUaGlzIFBD SWUgY29udHJvbGxlciBpcyBiYXNlZCBvbiB0aGUgTW9iaXZlaWwgR1BFWCBJUCwgd2hpY2ggaXMK PiBjb21wYXRpYmxlIHdpdGggdGhlIFBDSSBFeHByZXNz4oSiIEJhc2UgU3BlY2lmaWNhdGlvbiwg UmV2aXNpb24gNC4wLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEhvdSBaaGlxaWFuZyA8WmhpcWlhbmcu SG91QG54cC5jb20+Cj4gUmV2aWV3ZWQtYnk6IE1pbmdodWFuIExpYW4gPE1pbmdodWFuLkxpYW5A bnhwLmNvbT4KPiAtLS0KPiBWNDoKPiAgLSBubyBjaGFuZ2UKPiAKPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9tb2JpdmVpbC9LY29uZmlnICAgICAgIHwgIDEwICsKPiAgZHJpdmVycy9wY2kvY29u dHJvbGxlci9tb2JpdmVpbC9NYWtlZmlsZSAgICAgIHwgICAxICsKPiAgLi4uL2NvbnRyb2xsZXIv bW9iaXZlaWwvcGNpLWxheWVyc2NhcGUtZ2VuNC5jIHwgMjU0ICsrKysrKysrKysrKysrKysrKwo+ ICAuLi4vcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvcGNpZS1tb2JpdmVpbC5oICAgfCAgMTYgKy0K PiAgNCBmaWxlcyBjaGFuZ2VkLCAyNzkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAg Y3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvcGNpLWxh eWVyc2NhcGUtZ2VuNC5jCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIv bW9iaXZlaWwvS2NvbmZpZyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvS2NvbmZp Zwo+IGluZGV4IDY0MzQzYzA3YmZlZC4uM2RkYjdkNjE2M2E5IDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvcGNpL2Nv bnRyb2xsZXIvbW9iaXZlaWwvS2NvbmZpZwo+IEBAIC0yMSw0ICsyMSwxNCBAQCBjb25maWcgUENJ RV9NT0JJVkVJTF9QTEFUCj4gIAkgIFNvZnQgSVAuIEl0IGhhcyB1cCB0byA4IG91dGJvdW5kIGFu ZCBpbmJvdW5kIHdpbmRvd3MKPiAgCSAgZm9yIGFkZHJlc3MgdHJhbnNsYXRpb24gYW5kIGl0IGlz IGEgUENJZSBHZW40IElQLgo+ICAKPiArY29uZmlnIFBDSV9MQVlFUlNDQVBFX0dFTjQKPiArCWJv b2wgIkZyZWVzY2FsZSBMYXllcnNjcGUgUENJZSBHZW40IGNvbnRyb2xsZXIiCgoiTGF5ZXJzY2Fw ZSIKCj4gKwlkZXBlbmRzIG9uIFBDSQo+ICsJZGVwZW5kcyBvbiBPRiAmJiAoQVJNNjQgfHwgQVJD SF9MQVlFUlNDQVBFKQo+ICsJZGVwZW5kcyBvbiBQQ0lfTVNJX0lSUV9ET01BSU4KPiArCXNlbGVj dCBQQ0lFX01PQklWRUlMX0hPU1QKPiArCWhlbHAKPiArCSAgU2F5IFkgaGVyZSBpZiB5b3Ugd2Fu dCBQQ0llIEdlbjQgY29udHJvbGxlciBzdXBwb3J0IG9uCj4gKwkgIExheWVyc2NhcGUgU29Dcy4g VGhlIFBDSWUgY29udHJvbGxlciBjYW4gd29yayBpbiBSQyBvcgo+ICsJICBFUCBtb2RlIGFjY29y ZGluZyB0byBSQ1dbSE9TVF9BR1RfUEVYXSBzZXR0aW5nLgo+ICBlbmRtZW51Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvTWFrZWZpbGUgYi9kcml2ZXJzL3Bj aS9jb250cm9sbGVyL21vYml2ZWlsL01ha2VmaWxlCj4gaW5kZXggOWZiNmQxYzY1MDRkLi5mZjY2 Nzc0Y2NhYzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci9tb2JpdmVpbC9N YWtlZmlsZQo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvTWFrZWZpbGUK PiBAQCAtMiwzICsyLDQgQEAKPiAgb2JqLSQoQ09ORklHX1BDSUVfTU9CSVZFSUwpICs9IHBjaWUt bW9iaXZlaWwubwo+ICBvYmotJChDT05GSUdfUENJRV9NT0JJVkVJTF9IT1NUKSArPSBwY2llLW1v Yml2ZWlsLWhvc3Qubwo+ICBvYmotJChDT05GSUdfUENJRV9NT0JJVkVJTF9QTEFUKSArPSBwY2ll LW1vYml2ZWlsLXBsYXQubwo+ICtvYmotJChDT05GSUdfUENJX0xBWUVSU0NBUEVfR0VONCkgKz0g cGNpLWxheWVyc2NhcGUtZ2VuNC5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRyb2xs ZXIvbW9iaXZlaWwvcGNpLWxheWVyc2NhcGUtZ2VuNC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxl ci9tb2JpdmVpbC9wY2ktbGF5ZXJzY2FwZS1nZW40LmMKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ IGluZGV4IDAwMDAwMDAwMDAwMC4uMTc0Y2JjYWM0MDU5Cj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBi L2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvcGNpLWxheWVyc2NhcGUtZ2VuNC5jCj4g QEAgLTAsMCArMSwyNTQgQEAKPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAK PiArLyoKPiArICogUENJZSBob3N0IGNvbnRyb2xsZXIgZHJpdmVyIGZvciBOWFAgTGF5ZXJzY2Fw ZSBTb0NzCgpJdCB3b3VsZCBiZSBuaWNlIHRvIG1ha2UgIk5YUCBMYXllcnNjYXBlIFNvQ3MiIGEg bGl0dGxlIG1vcmUgc3BlY2lmaWMKc28gd2UgY2FuIHRlbGwgaG93IGl0J3MgZGlmZmVyZW50IGZy b20gdGhlIGV4aXN0aW5nIHBjaS1sYXllcnNjYXBlLmMKdGhhdCBzYXlzICJGcmVlc2NhbGUgTGF5 ZXJzY2FwZSBTb0NzIi4gIEkgYXNzdW1lIHRoaXMgZHJpdmVyIG9ubHkKd29ya3Mgd2l0aCBnZW40 IHBhcnRzLgoKPiArICogQ29weXJpZ2h0IDIwMTggTlhQCgpzLzIwMTgvMjAxOS8KCj4gKyAqCj4g KyAqIEF1dGhvcjogWmhpcWlhbmcgSG91IDxaaGlxaWFuZy5Ib3VAbnhwLmNvbT4KPiArICovCj4g Kwo+ICsjaW5jbHVkZSA8bGludXgva2VybmVsLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9pbnRlcnJ1 cHQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L2luaXQuaD4KPiArI2luY2x1ZGUgPGxpbnV4L29mX3Bj aS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfcGxhdGZvcm0uaD4KPiArI2luY2x1ZGUgPGxpbnV4 L29mX2lycS5oPgo+ICsjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5oPgo+ICsjaW5jbHVkZSA8 bGludXgvcGNpLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9kZXZpY2UuaD4KPiArI2lu Y2x1ZGUgPGxpbnV4L3Jlc291cmNlLmg+Cj4gKyNpbmNsdWRlIDxsaW51eC9tZmQvc3lzY29uLmg+ Cj4gKyNpbmNsdWRlIDxsaW51eC9yZWdtYXAuaD4KPiArCj4gKyNpbmNsdWRlICJwY2llLW1vYml2 ZWlsLmgiCj4gKwo+ICsvKiBMVVQgYW5kIFBGIGNvbnRyb2wgcmVnaXN0ZXJzICovCj4gKyNkZWZp bmUgUENJRV9MVVRfT0ZGCQkJKDB4ODAwMDApCj4gKyNkZWZpbmUgUENJRV9QRl9PRkYJCQkoMHhj MDAwMCkKPiArI2RlZmluZSBQQ0lFX1BGX0lOVF9TVEFUCQkoMHgxOCkKPiArI2RlZmluZSBQRl9J TlRfU1RBVF9QQUJSU1QJCSgzMSkKCllvdSBtaXggY29uc3RhbnRzIHRoYXQgYXJlCgogIC0gdGhl IGJpdCBwb3NpdGlvbiAobGlrZSB0aGlzKSwgYW5kCiAgLSB0aGUgYWN0dWFsIGJpdCBtYXNrLCBs aWtlIFBBQl9JTlRQX1JFU0VUCgpQaWNrIG9uZSBhbmQgdXNlIGEgc2luZ2xlIHN0eWxlLiAgTXkg cGVyc29uYWwgcHJlZmVyZW5jZSBpcyBhIHBsYWluCmhleCBiaXQgbWFzaywgZS5nLiwKCiAgI2Rl ZmluZSBQRl9JTlRfU1RBVF9QQUJSU1QgICAgMHg4MDAwMDAwMAogICNkZWZpbmUgUEFCX0lOVFBf UkVTRVQgICAgICAgIDB4MDAwMDAwMDIKCkJ1dCBzb21lIHBlb3BsZSBsaWtlIEJJVCgpIG9yIHRo ZSBzdHlsZSB5b3UgdXNlZCBmb3IgUEFCX0lOVFBfUkVTRVQ6CgogICNkZWZpbmUgUEFCX0lOVFBf UkVTRVQgICAgICAgIEJJVCgxKQogICNkZWZpbmUgUEFCX0lOVFBfUkVTRVQgICAgICAgICgweDEg PDwgMSkKCkkgZGVmaW5pdGVseSBkb24ndCBsaWtlIHRoZSBzaW1wbGUgYml0IHBvc2l0aW9uIGxp a2UgdGhpczoKCiAgI2RlZmluZSBQRl9JTlRfU1RBVF9QQUJSU1QgICAgMzEKCmJlY2F1c2UgdGhh dCBtZWFucyB5b3UgaGF2ZSB0byByZXBlYXQgdGhpbmdzIGxpa2UKIjEgPDwgUEZfSU5UX1NUQVRf UEFCUlNUIiBldmVyeXdoZXJlIHlvdSB1c2UgaXQuCgo+ICsjZGVmaW5lIFBDSUVfUEZfREJHCQkJ KDB4N2ZjKQo+ICsjZGVmaW5lIFBGX0RCR19MVFNTTV9NQVNLCQkoMHgzZikKPiArI2RlZmluZSBQ Rl9EQkdfV0UJCQkoMzEpCj4gKyNkZWZpbmUgUEZfREJHX1BBQlIJCQkoMjcpCgpQYXJlbnMgYXJl IG5vdCBuZWVkZWQgYXJvdW5kIHNpbmdsZSBjb25zdGFudHMgbGlrZSB0aGVzZS4KCj4gKyNkZWZp bmUgTFNfUENJRV9HNF9MVFNTTV9MMAkJMHgyZCAvKiBMMCBzdGF0ZSAqLwo+ICsKPiArI2RlZmlu ZSB0b19sc19wY2llX2c0KHgpCQlwbGF0Zm9ybV9nZXRfZHJ2ZGF0YSgoeCktPnBkZXYpCj4gKwo+ ICtzdHJ1Y3QgbHNfcGNpZV9nNCB7Cj4gKwlzdHJ1Y3QgbW9iaXZlaWxfcGNpZSAqcGNpOwo+ICsJ c3RydWN0IGRlbGF5ZWRfd29yayBkd29yazsKPiArCWludCBpcnE7Cj4gK307Cj4gKwo+ICtzdGF0 aWMgaW5saW5lIHUzMiBsc19wY2llX2c0X2x1dF9yZWFkbChzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNp ZSwgdTMyIG9mZikKPiArewo+ICsJcmV0dXJuIGlvcmVhZDMyKHBjaWUtPnBjaS0+Y3NyX2F4aV9z bGF2ZV9iYXNlICsgUENJRV9MVVRfT0ZGICsgb2ZmKTsKPiArfQo+ICsKPiArc3RhdGljIGlubGlu ZSB2b2lkIGxzX3BjaWVfZzRfbHV0X3dyaXRlbChzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNpZSwKPiAr CQkJCQkgdTMyIG9mZiwgdTMyIHZhbCkKPiArewo+ICsJaW93cml0ZTMyKHZhbCwgcGNpZS0+cGNp LT5jc3JfYXhpX3NsYXZlX2Jhc2UgKyBQQ0lFX0xVVF9PRkYgKyBvZmYpOwo+ICt9Cj4gKwo+ICtz dGF0aWMgaW5saW5lIHUzMiBsc19wY2llX2c0X3BmX3JlYWRsKHN0cnVjdCBsc19wY2llX2c0ICpw Y2llLCB1MzIgb2ZmKQo+ICt7Cj4gKwlyZXR1cm4gaW9yZWFkMzIocGNpZS0+cGNpLT5jc3JfYXhp X3NsYXZlX2Jhc2UgKyBQQ0lFX1BGX09GRiArIG9mZik7Cj4gK30KPiArCj4gK3N0YXRpYyBpbmxp bmUgdm9pZCBsc19wY2llX2c0X3BmX3dyaXRlbChzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNpZSwKPiAr CQkJCQl1MzIgb2ZmLCB1MzIgdmFsKQo+ICt7Cj4gKwlpb3dyaXRlMzIodmFsLCBwY2llLT5wY2kt PmNzcl9heGlfc2xhdmVfYmFzZSArIFBDSUVfUEZfT0ZGICsgb2ZmKTsKPiArfQo+ICsKPiArc3Rh dGljIGJvb2wgbHNfcGNpZV9nNF9pc19icmlkZ2Uoc3RydWN0IGxzX3BjaWVfZzQgKnBjaWUpCj4g K3sKPiArCXN0cnVjdCBtb2JpdmVpbF9wY2llICptdl9wY2kgPSBwY2llLT5wY2k7Cj4gKwl1MzIg aGVhZGVyX3R5cGU7Cj4gKwo+ICsJaGVhZGVyX3R5cGUgPSBjc3JfcmVhZGIobXZfcGNpLCBQQ0lf SEVBREVSX1RZUEUpOwo+ICsJaGVhZGVyX3R5cGUgJj0gMHg3ZjsKPiArCj4gKwlyZXR1cm4gaGVh ZGVyX3R5cGUgPT0gUENJX0hFQURFUl9UWVBFX0JSSURHRTsKPiArfQo+ICsKPiArc3RhdGljIGlu dCBsc19wY2llX2c0X2xpbmtfdXAoc3RydWN0IG1vYml2ZWlsX3BjaWUgKnBjaSkKPiArewo+ICsJ c3RydWN0IGxzX3BjaWVfZzQgKnBjaWUgPSB0b19sc19wY2llX2c0KHBjaSk7Cj4gKwl1MzIgc3Rh dGU7Cj4gKwo+ICsJc3RhdGUgPSBsc19wY2llX2c0X3BmX3JlYWRsKHBjaWUsIFBDSUVfUEZfREJH KTsKPiArCXN0YXRlID0Jc3RhdGUgJiBQRl9EQkdfTFRTU01fTUFTSzsKPiArCj4gKwlpZiAoc3Rh dGUgPT0gTFNfUENJRV9HNF9MVFNTTV9MMCkKPiArCQlyZXR1cm4gMTsKPiArCj4gKwlyZXR1cm4g MDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgbHNfcGNpZV9nNF9yZWluaXRfaHcoc3RydWN0IGxz X3BjaWVfZzQgKnBjaWUpCj4gK3sKPiArCXN0cnVjdCBtb2JpdmVpbF9wY2llICptdl9wY2kgPSBw Y2llLT5wY2k7Cj4gKwl1MzIgdmFsLCBhY3Rfc3RhdDsKPiArCWludCB0byA9IDEwMDsKPiArCj4g KwkvKiBQb2xsIGZvciBwYWJfY3NiX3Jlc2V0IHRvIHNldCBhbmQgUEFCIGFjdGl2aXR5IHRvIGNs ZWFyICovCj4gKwlkbyB7Cj4gKwkJdXNsZWVwX3JhbmdlKDEwLCAxNSk7Cj4gKwkJdmFsID0gbHNf cGNpZV9nNF9wZl9yZWFkbChwY2llLCBQQ0lFX1BGX0lOVF9TVEFUKTsKPiArCQlhY3Rfc3RhdCA9 IGNzcl9yZWFkbChtdl9wY2ksIFBBQl9BQ1RJVklUWV9TVEFUKTsKPiArCX0gd2hpbGUgKCgodmFs ICYgMSA8PCBQRl9JTlRfU1RBVF9QQUJSU1QpID09IDAgfHwgYWN0X3N0YXQpICYmIHRvLS0pOwo+ ICsJaWYgKHRvIDwgMCkgewo+ICsJCWRldl9lcnIoJm12X3BjaS0+cGRldi0+ZGV2LCAicG9sbCBQ QUJSU1QmUEFCQUNUIHRpbWVvdXRcbiIpOwo+ICsJCXJldHVybjsKPiArCX0KPiArCj4gKwkvKiBj bGVhciBQRVhfUkVTRVQgYml0IGluIFBFWF9QRjBfREJHIHJlZ2lzdGVyICovCj4gKwl2YWwgPSBs c19wY2llX2c0X3BmX3JlYWRsKHBjaWUsIFBDSUVfUEZfREJHKTsKPiArCXZhbCB8PSAxIDw8IFBG X0RCR19XRTsKPiArCWxzX3BjaWVfZzRfcGZfd3JpdGVsKHBjaWUsIFBDSUVfUEZfREJHLCB2YWwp Owo+ICsKPiArCXZhbCA9IGxzX3BjaWVfZzRfcGZfcmVhZGwocGNpZSwgUENJRV9QRl9EQkcpOwo+ ICsJdmFsIHw9IDEgPDwgUEZfREJHX1BBQlI7Cj4gKwlsc19wY2llX2c0X3BmX3dyaXRlbChwY2ll LCBQQ0lFX1BGX0RCRywgdmFsKTsKPiArCj4gKwl2YWwgPSBsc19wY2llX2c0X3BmX3JlYWRsKHBj aWUsIFBDSUVfUEZfREJHKTsKPiArCXZhbCAmPSB+KDEgPDwgUEZfREJHX1dFKTsKPiArCWxzX3Bj aWVfZzRfcGZfd3JpdGVsKHBjaWUsIFBDSUVfUEZfREJHLCB2YWwpOwo+ICsKPiArCW1vYml2ZWls X2hvc3RfaW5pdChtdl9wY2ksIHRydWUpOwo+ICsKPiArCXRvID0gMTAwOwo+ICsJd2hpbGUgKCFs c19wY2llX2c0X2xpbmtfdXAobXZfcGNpKSAmJiB0by0tKQo+ICsJCXVzbGVlcF9yYW5nZSgyMDAs IDI1MCk7Cj4gKwlpZiAodG8gPCAwKQo+ICsJCWRldl9lcnIoJm12X3BjaS0+cGRldi0+ZGV2LCAi UENJZSBsaW5rIHRyYWlubmluZyB0aW1lb3V0XG4iKTsKCnMvdHJhaW5uaW5nL3RyYWluaW5nLwoK PiArfQo+ICsKPiArc3RhdGljIGlycXJldHVybl90IGxzX3BjaWVfZzRfaGFuZGxlcihpbnQgaXJx LCB2b2lkICpkZXZfaWQpCgpGdW5jdGlvbiBuYW1lIHNob3VsZCBpbmNsdWRlICJpcnFfaGFuZGxl ciIgb3IgImlzciIuICBSdW4KCiAgZ2l0IGdyZXAgcmVxdWVzdF9pcnEgZHJpdmVycy9wY2kvY29u dHJvbGxlci8KCmFuZCBmb2xsb3cgdGhlIGV4aXN0aW5nIGNvbnZlbnRpb25zLgoKPiArewo+ICsJ c3RydWN0IGxzX3BjaWVfZzQgKnBjaWUgPSAoc3RydWN0IGxzX3BjaWVfZzQgKilkZXZfaWQ7Cj4g KwlzdHJ1Y3QgbW9iaXZlaWxfcGNpZSAqbXZfcGNpID0gcGNpZS0+cGNpOwo+ICsJdTMyIHZhbDsK PiArCj4gKwl2YWwgPSBjc3JfcmVhZGwobXZfcGNpLCBQQUJfSU5UUF9BTUJBX01JU0NfU1RBVCk7 Cj4gKwlpZiAoIXZhbCkKPiArCQlyZXR1cm4gSVJRX05PTkU7Cj4gKwo+ICsJaWYgKHZhbCAmIFBB Ql9JTlRQX1JFU0VUKQo+ICsJCXNjaGVkdWxlX2RlbGF5ZWRfd29yaygmcGNpZS0+ZHdvcmssIG1z ZWNzX3RvX2ppZmZpZXMoMSkpOwo+ICsKPiArCWNzcl93cml0ZWwobXZfcGNpLCB2YWwsIFBBQl9J TlRQX0FNQkFfTUlTQ19TVEFUKTsKPiArCj4gKwlyZXR1cm4gSVJRX0hBTkRMRUQ7Cj4gK30KPiAr Cj4gK3N0YXRpYyBpbnQgbHNfcGNpZV9nNF9pbnRlcnJ1cHRfaW5pdChzdHJ1Y3QgbW9iaXZlaWxf cGNpZSAqbXZfcGNpKQo+ICt7Cj4gKwlzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNpZSA9IHRvX2xzX3Bj aWVfZzQobXZfcGNpKTsKPiArCXUzMiB2YWw7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXBjaWUtPmly cSA9IHBsYXRmb3JtX2dldF9pcnFfYnluYW1lKG12X3BjaS0+cGRldiwgImludHIiKTsKPiArCWlm IChwY2llLT5pcnEgPCAwKSB7Cj4gKwkJZGV2X2VycigmbXZfcGNpLT5wZGV2LT5kZXYsICJDYW4n dCBnZXQgJ2ludHInIGlycS5cbiIpOwoKV2hlbiB5b3UgdXNlICZtdl9wY2ktPnBkZXYtPmRldiBt b3JlIHRoYW4gb25jZSwgYXMgeW91IGRvIGhlcmUsIHBsZWFzZQphZGQKCiAgc3RydWN0IGRldmlj ZSAqZGV2ID0gJm12X3BjaS0+cGRldi0+ZGV2OwoKYW5kIHVzZSAiZGV2IiBpbnN0ZWFkIG9mIHJl cGVhdGluZyB0aGUgd2hvbGUgIiZtdl9wY2ktPnBkZXYtPmRldiIKZXhwcmVzc2lvbi4KCnMvaXJx Li9JUlEvIChDYXBpdGFsaXplIElSUSBhbmQgb21pdCBwZXJpb2QpCgo+ICsJCXJldHVybiBwY2ll LT5pcnE7Cj4gKwl9Cj4gKwlyZXQgPSBkZXZtX3JlcXVlc3RfaXJxKCZtdl9wY2ktPnBkZXYtPmRl diwgcGNpZS0+aXJxLAo+ICsJCQkgICAgICAgbHNfcGNpZV9nNF9oYW5kbGVyLCBJUlFGX1NIQVJF RCwKPiArCQkJICAgICAgIG12X3BjaS0+cGRldi0+bmFtZSwgcGNpZSk7Cj4gKwlpZiAocmV0KSB7 Cj4gKwkJZGV2X2VycigmbXZfcGNpLT5wZGV2LT5kZXYsICJDYW4ndCByZWdpc3RlciBQQ0llIElS US5cbiIpOwoKT21pdCBwZXJpb2QgZnJvbSBtZXNzYWdlIGFuZCBtYXliZSBpbmNsdWRlIHRoZSBJ UlEgbnVtYmVyLgoKQWxsIHlvdXIgbWVzc2FnZXMgc2hvdWxkIHN0YXJ0IHdpdGggbG93ZXItY2Fz ZSBvciBhbGwgc2hvdWxkIHN0YXJ0CndpdGggdXBwZXItY2FzZSAodGhlIHR3byBpbiB0aGlzIGZ1 bmN0aW9uIGFyZSBjYXBpdGFsaXplZCwgYnV0IHRoZQpvdGhlcnMgYXJlIG5vdCkuCgo+ICsJCXJl dHVybiAgcmV0Owo+ICsJfQo+ICsKPiArCS8qIEVuYWJsZSBpbnRlcnJ1cHRzICovCj4gKwl2YWwg PSBQQUJfSU5UUF9JTlRYX01BU0sgfCBQQUJfSU5UUF9NU0kgfCBQQUJfSU5UUF9SRVNFVCB8Cj4g KwkgICAgICBQQUJfSU5UUF9QQ0lFX1VFIHwgUEFCX0lOVFBfSUVfUE1SRURJIHwgUEFCX0lOVFBf SUVfRUM7Cj4gKwljc3Jfd3JpdGVsKG12X3BjaSwgdmFsLCBQQUJfSU5UUF9BTUJBX01JU0NfRU5C KTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgbHNfcGNpZV9nNF9y ZXNldChzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gK3sKPiArCXN0cnVjdCBkZWxheWVkX3dv cmsgKmR3b3JrID0gY29udGFpbmVyX29mKHdvcmssIHN0cnVjdCBkZWxheWVkX3dvcmssCj4gKwkJ CQkJCSAgd29yayk7Cj4gKwlzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNpZSA9IGNvbnRhaW5lcl9vZihk d29yaywgc3RydWN0IGxzX3BjaWVfZzQsIGR3b3JrKTsKPiArCXN0cnVjdCBtb2JpdmVpbF9wY2ll ICptdl9wY2kgPSBwY2llLT5wY2k7Cj4gKwl1MTYgY3RybDsKPiArCj4gKwljdHJsID0gY3NyX3Jl YWR3KG12X3BjaSwgUENJX0JSSURHRV9DT05UUk9MKTsKPiArCWN0cmwgJj0gflBDSV9CUklER0Vf Q1RMX0JVU19SRVNFVDsKPiArCWNzcl93cml0ZXcobXZfcGNpLCBjdHJsLCBQQ0lfQlJJREdFX0NP TlRST0wpOwo+ICsJbHNfcGNpZV9nNF9yZWluaXRfaHcocGNpZSk7Cj4gK30KPiArCj4gK3N0YXRp YyBzdHJ1Y3QgbW9iaXZlaWxfcnBfb3BzIGxzX3BjaWVfZzRfcnBfb3BzID0gewo+ICsJLmludGVy cnVwdF9pbml0ID0gbHNfcGNpZV9nNF9pbnRlcnJ1cHRfaW5pdCwKPiArfTsKPiArCj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgbW9iaXZlaWxfcGFiX29wcyBsc19wY2llX2c0X3BhYl9vcHMgPSB7Cj4g KwkubGlua191cCA9IGxzX3BjaWVfZzRfbGlua191cCwKPiArfTsKPiArCj4gK3N0YXRpYyBpbnQg X19pbml0IGxzX3BjaWVfZzRfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAr ewo+ICsJc3RydWN0IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCXN0cnVjdCBtb2JpdmVp bF9wY2llICptdl9wY2k7Cj4gKwlzdHJ1Y3QgbHNfcGNpZV9nNCAqcGNpZTsKPiArCXN0cnVjdCBk ZXZpY2Vfbm9kZSAqbnAgPSBkZXYtPm9mX25vZGU7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCWlmICgh b2ZfcGFyc2VfcGhhbmRsZShucCwgIm1zaS1wYXJlbnQiLCAwKSkgewo+ICsJCWRldl9lcnIoZGV2 LCAiZmFpbGVkIHRvIGZpbmQgbXNpLXBhcmVudFxuIik7Cj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g Kwl9Cj4gKwo+ICsJcGNpZSA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqcGNpZSksIEdGUF9L RVJORUwpOwo+ICsJaWYgKCFwY2llKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCW12X3Bj aSA9IGRldm1fa3phbGxvYyhkZXYsIHNpemVvZigqbXZfcGNpKSwgR0ZQX0tFUk5FTCk7Cj4gKwlp ZiAoIW12X3BjaSkKPiArCQlyZXR1cm4gLUVOT01FTTsKPiArCj4gKwltdl9wY2ktPnBkZXYgPSBw ZGV2Owo+ICsJbXZfcGNpLT5vcHMgPSAmbHNfcGNpZV9nNF9wYWJfb3BzOwo+ICsJbXZfcGNpLT5y cC5vcHMgPSAmbHNfcGNpZV9nNF9ycF9vcHM7Cj4gKwlwY2llLT5wY2kgPSBtdl9wY2k7Cj4gKwo+ ICsJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgcGNpZSk7Cj4gKwo+ICsJSU5JVF9ERUxBWUVE X1dPUksoJnBjaWUtPmR3b3JrLCBsc19wY2llX2c0X3Jlc2V0KTsKPiArCj4gKwlyZXQgPSBtb2Jp dmVpbF9wY2llX2hvc3RfcHJvYmUobXZfcGNpKTsKPiArCWlmIChyZXQpIHsKPiArCQlkZXZfZXJy KGRldiwgImZhaWwgdG8gcHJvYmUhXG4iKTsKPiArCQlyZXR1cm4gIHJldDsKPiArCX0KPiArCj4g KwlpZiAoIWxzX3BjaWVfZzRfaXNfYnJpZGdlKHBjaWUpKQo+ICsJCXJldHVybiAtRU5PREVWOwo+ ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2Rldmlj ZV9pZCBsc19wY2llX2c0X29mX21hdGNoW10gPSB7Cj4gKwl7IC5jb21wYXRpYmxlID0gImZzbCxs eDIxNjBhLXBjaWUiLCB9LAo+ICsJeyB9LAo+ICt9Owo+ICsKPiArc3RhdGljIHN0cnVjdCBwbGF0 Zm9ybV9kcml2ZXIgbHNfcGNpZV9nNF9kcml2ZXIgPSB7Cj4gKwkuZHJpdmVyID0gewo+ICsJCS5u YW1lID0gImxheWVyc2NhcGUtcGNpZS1nZW40IiwKPiArCQkub2ZfbWF0Y2hfdGFibGUgPSBsc19w Y2llX2c0X29mX21hdGNoLAo+ICsJCS5zdXBwcmVzc19iaW5kX2F0dHJzID0gdHJ1ZSwKPiArCX0s Cj4gK307Cj4gKwo+ICtidWlsdGluX3BsYXRmb3JtX2RyaXZlcl9wcm9iZShsc19wY2llX2c0X2Ry aXZlciwgbHNfcGNpZV9nNF9wcm9iZSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2NvbnRy b2xsZXIvbW9iaXZlaWwvcGNpZS1tb2JpdmVpbC5oIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9t b2JpdmVpbC9wY2llLW1vYml2ZWlsLmgKPiBpbmRleCAwZjUzMDM5NjJlODguLjBjY2Q2Y2VlNWY4 ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL21vYml2ZWlsL3BjaWUtbW9i aXZlaWwuaAo+ICsrKyBiL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvbW9iaXZlaWwvcGNpZS1tb2Jp dmVpbC5oCj4gQEAgLTQxLDYgKzQxLDggQEAKPiAgI2RlZmluZSAgUEFHRV9MT19NQVNLCQkJMHgz ZmYKPiAgI2RlZmluZSAgUEFHRV9TRUxfT0ZGU0VUX1NISUZUCQkxMAo+ICAKPiArI2RlZmluZSBQ QUJfQUNUSVZJVFlfU1RBVAkJMHg4MWMKPiArCj4gICNkZWZpbmUgUEFCX0FYSV9QSU9fQ1RSTAkJ MHgwODQwCj4gICNkZWZpbmUgIEFQSU9fRU5fTUFTSwkJCTB4Zgo+ICAKPiBAQCAtNDksOCArNTEs MTggQEAKPiAgCj4gICNkZWZpbmUgUEFCX0lOVFBfQU1CQV9NSVNDX0VOQgkJMHgwYjBjCj4gICNk ZWZpbmUgUEFCX0lOVFBfQU1CQV9NSVNDX1NUQVQJCTB4MGIxYwo+IC0jZGVmaW5lICBQQUJfSU5U UF9JTlRYX01BU0sJCTB4MDFlMAo+IC0jZGVmaW5lICBQQUJfSU5UUF9NU0lfTUFTSwkJMHg4Cj4g KyNkZWZpbmUgIFBBQl9JTlRQX1JFU0VUCQkJKDB4MSA8PCAxKQo+ICsjZGVmaW5lICBQQUJfSU5U UF9NU0kJCQkoMHgxIDw8IDMpCj4gKyNkZWZpbmUgIFBBQl9JTlRQX0lOVEEJCQkoMHgxIDw8IDUp Cj4gKyNkZWZpbmUgIFBBQl9JTlRQX0lOVEIJCQkoMHgxIDw8IDYpCj4gKyNkZWZpbmUgIFBBQl9J TlRQX0lOVEMJCQkoMHgxIDw8IDcpCj4gKyNkZWZpbmUgIFBBQl9JTlRQX0lOVEQJCQkoMHgxIDw8 IDgpCj4gKyNkZWZpbmUgIFBBQl9JTlRQX1BDSUVfVUUJCSgweDEgPDwgOSkKPiArI2RlZmluZSAg UEFCX0lOVFBfSUVfUE1SRURJCQkoMHgxIDw8IDI5KQo+ICsjZGVmaW5lICBQQUJfSU5UUF9JRV9F QwkJCSgweDEgPDwgMzApCj4gKyNkZWZpbmUgIFBBQl9JTlRQX01TSV9NQVNLCQlQQUJfSU5UUF9N U0kKPiArI2RlZmluZSAgUEFCX0lOVFBfSU5UWF9NQVNLCQkoUEFCX0lOVFBfSU5UQSB8IFBBQl9J TlRQX0lOVEIgfFwKPiArCQkJCQlQQUJfSU5UUF9JTlRDIHwgUEFCX0lOVFBfSU5URCkKPiAgCj4g ICNkZWZpbmUgUEFCX0FYSV9BTUFQX0NUUkwod2luKQkJUEFCX1JFR19BRERSKDB4MGJhMCwgd2lu KQo+ICAjZGVmaW5lICBXSU5fRU5BQkxFX1NISUZUCQkwCj4gLS0gCj4gMi4xNy4xCj4gCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==