From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=4UPx=RO=vger.kernel.org=linux-block-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0B4BBC43381
	for <linux-block@archiver.kernel.org>; Mon, 11 Mar 2019 14:28:49 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id D6C1021741
	for <linux-block@archiver.kernel.org>; Mon, 11 Mar 2019 14:28:48 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727479AbfCKO2s (ORCPT <rfc822;linux-block@archiver.kernel.org>);
        Mon, 11 Mar 2019 10:28:48 -0400
Received: from verein.lst.de ([213.95.11.211]:41778 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727462AbfCKO2s (ORCPT <rfc822;linux-block@vger.kernel.org>);
        Mon, 11 Mar 2019 10:28:48 -0400
Received: by newverein.lst.de (Postfix, from userid 2407)
        id 37DF168C7B; Mon, 11 Mar 2019 15:28:42 +0100 (CET)
Date:   Mon, 11 Mar 2019 15:28:42 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Ming Lei <ming.lei@redhat.com>
Cc:     Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org,
        Omar Sandoval <osandov@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4/6] block: put the same page when adding it to bio
Message-ID: <20190311142842.GD7850@lst.de>
References: <20190309013737.27741-1-ming.lei@redhat.com> <20190309013737.27741-5-ming.lei@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190309013737.27741-5-ming.lei@redhat.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-block-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-block.vger.kernel.org>
X-Mailing-List: linux-block@vger.kernel.org

> +int __bio_add_pc_page(struct request_queue *q, struct bio *bio, struct page
> +		      *page, unsigned int len, unsigned int offset,
> +		      bool put_same_page)

Very odd indentation, we try to never have a linebreak between the type
and its parameter name.

> +static inline int bio_add_pc_page(struct request_queue *q, struct bio *bio, struct page
> +		    *page, unsigned int len, unsigned int offset)
> +{
> +	return __bio_add_pc_page(q, bio, page, len, offset, false);
> +}

Too long line.  Also please keep bio_add_pc_page in bio.c and export
it instead of the low-level helper.