Re: [PATCH] staging: rtl8712: Comparison to NULL.

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Mar 09, 2019 at 11:21:46PM +0530, Bhagyashri Dighole wrote:
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -160,7 +160,7 @@ void r8712_wep_encrypt(struct _adapter *padapter, u8 *pxmitframe)
>  	struct	security_priv *psecuritypriv = &padapter->securitypriv;
>  	struct	xmit_priv *pxmitpriv = &padapter->xmitpriv;
>  
> -	if (((struct xmit_frame *)pxmitframe)->buf_addr == NULL)
> +	if (((struct xmit_frame *)pxmitframe)->!buf_addr)
>  		return;
>  	pframe = ((struct xmit_frame *)pxmitframe)->buf_addr + TXDESC_OFFSET;
>  	/*start to encrypt each fragment*/

Does this change even build?

That's crazy, and shouldn't be valid C :(

You do this in a few places.  Shouldn't this be an coccinelle patch, so
you don't have to do it by hand and we trust the changes were done
properly?

thanks,

greg k-h