Re: [PATCH v5 2/2] staging: fbtft: ternary statement to if statement.

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Mar 09, 2019 at 09:11:45PM +0530, Bhagyashri Dighole wrote:
> Convert a ternary statement into a if statement which is detected while
> resolving "WARNING: line over 80 characters".
> 
> Signed-off-by: Bhagyashri Dighole <digholebhagyashri@gmail.com>
> ---
> Changes in v5:
>   - Make patch series.
> 
> Changes in v4:
>   - Convert a ternary statement into a if statement.
>   
> Changes in v3:
>   - Make the code in original form.
>   - Use tab to line up the code.
>   
> Changes in v2:
>   - Improve code order.
>   - Make the code more readable.
> 
>  drivers/staging/fbtft/fb_ssd1306.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fbtft/fb_ssd1306.c b/drivers/staging/fbtft/fb_ssd1306.c
> index d7c5e2e..3e1426c 100644
> --- a/drivers/staging/fbtft/fb_ssd1306.c
> +++ b/drivers/staging/fbtft/fb_ssd1306.c
> @@ -184,7 +184,10 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
>  		for (y = 0; y < yres / 8; y++) {
>  			*buf = 0x00;
>  			for (i = 0; i < 8; i++)
> -				*buf |= (vmem16[(y * 8 + i) * xres + x] ? 1 : 0) << i;
> +				if (vmem16[(y * 8 + i) * xres + x])
> +					*buf |= 1 << i;
> +				else
> +					*buf |= 0 << i;

Think about what this last line does.  Is it really needed?  :)

thanks,

greg k-h