From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v3 2/3] drm/i915/psr: Move logic to get TPS registers values to another function Date: Mon, 11 Mar 2019 16:28:02 -0700 Message-ID: <20190311232802.GD24277@intel.com> References: <20190305234734.19506-1-jose.souza@intel.com> <20190305234734.19506-2-jose.souza@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E374789BB2 for ; Mon, 11 Mar 2019 23:27:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190305234734.19506-2-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMDM6NDc6MzNQTSAtMDgwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBUaGlzIHdpbGwgbWFrZSBoc3dfYWN0aXZhdGVfcHNyMSgpIG1vcmUg ZWFzeSB0byByZWFkIGFuZCB3aWxsIG1ha2UKPiBmdXR1cmUgbW9kaWZpY2F0aW9uIHRvIFRQUyBy ZWdpc3RlcnMgbW9yZSBlYXN5IHRvIHJldmlldyBhbmQgcmVhZC4KPiAKPiBDYzogRGhpbmFrYXJh biBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1i eTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgNTYgKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDIzIGRl bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9w c3IuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4gaW5kZXggODMxZjM0NWI0 YWQ4Li4yZmEyZjRjOWM5MzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcHNyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IEBAIC00 MzcsMzIgKzQzNywxMyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9wc3JfZW5hYmxlX3Npbmsoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPiAgCWRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1 eCwgRFBfU0VUX1BPV0VSLCBEUF9TRVRfUE9XRVJfRDApOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9p ZCBoc3dfYWN0aXZhdGVfcHNyMShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICtzdGF0aWMg dTMyIHBzcjFfdHBzX3JlZ3NfdmFsX2dldChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7 Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19pOTE1KGludGVs X2RwKTsKPiAtCXUzMiBtYXhfc2xlZXBfdGltZSA9IDB4MWY7Cj4gLQl1MzIgdmFsID0gRURQX1BT Ul9FTkFCTEU7Cj4gLQo+IC0JLyogTGV0J3MgdXNlIDYgYXMgdGhlIG1pbmltdW0gdG8gY292ZXIg YWxsIGtub3duIGNhc2VzIGluY2x1ZGluZyB0aGUKPiAtCSAqIG9mZi1ieS1vbmUgaXNzdWUgdGhh dCBIVyBoYXMgaW4gc29tZSBjYXNlcy4KPiAtCSAqLwo+IC0JaW50IGlkbGVfZnJhbWVzID0gbWF4 KDYsIGRldl9wcml2LT52YnQucHNyLmlkbGVfZnJhbWVzKTsKPiAtCj4gLQkvKiBzaW5rX3N5bmNf bGF0ZW5jeSBvZiA4IG1lYW5zIHNvdXJjZSBoYXMgdG8gd2FpdCBmb3IgbW9yZSB0aGFuIDgKPiAt CSAqIGZyYW1lcywgd2UnbGwgZ28gd2l0aCA5IGZyYW1lcyBmb3Igbm93Cj4gLQkgKi8KPiAtCWlk bGVfZnJhbWVzID0gbWF4KGlkbGVfZnJhbWVzLCBkZXZfcHJpdi0+cHNyLnNpbmtfc3luY19sYXRl bmN5ICsgMSk7Cj4gLQl2YWwgfD0gaWRsZV9mcmFtZXMgPDwgRURQX1BTUl9JRExFX0ZSQU1FX1NI SUZUOwo+IC0KPiAtCXZhbCB8PSBtYXhfc2xlZXBfdGltZSA8PCBFRFBfUFNSX01BWF9TTEVFUF9U SU1FX1NISUZUOwo+IC0JaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpKQo+IC0JCXZhbCB8PSBFRFBf UFNSX01JTl9MSU5LX0VOVFJZX1RJTUVfOF9MSU5FUzsKPiAtCj4gLQlpZiAoZGV2X3ByaXYtPnBz ci5saW5rX3N0YW5kYnkpCj4gLQkJdmFsIHw9IEVEUF9QU1JfTElOS19TVEFOREJZOwo+ICsJdTMy IHZhbCA9IDA7Cj4gIAo+ICAJaWYgKGRldl9wcml2LT52YnQucHNyLnRwMV93YWtldXBfdGltZV91 cyA9PSAwKQo+IC0JCXZhbCB8PSAgRURQX1BTUl9UUDFfVElNRV8wdXM7Cj4gKwkJdmFsIHw9IEVE UF9QU1JfVFAxX1RJTUVfMHVzOwo+ICAJZWxzZSBpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAxX3dh a2V1cF90aW1lX3VzIDw9IDEwMCkKPiAgCQl2YWwgfD0gRURQX1BTUl9UUDFfVElNRV8xMDB1czsK PiAgCWVsc2UgaWYgKGRldl9wcml2LT52YnQucHNyLnRwMV93YWtldXBfdGltZV91cyA8PSA1MDAp Cj4gQEAgLTQ3MSw3ICs0NTIsNyBAQCBzdGF0aWMgdm9pZCBoc3dfYWN0aXZhdGVfcHNyMShzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMV9USU1FXzI1MDB1 czsKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAyX3RwM193YWtldXBfdGltZV91cyA9 PSAwKQo+IC0JCXZhbCB8PSAgRURQX1BTUl9UUDJfVFAzX1RJTUVfMHVzOwo+ICsJCXZhbCB8PSBF RFBfUFNSX1RQMl9UUDNfVElNRV8wdXM7Cj4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0LnBzci50 cDJfdHAzX3dha2V1cF90aW1lX3VzIDw9IDEwMCkKPiAgCQl2YWwgfD0gRURQX1BTUl9UUDJfVFAz X1RJTUVfMTAwdXM7Cj4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0LnBzci50cDJfdHAzX3dha2V1 cF90aW1lX3VzIDw9IDUwMCkKPiBAQCAtNDg1LDYgKzQ2NiwzNSBAQCBzdGF0aWMgdm9pZCBoc3df YWN0aXZhdGVfcHNyMShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJZWxzZQo+ICAJCXZh bCB8PSBFRFBfUFNSX1RQMV9UUDJfU0VMOwo+ICAKPiArCXJldHVybiB2YWw7Cj4gK30KPiArCj4g K3N0YXRpYyB2b2lkIGhzd19hY3RpdmF0ZV9wc3IxKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp Cj4gK3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRwX3RvX2k5MTUo aW50ZWxfZHApOwo+ICsJdTMyIG1heF9zbGVlcF90aW1lID0gMHgxZjsKPiArCXUzMiB2YWwgPSBF RFBfUFNSX0VOQUJMRTsKPiArCj4gKwkvKiBMZXQncyB1c2UgNiBhcyB0aGUgbWluaW11bSB0byBj b3ZlciBhbGwga25vd24gY2FzZXMgaW5jbHVkaW5nIHRoZQo+ICsJICogb2ZmLWJ5LW9uZSBpc3N1 ZSB0aGF0IEhXIGhhcyBpbiBzb21lIGNhc2VzLgo+ICsJICovCj4gKwlpbnQgaWRsZV9mcmFtZXMg PSBtYXgoNiwgZGV2X3ByaXYtPnZidC5wc3IuaWRsZV9mcmFtZXMpOwo+ICsKPiArCS8qIHNpbmtf c3luY19sYXRlbmN5IG9mIDggbWVhbnMgc291cmNlIGhhcyB0byB3YWl0IGZvciBtb3JlIHRoYW4g OAo+ICsJICogZnJhbWVzLCB3ZSdsbCBnbyB3aXRoIDkgZnJhbWVzIGZvciBub3cKPiArCSAqLwo+ ICsJaWRsZV9mcmFtZXMgPSBtYXgoaWRsZV9mcmFtZXMsIGRldl9wcml2LT5wc3Iuc2lua19zeW5j X2xhdGVuY3kgKyAxKTsKPiArCXZhbCB8PSBpZGxlX2ZyYW1lcyA8PCBFRFBfUFNSX0lETEVfRlJB TUVfU0hJRlQ7Cj4gKwo+ICsJdmFsIHw9IG1heF9zbGVlcF90aW1lIDw8IEVEUF9QU1JfTUFYX1NM RUVQX1RJTUVfU0hJRlQ7Cj4gKwlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpCj4gKwkJdmFsIHw9 IEVEUF9QU1JfTUlOX0xJTktfRU5UUllfVElNRV84X0xJTkVTOwo+ICsKPiArCWlmIChkZXZfcHJp di0+cHNyLmxpbmtfc3RhbmRieSkKPiArCQl2YWwgfD0gRURQX1BTUl9MSU5LX1NUQU5EQlk7Cj4g Kwo+ICsJdmFsIHw9IHBzcjFfdHBzX3JlZ3NfdmFsX2dldChpbnRlbF9kcCk7CgpJJ2QgcHJlZmVy IGludGVsX3BzcjFfdHBzLi4uCgpSZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZp dmlAaW50ZWwuY29tPgoKPiArCj4gIAlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA4KQo+ICAJ CXZhbCB8PSBFRFBfUFNSX0NSQ19FTkFCTEU7Cj4gIAo+IC0tIAo+IDIuMjEuMAo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=