All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: Wentao Cai <etsai042@gmail.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
	Chris Brannon <chris@the-brannons.com>,
	Kirk Reiser <kirk@reisers.ca>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Staging: speakup: Change else-if block order
Date: Tue, 12 Mar 2019 10:54:57 +0100	[thread overview]
Message-ID: <20190312095457.6r4f76c35ah7znxp@function> (raw)
In-Reply-To: <20190312091512.2315-1-etsai042@gmail.com>

Wentao Cai, le mar. 12 mars 2019 02:15:12 -0700, a ecrit:
> Change else-if block to silence checkpatch.pl warning:
> WARNING: else is not generally useful after a break or return

This looks like a false positive of checkpatch.pl, I don't see the point
of moving this else if block.

Samuel


  reply	other threads:[~2019-03-12  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12  9:15 [PATCH] Staging: speakup: Change else-if block order Wentao Cai
2019-03-12  9:54 ` Samuel Thibault [this message]
2019-03-12 10:16 ` [Outreachy kernel] " Julia Lawall
2019-03-12 14:30   ` etsai042
2019-03-12 14:38     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312095457.6r4f76c35ah7znxp@function \
    --to=samuel.thibault@ens-lyon.org \
    --cc=chris@the-brannons.com \
    --cc=etsai042@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kirk@reisers.ca \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.