From: Baoquan He <bhe@redhat.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
kirill.shutemov@linux.intel.com, mingo@kernel.org, bp@alien8.de,
hpa@zytor.com, dyoung@redhat.com, x86@kernel.org
Subject: Re: [PATCH v2 3/3] x86/kdump/64: Change the upper limit of crashkernel reservation
Date: Tue, 12 Mar 2019 18:12:48 +0800 [thread overview]
Message-ID: <20190312101248.GM21116@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20190312094838.f4agowhd5rlaa3hn@kshutemo-mobl1>
On 03/12/19 at 12:48pm, Kirill A. Shutemov wrote:
> > #ifdef CONFIG_X86_32
> > # define CRASH_ADDR_LOW_MAX (512 << 20)
> > # define CRASH_ADDR_HIGH_MAX (512 << 20)
> > #else
> > # define CRASH_ADDR_LOW_MAX (896UL << 20)
> > -# define CRASH_ADDR_HIGH_MAX MAXMEM
> > +# define CRASH_ADDR_HIGH_MAX (1ULL < 46)
>
> Maybe
>
> # define CRASH_ADDR_HIGH_MAX (64UL << 40)
>
> to match the notation for the rest of defines?
>
Sure, I will replace it, and repost a whole patchset with your ack added
on each patch. Thanks for your careful reviewing and great suggestions.
>
> Otherwise the patchset look good to me. You can use my ack for all of
> them:
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> > #endif
> >
> > static int __init reserve_crashkernel_low(void)
> > --
> > 2.17.2
> >
>
> --
> Kirill A. Shutemov
prev parent reply other threads:[~2019-03-12 10:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 0:50 [PATCH v2 0/3] Add restrictions for kexec/kdump jumping between 5-level and 4-level kernel Baoquan He
2019-03-12 0:50 ` [PATCH v2 1/3] x86/boot: Add xloadflags bits for 5-level kernel checking Baoquan He
2019-03-12 0:50 ` [PATCH v2 2/3] x86/kexec/64: Error out if try to jump to old 4-level kernel from 5-level kernel Baoquan He
2019-03-12 0:50 ` [PATCH v2 3/3] x86/kdump/64: Change the upper limit of crashkernel reservation Baoquan He
2019-03-12 9:48 ` Kirill A. Shutemov
2019-03-12 10:12 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312101248.GM21116@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.