From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY From: Rob Herring Message-Id: <20190312134525.GA9706@bogus> Date: Tue, 12 Mar 2019 08:45:25 -0500 To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Mark Rutland , Binghui Wang List-ID: T24gU2F0LCBNYXIgMDIsIDIwMTkgYXQgMDU6MDQ6NTRQTSArMDgwMCwgWXUgQ2hlbiB3cm90ZToK PiBUaGlzIHBhdGNoIGFkZHMgYmluZGluZyBkb2N1bWVudGF0aW9uIGZvciBzdXBwb3J0aW5nIHRo ZSBoaTM2NjAgdXNiCj4gcGh5IG9uIGJvYXJkcyBsaWtlIHRoZSBIaUtleTk2MC4KPiAKPiBDYzog Um9iIEhlcnJpbmcgPHJvYmgrZHRAa2VybmVsLm9yZz4KPiBDYzogTWFyayBSdXRsYW5kIDxtYXJr LnJ1dGxhbmRAYXJtLmNvbT4KPiBDYzogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5v cmc+Cj4gQ2M6IEJpbmdodWkgV2FuZyA8d2FuZ2JpbmdodWlAaGlzaWxpY29uLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBZdSBDaGVuIDxjaGVueXU1NkBodWF3ZWkuY29tPgo+IC0tLQo+IHYxOgo+ICog Rml4IHNvbWUgZm9ybWF0IGVycm9yIGFzIHN1Z2dlc3RlZCBieSBSb2IuCj4gdjI6Cj4gKiBDaGFu Z2UgaGkzNjYwIHVzYiBQSFkgdG8gaGkzNjYwIFVTQiBQSFkKPiB2MzoKPiAqIE1ha2UgZGV2aWNl IG5vZGUgYSBzdWJub2RlIG9mIHVzYjNfb3RnX2JjIHJlZ2lzdGVyLgo+IC0tLQo+IC0tLQo+ICAu Li4vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcGh5LWhpMzY2MC11c2IzLnR4dCAgICB8IDI4ICsr KysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKykK PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w aHkvcGh5LWhpMzY2MC11c2IzLnR4dAo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvcGh5L3BoeS1oaTM2NjAtdXNiMy50eHQgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3BoeS1oaTM2NjAtdXNiMy50eHQKPiBuZXcgZmlsZSBt b2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMC4uNjA5NjIxNGEyYmM2Cj4gLS0tIC9kZXYv bnVsbAo+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcGh5LWhp MzY2MC11c2IzLnR4dAo+IEBAIC0wLDAgKzEsMjggQEAKPiArSGlzaWxpY29uIGhpMzY2MCBVU0Ig UEhZCj4gKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gKwo+ICtSZXF1aXJlZCBwcm9wZXJ0aWVz Ogo+ICstIGNvbXBhdGlibGU6IHNob3VsZCBiZSAiaGlzaWxpY29uLGhpMzY2MC11c2ItcGh5Igo+ ICstICNwaHktY2VsbHM6IG11c3QgYmUgMAo+ICstIGhpc2lsaWNvbixwZXJpY3JnLXN5c2Nvbjog cGhhbmRsZSBvZiBzeXNjb24gdXNlZCB0byBjb250cm9sIHBoeS4KPiArLSBoaXNpbGljb24scGN0 cmwtc3lzY29uOiBwaGFuZGxlIG9mIHN5c2NvbiB1c2VkIHRvIGNvbnRyb2wgcGh5Lgo+ICstIGhp c2lsaWNvbix1c2IzLW90Zy1iYy1zeXNjb246IHBoYW5kbGUgb2Ygc3lzY29uIHVzZWQgdG8gY29u dHJvbCBwaHkuCgpZb3UgY2FuIGRyb3AgdGhpcyBhcyBpdCBpcyBub3cganVzdCB0aGUgcGFyZW50 IG5vZGUuCgo+ICstIGhpc2lsaWNvbixleWUtZGlhZ3JhbS1wYXJhbTogcGFyYW1ldGVyIHNldCBm b3IgcGh5Cj4gK1JlZmVyIHRvIHBoeS9waHktYmluZGluZ3MudHh0IGZvciB0aGUgZ2VuZXJpYyBQ SFkgYmluZGluZyBwcm9wZXJ0aWVzCj4gKwo+ICtUaGlzIGlzIGEgc3Vibm9kZSBvZiB1c2IzX290 Z19iYyByZWdpc3RlciBub2RlLgo+ICsKPiArRXhhbXBsZToKPiArCXVzYjNfb3RnX2JjOiB1c2Iz X290Z19iY0BmZjIwMDAwMCB7Cj4gKwkJY29tcGF0aWJsZSA9ICJzeXNjb24iLCAic2ltcGxlLW1m ZCI7CgpUaGlzIG5vZGUgc2hvdWxkIGhhdmUgYSBzcGVjaWZpYyBjb21wYXRpYmxlLgoKPiArCQly ZWcgPSA8MHgwIDB4ZmYyMDAwMDAgMHgwIDB4MTAwMD47Cj4gKwo+ICsJCXVzYi1waHkgewo+ICsJ CQljb21wYXRpYmxlID0gImhpc2lsaWNvbixoaTM2NjAtdXNiLXBoeSI7Cj4gKwkJCSNwaHktY2Vs bHMgPSA8MD47Cj4gKwkJCWhpc2lsaWNvbixwZXJpY3JnLXN5c2NvbiA9IDwmY3JnX2N0cmw+Owo+ ICsJCQloaXNpbGljb24scGN0cmwtc3lzY29uID0gPCZwY3RybD47Cj4gKwkJCWhpc2lsaWNvbix1 c2IzLW90Zy1iYy1zeXNjb24gPSA8JnVzYjNfb3RnX2JjPjsKPiArCQkJaGlzaWxpY29uLGV5ZS1k aWFncmFtLXBhcmFtID0gPDB4MjI0NjZlND47Cj4gKwkJfTsKPiArCX07Cj4gLS0gCj4gMi4xNS4w LXJjMgo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Date: Tue, 12 Mar 2019 08:45:25 -0500 Message-ID: <20190312134525.GA9706@bogus> References: <20190302090505.65542-1-chenyu56@huawei.com> <20190302090505.65542-2-chenyu56@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190302090505.65542-2-chenyu56@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu Chen Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, john.stultz@linaro.org, suzhuangluan@hisilicon.com, kongfei@hisilicon.com, liuyu712@hisilicon.com, wanghu17@hisilicon.com, butao@hisilicon.com, chenyao11@huawei.com, fangshengzhou@hisilicon.com, lipengcheng8@huawei.com, songxiaowei@hisilicon.com, xuyiping@hisilicon.com, xuyoujun4@huawei.com, yudongbin@hisilicon.com, zangleigang@hisilicon.com, Mark Rutland , Binghui Wang List-Id: devicetree@vger.kernel.org On Sat, Mar 02, 2019 at 05:04:54PM +0800, Yu Chen wrote: > This patch adds binding documentation for supporting the hi3660 usb > phy on boards like the HiKey960. > > Cc: Rob Herring > Cc: Mark Rutland > Cc: John Stultz > Cc: Binghui Wang > Signed-off-by: Yu Chen > --- > v1: > * Fix some format error as suggested by Rob. > v2: > * Change hi3660 usb PHY to hi3660 USB PHY > v3: > * Make device node a subnode of usb3_otg_bc register. > --- > --- > .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 28 ++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > > diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > new file mode 100644 > index 000000000000..6096214a2bc6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt > @@ -0,0 +1,28 @@ > +Hisilicon hi3660 USB PHY > +----------------------- > + > +Required properties: > +- compatible: should be "hisilicon,hi3660-usb-phy" > +- #phy-cells: must be 0 > +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. > +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. > +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. You can drop this as it is now just the parent node. > +- hisilicon,eye-diagram-param: parameter set for phy > +Refer to phy/phy-bindings.txt for the generic PHY binding properties > + > +This is a subnode of usb3_otg_bc register node. > + > +Example: > + usb3_otg_bc: usb3_otg_bc@ff200000 { > + compatible = "syscon", "simple-mfd"; This node should have a specific compatible. > + reg = <0x0 0xff200000 0x0 0x1000>; > + > + usb-phy { > + compatible = "hisilicon,hi3660-usb-phy"; > + #phy-cells = <0>; > + hisilicon,pericrg-syscon = <&crg_ctrl>; > + hisilicon,pctrl-syscon = <&pctrl>; > + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; > + hisilicon,eye-diagram-param = <0x22466e4>; > + }; > + }; > -- > 2.15.0-rc2 >