From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4084C10F00 for ; Tue, 12 Mar 2019 17:44:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A47EE214AE for ; Tue, 12 Mar 2019 17:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552412680; bh=R0HY1DxLZW5S8d5YDtBikJvfw3XUMWp1gPHpMHfmeXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GTukfLZ8dOB0pPzSRVHS4VkgDUb459cE2qkCQAY0YtkALMRlaItNxuXsHYkPRR1LR HDPJFF4GjViMC5HZRNQXBkMaQY3V9IkEH6RnXXaTwn5f6KEmM26vFMqVU0gKSPO0Gr 7IbzQxFizEi7xqeRtC+lMv3I+KbEcVjxhwBTSgeU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729409AbfCLRoj (ORCPT ); Tue, 12 Mar 2019 13:44:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:56506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728821AbfCLRPj (ORCPT ); Tue, 12 Mar 2019 13:15:39 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4C17D217D4; Tue, 12 Mar 2019 17:15:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552410938; bh=R0HY1DxLZW5S8d5YDtBikJvfw3XUMWp1gPHpMHfmeXs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2Ai9sBBQpN8x6HB+j/pYEcdUKc1IXbzcWiuxcZ5RvvGMycK3T+MsXTwP1bNkwkm/f HS8AVXWGhU1ie0qRi3dkjvqLUCg7pzVjU6lPz8Zo+hSSXayZcMNAl5OkXOTAcIJbVu NKkNgw9Q334mmysjFdZoN2mHb6zxs0+9B54zaky8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Chan , "David S. Miller" Subject: [PATCH 4.14 014/135] bnxt_en: Drop oversize TX packets to prevent errors. Date: Tue, 12 Mar 2019 10:07:41 -0700 Message-Id: <20190312170342.431157891@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190312170341.127810985@linuxfoundation.org> References: <20190312170341.127810985@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Michael Chan [ Upstream commit 2b3c6885386020b1b9d92d45e8349637e27d1f66 ] There have been reports of oversize UDP packets being sent to the driver to be transmitted, causing error conditions. The issue is likely caused by the dst of the SKB switching between 'lo' with 64K MTU and the hardware device with a smaller MTU. Patches are being proposed by Mahesh Bandewar to fix the issue. In the meantime, add a quick length check in the driver to prevent the error. The driver uses the TX packet size as index to look up an array to setup the TX BD. The array is large enough to support all MTU sizes supported by the driver. The oversize TX packet causes the driver to index beyond the array and put garbage values into the TX BD. Add a simple check to prevent this. Signed-off-by: Michael Chan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -447,6 +447,12 @@ normal_tx: } length >>= 9; + if (unlikely(length >= ARRAY_SIZE(bnxt_lhint_arr))) { + dev_warn_ratelimited(&pdev->dev, "Dropped oversize %d bytes TX packet.\n", + skb->len); + i = 0; + goto tx_dma_error; + } flags |= bnxt_lhint_arr[length]; txbd->tx_bd_len_flags_type = cpu_to_le32(flags);