All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shadaab G <shadaab2202@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] Staging: vt6655: Update TODO & checkpatch.pl check
Date: Tue, 12 Mar 2019 12:16:02 -0700	[thread overview]
Message-ID: <20190312191602.GA18223@kroah.com> (raw)
In-Reply-To: <20190312190832.GA3330@sreyansh>

On Wed, Mar 13, 2019 at 12:38:32AM +0530, Shadaab G wrote:
> This updates TODO where task of killing ttype.h is done but
> not updated. It also fixes the following checkpatch.pl check:
> 
> CHECK: spaces preferred around that '-'
> 
> Signed-off-by: Shadaab G <shadaab2202@gmail.com>

We need a "full" name for the signed-off-by line.  Do you sign documents
with just "G" as your name?

> ---
>  drivers/staging/vt6655/TODO   |  2 +-
>  drivers/staging/vt6655/rxtx.c | 48 +++++++++++++++++++++----------------------
>  2 files changed, 25 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/TODO b/drivers/staging/vt6655/TODO
> index 63607ef..462cbdd 100644
> --- a/drivers/staging/vt6655/TODO
> +++ b/drivers/staging/vt6655/TODO
> @@ -7,7 +7,7 @@ TODO:
>    - remove dead code
>    - abstract VT3253 chipset specific code
>  - add common vt665x infrastructure
> -- kill ttype.h
> +- kill ttype.h -- done


Why is this change part of the coding style change?

Shouldn't this be multiple patches?

thanks,

greg k-h


      reply	other threads:[~2019-03-12 19:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 19:08 [PATCH] Staging: vt6655: Update TODO & checkpatch.pl check Shadaab G
2019-03-12 19:16 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312191602.GA18223@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=shadaab2202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.