From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd. Date: Tue, 12 Mar 2019 14:28:03 -0500 Message-ID: <20190312192803.GA19594@bogus> References: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Muellner Cc: mark.rutland@arm.com, heiko@sntech.de, shawn.lin@rock-chips.com, ulf.hansson@linaro.org, adrian.hunter@intel.com, Philipp Tomsich , Michal Simek , Douglas Anderson , Viresh Kumar , Enric Balletbo i Serra , Vicente Bergas , Emil Renner Berthing , Randy Li , Tony Xie , Ezequiel Garcia , Klaus Goger , Lin Huang , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.or List-Id: linux-mmc@vger.kernel.org On Thu, Mar 07, 2019 at 09:43:27AM +0100, Christoph Muellner wrote: > This patch documents the new property disable-cqe-dcmd > for the Arasan eMMC 5.1 driver. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 1edbb049cccb..ec699bf98b7c 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -44,6 +44,10 @@ Optional Properties: > properly. Test mode can be used to force the controller to function. > - xlnx,int-clock-stable-broken: when present, the controller always reports > that the internal clock is stable even when it is not. > + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs) > + as part of the command queue engine (CQE). On controllers with a CQHCI, > + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs. > + This is done unless disable-cqe-dcmd is specified. Should be common either for all controllers or all SDHCI controllers? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC60C43381 for ; Tue, 12 Mar 2019 19:28:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BB85214AF for ; Tue, 12 Mar 2019 19:28:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="U7h47VuS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BB85214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9kIF1l0rjDCrmdF/DRlbNI8nI1SAmDOzUvNSVxhqRf0=; b=U7h47VuSlFUWWc pKyUle3vNfy1aUvukXiXzjKrFpFPY5ssxOt1KW09VkODAWGV0Mf9Tjl7sz82pWzA7ToCKylTE1/1F a+DJuvjF716gx6cXOYVoL315oH7hZi1zNDU31MgCdWNnTxwuNmlLvb8E/JoJ0p8lVG3ToywAaPjTc nDDlZ+Y8T8HghDBN92fnpJ2opSq8qo90UVLru8Z7D6dLh/OR+HOUVRM54ya/mnpIvkIHRAUrHwUSy 2EJvH2Fdv229zJNg+X4MKApWxSEE/RyAxPEbBQHiZJy+q+KvrlJouekA07XkIPvEz0vfXZ/4Z/z8X tY86+snL3kVgzvY6UHMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3n4L-00049u-W0; Tue, 12 Mar 2019 19:28:09 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3n4I-00049A-GU; Tue, 12 Mar 2019 19:28:07 +0000 Received: by mail-ot1-f65.google.com with SMTP id r19so3610965otn.1; Tue, 12 Mar 2019 12:28:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F9V4OMns3P/x6VFCcXVv5gZlRufgHPxnhWpwUoF+RYA=; b=nhRiuuRsLQu9mLDGIZZO+5NNG3tOGtH9GVy0oA2duD+mf1a7Qz8nlDBEVrfUUEW6t3 d3JOMNGc27lU4TLBU6N57W1/28kC7AAmFeoA0ekO+MfjdDzc0wRoQmiD3E4rTjR1wdtu EA806VsIQ0KYOryJQrXhsD20og+y2T4YiEMMAVQIwkuyrOeBvXuq/y/MtreUvvwK4ILf cbtK4PA2HisFD9a8O4c4yqSHd5w/r3YwcwkobxxSxHLwDQAQ7ytPW2YxuovGqWFlfHYf Ufk9GOEp+qKGAIBm5Eoc9nEa2rvBZXcOxs0Kyj86QTN0dZd3YdwBf+rKUOVzSHLbB71u P3yw== X-Gm-Message-State: APjAAAVeJfPVWc2vrera/TBEGm4dt4Ch7wdpshNFFlISmEnuovVUWc0h KraUd5wQb5kaC3E7BHgErg== X-Google-Smtp-Source: APXvYqzH6Uri43SuIyZUbzXYlN+lRz113WPkbkp/5scL1ASoY1HJHpFDWBw6NXcRf0mE40ZHyDhwBg== X-Received: by 2002:a9d:3b23:: with SMTP id z32mr26521169otb.138.1552418885252; Tue, 12 Mar 2019 12:28:05 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 60sm4006727otw.50.2019.03.12.12.28.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 12:28:04 -0700 (PDT) Date: Tue, 12 Mar 2019 14:28:03 -0500 From: Rob Herring To: Christoph Muellner Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd. Message-ID: <20190312192803.GA19594@bogus> References: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_122806_543551_CB2415A2 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, ulf.hansson@linaro.org, heiko@sntech.de, Viresh Kumar , shawn.lin@rock-chips.com, adrian.hunter@intel.com, Tony Xie , Klaus Goger , Philipp Tomsich , Emil Renner Berthing , Michal Simek , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Randy Li , Vicente Bergas , Ezequiel Garcia , linux-arm-kernel@lists.infradead.org, Lin Huang , linux-mmc@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, Enric Balletbo i Serra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 07, 2019 at 09:43:27AM +0100, Christoph Muellner wrote: > This patch documents the new property disable-cqe-dcmd > for the Arasan eMMC 5.1 driver. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 1edbb049cccb..ec699bf98b7c 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -44,6 +44,10 @@ Optional Properties: > properly. Test mode can be used to force the controller to function. > - xlnx,int-clock-stable-broken: when present, the controller always reports > that the internal clock is stable even when it is not. > + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs) > + as part of the command queue engine (CQE). On controllers with a CQHCI, > + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs. > + This is done unless disable-cqe-dcmd is specified. Should be common either for all controllers or all SDHCI controllers? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BAEC43381 for ; Tue, 12 Mar 2019 19:28:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 110AF2147C for ; Tue, 12 Mar 2019 19:28:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552418888; bh=Bkl93QxxNDbczulPqjkUf0h0Jvb3AJS89aJOBN/aXN8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=bsZrSgsGY2+2lu8nVA3um/6v2vBRzqqlXCn2N4BqNNsx3ecUrkePPMNhOXHc4YDtP 5KJmyUT3L1LmAEuNtNzgO+zPq31ibO2lnQgcYwvPogFuhGzssOJ7Yq+ZEiaCLN34Cl n4Xl8Efvm/D8Pf7YL3enD0yLMKfp9LWrdS8v9fd0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727302AbfCLT2H (ORCPT ); Tue, 12 Mar 2019 15:28:07 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:36951 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726883AbfCLT2G (ORCPT ); Tue, 12 Mar 2019 15:28:06 -0400 Received: by mail-ot1-f67.google.com with SMTP id b3so3590753otp.4; Tue, 12 Mar 2019 12:28:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F9V4OMns3P/x6VFCcXVv5gZlRufgHPxnhWpwUoF+RYA=; b=HPigVKjB+T0qClY3+Cwhs8bqZBkcoSl5j7G1I8VVX5MPgzkb8aeUpSW0z2LQIRYeLB d5x4Kg2/WyOCKD4qK9SqUwDgQ/GpH8eu2SE0bomEBRmVG8RsiJ9DcwEcAsj/FwhAmqdk m34AVNE/f+uoGUvQKUZd884cGDuySdh+K+PEXY4hImsTWmuzZDqfN0rlUMcvoMtw4Lcb ryjepIGwtAkUon4xjJ/GTeLMxKunEU1pgnKOd9o+vniz72M7B3A632zMb4jpl5i+y2lP bezl/r+31WTcLN5vHUFNi5ocuGj/6H2X2wH3mqDTWGx5vQAIDMgvPAps+qD6Vy7tmAiD SVuw== X-Gm-Message-State: APjAAAXpqKRlI9S8MWiGu33F6fZxQ4rKLNMdA081Ybgwo/z4bmilAayH KS2ikoU+s+cRX3q9maUZJQ== X-Google-Smtp-Source: APXvYqzH6Uri43SuIyZUbzXYlN+lRz113WPkbkp/5scL1ASoY1HJHpFDWBw6NXcRf0mE40ZHyDhwBg== X-Received: by 2002:a9d:3b23:: with SMTP id z32mr26521169otb.138.1552418885252; Tue, 12 Mar 2019 12:28:05 -0700 (PDT) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 60sm4006727otw.50.2019.03.12.12.28.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 12:28:04 -0700 (PDT) Date: Tue, 12 Mar 2019 14:28:03 -0500 From: Rob Herring To: Christoph Muellner Cc: mark.rutland@arm.com, heiko@sntech.de, shawn.lin@rock-chips.com, ulf.hansson@linaro.org, adrian.hunter@intel.com, Philipp Tomsich , Michal Simek , Douglas Anderson , Viresh Kumar , Enric Balletbo i Serra , Vicente Bergas , Emil Renner Berthing , Randy Li , Tony Xie , Ezequiel Garcia , Klaus Goger , Lin Huang , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 2/3] dt-bindings: mmc: Add a new property disable-cqe-dcmd. Message-ID: <20190312192803.GA19594@bogus> References: <20190307084329.25416-1-christoph.muellner@theobroma-systems.com> <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190307084329.25416-2-christoph.muellner@theobroma-systems.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 07, 2019 at 09:43:27AM +0100, Christoph Muellner wrote: > This patch documents the new property disable-cqe-dcmd > for the Arasan eMMC 5.1 driver. > > Signed-off-by: Christoph Muellner > Signed-off-by: Philipp Tomsich > --- > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 1edbb049cccb..ec699bf98b7c 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -44,6 +44,10 @@ Optional Properties: > properly. Test mode can be used to force the controller to function. > - xlnx,int-clock-stable-broken: when present, the controller always reports > that the internal clock is stable even when it is not. > + - disable-cqe-dcmd: The eMMC 5.1 standard specifies direct commands (DCMDs) > + as part of the command queue engine (CQE). On controllers with a CQHCI, > + such as the Arasan eMMC 5.1 host controller, the driver has to enable DCMDs. > + This is done unless disable-cqe-dcmd is specified. Should be common either for all controllers or all SDHCI controllers?