From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF361C43381 for ; Tue, 12 Mar 2019 20:28:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97C9C2087C for ; Tue, 12 Mar 2019 20:28:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FI8y+TCf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbfCLU2r (ORCPT ); Tue, 12 Mar 2019 16:28:47 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:44501 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726422AbfCLU2q (ORCPT ); Tue, 12 Mar 2019 16:28:46 -0400 Received: by mail-pg1-f193.google.com with SMTP id h34so2661278pgh.11 for ; Tue, 12 Mar 2019 13:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=c/YMeFjg2C1rsC7LYVaJ3lSUN0c5MB43qB2XYh78NwQ=; b=FI8y+TCfeJZe3w03ikXWBGAQ8FRQGaWO+1HoLTBjVgfvgP+7z4ZdLIGo+7SXHt4tS9 CbMZUcFFNZZCf3+jiwYKnxHHFlSDxkJ4AxGAo47nm4b+PparFparYyBcKn3ZHNFL0v3q N50TGMWeHssmt1Silp4cJzPQH8wnZigDkMc6w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=c/YMeFjg2C1rsC7LYVaJ3lSUN0c5MB43qB2XYh78NwQ=; b=IXSS/u9kPPug5dAl2Qkbbrkxt1Yeur1ZfWJD5VMFMViU6VyRZy0rYMq/in7aAJY4U2 DubKdcAmw8BaHCDcrMXCdigfS3hn2oGrANnopME4HXmIhtcERzZiJiucurbVhZeWlPJa qm/9QLV1CKk1H5lwNTzZrRs1xPR7bVFVTwp1DTGHKejj4fiMKmDbVGS+heBqLIOjZLc6 TYow/3J2Fwo1fLv+HORPqDmOAafpPNhr/FaWFJz6ch/G5vGU3aIy6JpQdo/3IhB9i9lJ zWG1L/ysDW9651Vd03FCjZ0P44q2FMcV3R+jS+0ZFOPm5H7pq3+jkAJIz587gS/glrrx wY8w== X-Gm-Message-State: APjAAAXCI0CNR1jXYD8ClYo8KF+aBUb7zkYQ3g5ObFOzDOSoP818Ejls 2sP1yz2yqWPUQbm92zE9zzgyUYvpZgo= X-Google-Smtp-Source: APXvYqxNeUe+sIYUKDnnCbjfDVhZiBj8bB9ajlUkuyeRIpjosbKz8fn2tYHb4NDwfv3lJ7Q3USKiBw== X-Received: by 2002:a63:5702:: with SMTP id l2mr37160439pgb.2.1552422524955; Tue, 12 Mar 2019 13:28:44 -0700 (PDT) Received: from google.com ([2620:15c:202:201:49ea:b78f:4f04:4d25]) by smtp.googlemail.com with ESMTPSA id i79sm17651040pfj.28.2019.03.12.13.28.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 13:28:44 -0700 (PDT) Date: Tue, 12 Mar 2019 13:28:40 -0700 From: Zubin Mithra To: stable@vger.kernel.org Cc: groeck@chromium.org, gregkh@linuxfoundation.org, chamaken@gmail.com, pablo@netfilter.org, kadlec@blackhole.kfki.hu, fw@strlen.de, davem@davemloft.net Subject: eb075954e9fd ("netfilter: nfnetlink_log: just returns error for unknown command") Message-ID: <20190312202838.GA107600@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hello, Syzkaller has triggered a GPF when fuzzing a 4.4 kernel with the following stacktrace. Call Trace: [] lock_acquire+0x155/0x450 kernel/locking/lockdep.c:3592 [] __raw_spin_lock_bh include/linux/spinlock_api_smp.h:137 [inline] [] _raw_spin_lock_bh+0x3f/0x50 kernel/locking/spinlock.c:175 [] spin_lock_bh include/linux/spinlock.h:307 [inline] [] nfulnl_set_mode net/netfilter/nfnetlink_log.c:250 [inline] [] nfulnl_recv_config+0x612/0x1440 net/netfilter/nfnetlink_log.c:909 [] nfnetlink_rcv_msg+0xa59/0xbc0 net/netfilter/nfnetlink.c:215 [] netlink_rcv_skb+0x149/0x380 net/netlink/af_netlink.c:2349 [] nfnetlink_rcv+0x2ac/0x1190 net/netfilter/nfnetlink.c:479 [] netlink_unicast_kernel net/netlink/af_netlink.c:1267 [inline] [] netlink_unicast+0x51e/0x760 net/netlink/af_netlink.c:1293 [] netlink_sendmsg+0x8c5/0xc20 net/netlink/af_netlink.c:1847 [] sock_sendmsg_nosec net/socket.c:625 [inline] [] sock_sendmsg+0xcf/0x110 net/socket.c:635 [] ___sys_sendmsg+0x733/0x840 net/socket.c:1962 [] __sys_sendmsg+0xd0/0x180 net/socket.c:1996 [] SYSC_sendmsg net/socket.c:2007 [inline] [] SyS_sendmsg+0x32/0x50 net/socket.c:2003 [] entry_SYSCALL_64_fastpath+0x18/0x94 Code: c7 44 18 10 00 00 00 00 48 8d 65 d8 44 89 c0 5b 41 5c 41 5d 41 5e 41 5f 5d c3 4c 89 f2 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 c6 36 00 00 49 81 3e 20 ea 88 83 41 ba 00 00 RIP [] __lock_acquire+0x5bd/0x4eb0 kernel/locking/lockdep.c:3092 Could the following patch be applied to v4.4.y? This patch is present in v4.9.y. * eb075954e9fd ("netfilter: nfnetlink_log: just returns error for unknown command") Tests run: * Chrome OS tryjobs * Syzkaller reproducer Thanks, - Zubin