From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92549C43381 for ; Tue, 12 Mar 2019 22:01:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E8CD2173C for ; Tue, 12 Mar 2019 22:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552428064; bh=mzqJdzs7aPWWo7/bSoKNz+UZfdtrDaPFc2zFxpmIM/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=qtuluEbCJBkH6V6axAqU+dxh+XVW+LO5M+0M6kJ1PuIUgiXEmY76NqdzPU6KRheSY mewHPCfkIygF5sVCUTyCGlr8f9IFhXklxVwkEb10x33u0ZJBni+e4fESty32KDJpJe hkgrKK1O7Uxg2S+saTxPbMTRlG4hf2mO1/Go55/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726396AbfCLWBE (ORCPT ); Tue, 12 Mar 2019 18:01:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:57056 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726388AbfCLWBD (ORCPT ); Tue, 12 Mar 2019 18:01:03 -0400 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D467214AE; Tue, 12 Mar 2019 22:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552428063; bh=mzqJdzs7aPWWo7/bSoKNz+UZfdtrDaPFc2zFxpmIM/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=10rpadjO3U0nScJfo0dNHMO9HkWU7vE3gZCEfTH441/Wmw5Xtx8we55x7VQGsmwL1 Yvc2fjLxm601bQIStMJZARvkspVjZqpqX1QpYyUpCnaEDe7G42Eb/5n2IK6fw+UIDc pDHGzTWpCoXbJhVj0CNuqzPqfyS4lIXeA0QzrNJQ= Date: Tue, 12 Mar 2019 15:01:02 -0700 From: "gregkh@linuxfoundation.org" To: Michael Kelley Cc: "will.deacon@arm.com" , "marc.zyngier@arm.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "olaf@aepfle.de" , "apw@canonical.com" , vkuznets , "jasowang@redhat.com" , "marcelo.cerri@canonical.com" , Sunil Muthuswamy , KY Srinivasan , "catalin.marinas@arm.com" , "mark.rutland@arm.com" Subject: Re: [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver Message-ID: <20190312220102.GA17164@kroah.com> References: <1552426813-9568-1-git-send-email-mikelley@microsoft.com> <20190312214652.GA15914@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Tue, Mar 12, 2019 at 09:53:28PM +0000, Michael Kelley wrote: > From: gregkh@linuxfoundation.org Sent: Tuesday, March 12, 2019 2:47 PM > > > > > > Michael Kelley (2): > > > Drivers: hv: Move Hyper-V clockevents code to new clocksource driver > > > Drivers: hv: Move Hyper-V clocksource code to new clocksource driver > > > > You have two different patches that do different things, yet have the > > same identical shortlog text :( > > > > That's not ok, and something that I reject for trivial patches, it > > should never happen for a "real" patch as you don't do the same thing in > > both of these patches. > > Hmmm. Not identical. The first patch is "clockevents" code, and the second > patch is "clocksource" code. Wow, that's not obvious at all, sorry. You still might want to make it a bit more different :) greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F1FC43381 for ; Wed, 13 Mar 2019 11:34:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2F522147C for ; Wed, 13 Mar 2019 11:34:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DUSFICSj"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="W83lWvJV"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="10rpadjO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2F522147C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S9rxcff2bHVkOoVVU499ylFOGBCKEraZE40WXOKM2yM=; b=DUSFICSj8FB3jj rngnwjaFhYj3+eVEZdXIzfYGtY46g26AOgdjjFhRhqxn2OAjixH/dAv3MG3UCIKiRIwYjheT+bdm5 CJSjqP1eUWx/2EzV81oWCdTD6MZTMNJFa9PFkK14vRiH+yqX0b7J+qbZKGO9rAfOOv/46co4p9geN eZtQidRVOwRbi1XK4hk82bk92Bwd931oliE4TO4VY4X2UBJOKDVRIeSaiWE1c5UkgLSS9A2fHlzom bmni+hV5WRL18NbaxwdFz89+5yPKz+ykFAR5rTXxTSrlym8i4/Z1rUqibTpdFgfbCSImWFDzip/0q N48OapMA1QE2js3WwG4A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h428z-0003kV-W8; Wed, 13 Mar 2019 11:33:58 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h426u-0008SO-Bk for linux-arm-kernel@bombadil.infradead.org; Wed, 13 Mar 2019 11:31:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=004Jivwef4zOrP+6yA9YXQojXk/Wr6m517nvMO1OAWM=; b=W83lWvJVz3MMuXv8TdOgnyqpy EcqrRZqNccXS0HBaqw67TA8mFo6Jl5jcMvVkvC/q7GBCsh7xH3AtQXC6YLDtT56sp/5T2V5LKPVuB Q/Dx5UPsMEKJd/+ie6ob3XzfMy2kVi/rZFn/R48gaEGd7nX2pMd70eMGZAbD4pxs1r51u9CffLV8i QEEEW8djlxbNRK/Oh9kJ8+Ajkj/kzItx7bnRD94xFE7NM7DWaSguJEL+1ChrFUhapOff2n7FTJsy2 g3JGjRs52mamYxfwlYV4uge81sNRcL1zOgUS8KIhBhi2OS/rmAXuFjA8KqHyEPa77zmLg/5bvVuYE 2RX410qpw==; Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h3pUA-0006vJ-C0 for linux-arm-kernel@lists.infradead.org; Tue, 12 Mar 2019 22:02:59 +0000 Received: from localhost (unknown [104.133.8.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D467214AE; Tue, 12 Mar 2019 22:01:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1552428063; bh=mzqJdzs7aPWWo7/bSoKNz+UZfdtrDaPFc2zFxpmIM/g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=10rpadjO3U0nScJfo0dNHMO9HkWU7vE3gZCEfTH441/Wmw5Xtx8we55x7VQGsmwL1 Yvc2fjLxm601bQIStMJZARvkspVjZqpqX1QpYyUpCnaEDe7G42Eb/5n2IK6fw+UIDc pDHGzTWpCoXbJhVj0CNuqzPqfyS4lIXeA0QzrNJQ= Date: Tue, 12 Mar 2019 15:01:02 -0700 From: "gregkh@linuxfoundation.org" To: Michael Kelley Subject: Re: [PATCH 0/2] Drivers: hv: Move Hyper-V clock/timer code to separate clocksource driver Message-ID: <20190312220102.GA17164@kroah.com> References: <1552426813-9568-1-git-send-email-mikelley@microsoft.com> <20190312214652.GA15914@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190312_180258_494936_E98074A6 X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "linux-hyperv@vger.kernel.org" , "marc.zyngier@arm.com" , "catalin.marinas@arm.com" , "jasowang@redhat.com" , "will.deacon@arm.com" , "linux-kernel@vger.kernel.org" , "marcelo.cerri@canonical.com" , "olaf@aepfle.de" , "apw@canonical.com" , vkuznets , KY Srinivasan , Sunil Muthuswamy , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 12, 2019 at 09:53:28PM +0000, Michael Kelley wrote: > From: gregkh@linuxfoundation.org Sent: Tuesday, March 12, 2019 2:47 PM > > > > > > Michael Kelley (2): > > > Drivers: hv: Move Hyper-V clockevents code to new clocksource driver > > > Drivers: hv: Move Hyper-V clocksource code to new clocksource driver > > > > You have two different patches that do different things, yet have the > > same identical shortlog text :( > > > > That's not ok, and something that I reject for trivial patches, it > > should never happen for a "real" patch as you don't do the same thing in > > both of these patches. > > Hmmm. Not identical. The first patch is "clockevents" code, and the second > patch is "clocksource" code. Wow, that's not obvious at all, sorry. You still might want to make it a bit more different :) greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel