All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/ecryptfs-utils: Add support without gettext
Date: Tue, 12 Mar 2019 23:14:51 +0100	[thread overview]
Message-ID: <20190312231451.6dde5f3b@windsurf> (raw)
In-Reply-To: <20190312222035.16834-1-vadim4j@gmail.com>

Hello Vadim,

On Wed, 13 Mar 2019 00:20:35 +0200
Vadim Kochan <vadim4j@gmail.com> wrote:

> Add custom ecryptfs-common script which provides gettext wrapper as
> function which checks at runtime if there is gettext tool, if no - the
> "echo" will be used instead. Each script which uses gettext is
> patched with including this ecryptfs-common script.
> 
> The patch for ecryptfs-utils only inserts hard-coded (w/o using
> @prefix@/lib/@PACKAGE@ variables) path to the ecryptfs-common, it is
> very small and trivial, it allows to easy support new bumped version.
> 
> gettext package is now selected automatically only if NLS is enabled.
> 
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
>  ...cho-instead-of-gettext-if-it-does-not-exi.patch | 117 +++++++++++++++++++++
>  package/ecryptfs-utils/Config.in                   |   2 +-
>  package/ecryptfs-utils/ecryptfs-common             |  33 ++++++
>  package/ecryptfs-utils/ecryptfs-utils.mk           |   6 ++
>  4 files changed, 157 insertions(+), 1 deletion(-)
>  create mode 100644 package/ecryptfs-utils/0003-utils-Use-echo-instead-of-gettext-if-it-does-not-exi.patch
>  create mode 100755 package/ecryptfs-utils/ecryptfs-common

Thanks for this proposal. I would actually perfer if ecryptfs-common
was part of the ecryptfs-utils patch, and this patch be submitted
upstream.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-03-12 22:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 22:20 [Buildroot] [PATCH 1/1] package/ecryptfs-utils: Add support without gettext Vadim Kochan
2019-03-12 22:14 ` Thomas Petazzoni [this message]
2019-03-12 22:34   ` Vadim Kochan
2019-03-13 18:53 ` Yann E. MORIN
2019-03-13 19:15   ` Vadym Kochan
2019-03-13 21:28     ` Yann E. MORIN
2019-03-14  1:10       ` Vadim Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190312231451.6dde5f3b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.