From: Omar Sandoval <osandov@osandov.com>
To: Xiao Liang <xiliang@redhat.com>
Cc: linux-block@vger.kernel.org, osandov@fb.com
Subject: Re: [PATCH blktests] Fix checking multiple modules error in _have_modules()
Date: Wed, 13 Mar 2019 00:08:00 -0700 [thread overview]
Message-ID: <20190313070800.GB11825@vader> (raw)
In-Reply-To: <20190313070511.8283-1-xiliang@redhat.com>
On Wed, Mar 13, 2019 at 03:05:11PM +0800, Xiao Liang wrote:
Applied, thanks!
> Signed-off-by: Xiao Liang <xiliang@redhat.com>
> ---
> common/rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/rc b/common/rc
> index 0c354a2..71e27c3 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -33,7 +33,7 @@ _have_modules() {
> local module
>
> for module in "$@"; do
> - if ! modprobe -n -q "$1"; then
> + if ! modprobe -n -q "$module"; then
> missing+=("$module")
> fi
> done
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-03-13 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 7:05 [PATCH blktests] Fix checking multiple modules error in _have_modules() Xiao Liang
2019-03-13 7:08 ` Omar Sandoval [this message]
2019-03-13 17:48 ` Chaitanya Kulkarni
-- strict thread matches above, loose matches on Subject: below --
2019-03-13 6:41 Xiao Liang
2019-03-13 6:50 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313070800.GB11825@vader \
--to=osandov@osandov.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@fb.com \
--cc=xiliang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.