From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8994470309298948118==" MIME-Version: 1.0 From: Reinhard Speyerer Subject: Re: [PATCH 6/8] gprs-context : Force use of atd99 Date: Wed, 13 Mar 2019 14:00:41 +0100 Message-ID: <20190313130041.GA13616@arcor.de> In-Reply-To: <80971d3f-7b46-4da4-b11a-9dd21c021dc7@norrbonn.se> List-Id: To: ofono@ofono.org --===============8994470309298948118== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, Mar 13, 2019 at 09:19:13AM +0100, Jonas Bonn wrote: > Hi, > = > Could I get a clarification on the behaviour you see here? > = > As I understand it, the SARA-R4 doesn't support the CGDATA command. That's > fine as ofono will detect this and set use_atd99 in order to force the use > of the ATD command as a fallback. > = > Why do you need to force this setting in the below patch? Does the CGDATA > command not return ERROR? What does it return? > = > Thanks, > Jonas Hi Jonas, please see my explanation given here https://lists.ofono.org/pipermail/ofono/2019-February/019154.html on why Philippe had to implement ATD99 forcing for the SARA-R4 series. My (limited) tests indicate that another AT feature used by Ofono (the "+CGEV: NW DEACT" URC to detect network-initiated PDP context deactivation) also no longer seems to be reliable starting with Qualcomm MDM9x15 firmwares (e.g. Gemalto PLS8). Regards, Reinhard > = > On 15/02/2019 13:11, philippedeswert(a)gmail.com wrote: > > From: Philippe De Swert > > = > > QUIRCK: For some reason I really need to force the use of the atd99 com= mand here. > > --- > > drivers/atmodem/gprs-context.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > = > > diff --git a/drivers/atmodem/gprs-context.c b/drivers/atmodem/gprs-cont= ext.c > > index 93894efd..a0776f2a 100644 > > --- a/drivers/atmodem/gprs-context.c > > +++ b/drivers/atmodem/gprs-context.c > > @@ -214,7 +214,7 @@ static void at_cgdcont_cb(gboolean ok, GAtResult *r= esult, gpointer user_data) > > return; > > } > > - if (gcd->use_atd99) > > + if (gcd->use_atd99 || gcd->vendor =3D=3D OFONO_VENDOR_UBLOX) > > sprintf(buf, "ATD*99***%u#", gcd->active_context); > > else > > sprintf(buf, "AT+CGDATA=3D\"PPP\",%u", gcd->active_context); > > @@ -457,6 +457,9 @@ static int at_gprs_context_probe(struct ofono_gprs_= context *gc, > > case OFONO_VENDOR_SIMCOM_SIM900: > > gcd->use_atd99 =3D FALSE; > > break; > > + case OFONO_VENDOR_UBLOX: > > + gcd->use_atd99 =3D TRUE; > > + break; > > default: > > g_at_chat_send(chat, "AT+CGDATA=3D?", cgdata_prefix, > > at_cgdata_test_cb, gc, NULL); > > = > _______________________________________________ > ofono mailing list > ofono(a)ofono.org > https://lists.ofono.org/mailman/listinfo/ofono --===============8994470309298948118==--