From: Greg KH <greg@kroah.com>
To: Wentao Cai <etsai042@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] Re: [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig
Date: Wed, 13 Mar 2019 07:18:17 -0700 [thread overview]
Message-ID: <20190313141817.GB5328@kroah.com> (raw)
In-Reply-To: <6289455c-2178-4baf-b1ae-899b7c19fa2a@googlegroups.com>
On Wed, Mar 13, 2019 at 01:34:55AM -0700, Wentao Cai wrote:
>
>
> On Friday, March 1, 2019 at 1:08:53 AM UTC-8, gregkh wrote:
> >
> > > On Fri, Mar 01, 2019 at 05:02:25PM +0800, Wentao Cai wrote:
> > > > Delete the newline at the end of a Kconfig file, to silence the
> > > > checkpatch warning:
> > > > WARNING: please write a paragraph that describes the config symbol
> > > > fully.
> > >
> > > That is not the way to fix this warning :)
> > >
> > > You need to actually write a paragraph, not delete an empty line.
> > >
> >
> Hi, greg, I wonder if it is ok to solve this problem by adding this?
>
> Say Y if you want to include this driver in the kernel.
> To compile this driver as a module, choose M here. The module will be
> called gs_fpgaboot.ko.
You need to say what the driver does, otherwise the user has no idea if
they need it or not.
thanks,
greg k-h
prev parent reply other threads:[~2019-03-13 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 9:02 [PATCHv2] Staging: fpgaboot: Delete newline at the end of Kconfig Wentao Cai
2019-03-01 9:08 ` Greg Kroah-Hartman
2019-03-13 8:34 ` Wentao Cai
2019-03-13 8:37 ` [Outreachy kernel] " Julia Lawall
2019-03-13 8:53 ` Wentao Cai
2019-03-13 14:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313141817.GB5328@kroah.com \
--to=greg@kroah.com \
--cc=etsai042@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.