From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 3/3] drm/i915: Start using comparative
 INTEL_PCH_TYPE
Date: Wed, 13 Mar 2019 13:02:12 -0700
Message-ID: <20190313200212.GJ24277@intel.com>
References: <20190308214300.25057-1-rodrigo.vivi@intel.com>
 <20190308214300.25057-3-rodrigo.vivi@intel.com>
 <20190313173052.dxsiublarhoyxyyf@ldmartin-desk.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 54E736E0EA
 for <intel-gfx@lists.freedesktop.org>; Wed, 13 Mar 2019 20:02:03 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20190313173052.dxsiublarhoyxyyf@ldmartin-desk.amr.corp.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBNYXIgMTMsIDIwMTkgYXQgMTA6MzA6NTJBTSAtMDcwMCwgTHVjYXMgRGUgTWFyY2hp
IHdyb3RlOgo+IE9uIEZyaSwgTWFyIDA4LCAyMDE5IGF0IDAxOjQzOjAwUE0gLTA4MDAsIFJvZHJp
Z28gVml2aSB3cm90ZToKPiA+IEluIG9yZGVyIHRvIG1ha2UgaXQgZWFzaWVyIHRvIGJyaW5nIHVw
IG5ldyBwbGF0Zm9ybXMKPiA+IHdpdGhvdXQgaGF2aW5nIHRvIHRha2UgY2FyZSBhYm91dCBhbGwg
Y29ybmVyIGNhc2VzCj4gPiB0aGF0IHdhcyBwcmV2aW91c2x5IHRha2VuIGNhcmUgZm9yIHByZXZp
b3VzIHBsYXRmb3Jtcwo+ID4gd2UgYWxyZWFkeSB1c2UgY29tcGFyYXRpdmUgSU5URUxfR0VOIHN0
YXRlbWVudHMuCj4gPiAKPiA+IExldCdzIHN0YXJ0IGRvaW5nIHRoZSBzYW1lIHdpdGggUENILgo+
ID4gCj4gPiBUaGUgb25seSBjYXZlYXRzIGFyZToKPiA+IC0gbGVzcy10aGFuIGNvbXBhcmlzb25z
IG5lZWQgdG8gYmUgYXZvaWRlZCBvciBkb25lIHdpdGgKPiA+ICAgYXR0ZW50aW9uIGFuZCBjaGVj
ayA+IFBDSF9OT05FIGFzIHdlbGwuCj4gPiAtIEl0IGlzIG5vdCBuZWNlc3NhcmlseSBhIGNocm9u
b2xvZ2ljYWwgb3JkZXIsIGJ1dCBhIG1hdHRlcgo+ID4gICBvZiBzb3V0aCBkaXNwbGF5IGNvbXBh
dGliaWxpdHkvaW5oZXJpdGFuY2UuCj4gPiAKPiA+IHYyOiBSZWJhc2VkIG9uIHRvcCBvZiBKYW5p
J3MgY2xlYW4tdXAgd2hpY2ggcmVtb3ZlZCB0aGUKPiA+ICAgIG5lZWQgZm9yIGxlc3MtdGhhbiBj
b21wYXJpc29uCj4gPiAKPiA+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29t
Pgo+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+
Cj4gPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4gPiBT
aWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gCj4g
Cj4gUmV2aWV3ZWQtYnk6IEx1Y2FzIERlIE1hcmNoaSA8bHVjYXMuZGVtYXJjaGlAaW50ZWwuY29t
PgoKVGhhbmtzLCBzZXJpZXMgcHVzaGVkLgoKPiAKPiB0aGFua3MKPiBMdWNhcyBEZSBNYXJjaGkK
PiAKPiAKPiA+IC0tLQo+ID4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgICB8IDYg
KysrKysrCj4gPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICAgIHwgNyArKy0tLS0t
Cj4gPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIHwgMiArLQo+ID4gZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgICB8IDMgKy0tCj4gPiBkcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9wYW5lbC5jIHwgNSArKy0tLQo+ID4gNSBmaWxlcyBjaGFuZ2VkLCAxMiBpbnNl
cnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5o
Cj4gPiBpbmRleCA4YTU3Y2RkZTUzODUuLjlhOTNhY2NiYjJlMSAxMDA2NDQKPiA+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfZHJ2LmgKPiA+IEBAIC01MjMsNiArNTIzLDEyIEBAIHN0cnVjdCBpOTE1X3BzciB7
Cj4gPiAJdTE2IHN1X3hfZ3JhbnVsYXJpdHk7Cj4gPiB9Owo+ID4gCj4gPiArLyoKPiA+ICsgKiBT
b3J0ZWQgYnkgc291dGggZGlzcGxheSBlbmdpbmUgY29tcGF0aWJpbGl0eS4KPiA+ICsgKiBJZiB0
aGUgbmV3IFBDSCBjb21lcyB3aXRoIGEgc291dGggZGlzcGxheSBlbmdpbmUgdGhhdCBpcyBub3QK
PiA+ICsgKiBpbmhlcml0ZWQgZnJvbSB0aGUgbGF0ZXN0IGl0ZW0sIHBsZWFzZSBkbyBub3QgYWRk
IGl0IHRvIHRoZQo+ID4gKyAqIGVuZC4gSW5zdGVhZCwgYWRkIGl0IHJpZ2h0IGFmdGVyIGl0cyAi
cGFyZW50IiBQQ0guCj4gPiArICovCj4gPiBlbnVtIGludGVsX3BjaCB7Cj4gPiAJUENIX05PUCA9
IC0xLAkvKiBQQ0ggd2l0aG91dCBzb3V0aCBkaXNwbGF5ICovCj4gPiAJUENIX05PTkUgPSAwLAkv
KiBObyBQQ0ggcHJlc2VudCAqLwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2k5MTVfaXJxLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gPiBpbmRleCAx
ZjRlOTg0Y2U0MmYuLmM4MjNkMmU3Njg1MiAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2k5MTVfaXJxLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJx
LmMKPiA+IEBAIC0yODMxLDkgKzI4MzEsNyBAQCBnZW44X2RlX2lycV9oYW5kbGVyKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgdTMyIG1hc3Rlcl9jdGwpCj4gPiAKPiA+IAkJCWlm
IChIQVNfUENIX0lDUChkZXZfcHJpdikpCj4gPiAJCQkJaWNwX2lycV9oYW5kbGVyKGRldl9wcml2
LCBpaXIpOwo+ID4gLQkJCWVsc2UgaWYgKEhBU19QQ0hfU1BUKGRldl9wcml2KSB8fAo+ID4gLQkJ
CQkgSEFTX1BDSF9LQlAoZGV2X3ByaXYpIHx8Cj4gPiAtCQkJCSBIQVNfUENIX0NOUChkZXZfcHJp
dikpCj4gPiArCQkJZWxzZSBpZiAoSU5URUxfUENIX1RZUEUoZGV2X3ByaXYpID49IFBDSF9TUFQp
Cj4gPiAJCQkJc3B0X2lycV9oYW5kbGVyKGRldl9wcml2LCBpaXIpOwo+ID4gCQkJZWxzZQo+ID4g
CQkJCWNwdF9pcnFfaGFuZGxlcihkZXZfcHJpdiwgaWlyKTsKPiA+IEBAIC00NjIxLDggKzQ2MTks
NyBAQCB2b2lkIGludGVsX2lycV9pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp
dikKPiA+IAkJZGV2LT5kcml2ZXItPmRpc2FibGVfdmJsYW5rID0gZ2VuOF9kaXNhYmxlX3ZibGFu
azsKPiA+IAkJaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ID4gCQkJZGV2X3ByaXYtPmRpc3Bs
YXkuaHBkX2lycV9zZXR1cCA9IGJ4dF9ocGRfaXJxX3NldHVwOwo+ID4gLQkJZWxzZSBpZiAoSEFT
X1BDSF9TUFQoZGV2X3ByaXYpIHx8IEhBU19QQ0hfS0JQKGRldl9wcml2KSB8fAo+ID4gLQkJCSBI
QVNfUENIX0NOUChkZXZfcHJpdikpCj4gPiArCQllbHNlIGlmIChJTlRFTF9QQ0hfVFlQRShkZXZf
cHJpdikgPj0gUENIX1NQVCkKPiA+IAkJCWRldl9wcml2LT5kaXNwbGF5LmhwZF9pcnFfc2V0dXAg
PSBzcHRfaHBkX2lycV9zZXR1cDsKPiA+IAkJZWxzZQo+ID4gCQkJZGV2X3ByaXYtPmRpc3BsYXku
aHBkX2lycV9zZXR1cCA9IGlsa19ocGRfaXJxX3NldHVwOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9jZGNsay5jCj4gPiBpbmRleCA3ZTUxMzI3NzI0NzcuLjlkMjM2ZTRlZDI2YSAxMDA2NDQKPiA+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+IEBAIC0yNzIzLDcgKzI3MjMsNyBAQCBz
dGF0aWMgaW50IGc0eF9ocmF3Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikK
PiA+ICAqLwo+ID4gdm9pZCBpbnRlbF91cGRhdGVfcmF3Y2xrKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdikKPiA+IHsKPiA+IC0JaWYgKEhBU19QQ0hfQ05QKGRldl9wcml2KSB8fCBI
QVNfUENIX0lDUChkZXZfcHJpdikpCj4gPiArCWlmIChJTlRFTF9QQ0hfVFlQRShkZXZfcHJpdikg
Pj0gUENIX0NOUCkKPiA+IAkJZGV2X3ByaXYtPnJhd2Nsa19mcmVxID0gY25wX3Jhd2NsayhkZXZf
cHJpdik7Cj4gPiAJZWxzZSBpZiAoSEFTX1BDSF9TUExJVChkZXZfcHJpdikpCj4gPiAJCWRldl9w
cml2LT5yYXdjbGtfZnJlcSA9IHBjaF9yYXdjbGsoZGV2X3ByaXYpOwo+ID4gZGlmZiAtLWdpdCBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kcC5jCj4gPiBpbmRleCBmNDBiMzM0MmQ4MmEuLjQ3ODU3Zjk2YzNiMSAxMDA2NDQKPiA+
IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+IEBAIC05NTEsOCArOTUxLDcgQEAgc3RhdGljIHZv
aWQgaW50ZWxfcHBzX2dldF9yZWdpc3RlcnMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiA+
IAlyZWdzLT5wcF9vZmYgPSBQUF9PRkZfREVMQVlTKHBwc19pZHgpOwo+ID4gCj4gPiAJLyogQ3lj
bGUgZGVsYXkgbW92ZWQgZnJvbSBQUF9ESVZJU09SIHRvIFBQX0NPTlRST0wgKi8KPiA+IC0JaWYg
KElTX0dFTjlfTFAoZGV2X3ByaXYpIHx8IEhBU19QQ0hfQ05QKGRldl9wcml2KSB8fAo+ID4gLQkg
ICAgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKQo+ID4gKwlpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikg
fHwgSU5URUxfUENIX1RZUEUoZGV2X3ByaXYpID49IFBDSF9DTlApCj4gPiAJCXJlZ3MtPnBwX2Rp
diA9IElOVkFMSURfTU1JT19SRUc7Cj4gPiAJZWxzZQo+ID4gCQlyZWdzLT5wcF9kaXYgPSBQUF9E
SVZJU09SKHBwc19pZHgpOwo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wYW5lbC5jCj4gPiBpbmRl
eCBiZWNhOThkMmIwMzUuLmVkZDU1NDA2MzliMCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3BhbmVsLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX3BhbmVsLmMKPiA+IEBAIC0xODk0LDE1ICsxODk0LDE0IEBAIGludGVsX3BhbmVsX2luaXRf
YmFja2xpZ2h0X2Z1bmNzKHN0cnVjdCBpbnRlbF9wYW5lbCAqcGFuZWwpCj4gPiAJCXBhbmVsLT5i
YWNrbGlnaHQuc2V0ID0gYnh0X3NldF9iYWNrbGlnaHQ7Cj4gPiAJCXBhbmVsLT5iYWNrbGlnaHQu
Z2V0ID0gYnh0X2dldF9iYWNrbGlnaHQ7Cj4gPiAJCXBhbmVsLT5iYWNrbGlnaHQuaHpfdG9fcHdt
ID0gYnh0X2h6X3RvX3B3bTsKPiA+IC0JfSBlbHNlIGlmIChIQVNfUENIX0NOUChkZXZfcHJpdikg
fHwgSEFTX1BDSF9JQ1AoZGV2X3ByaXYpKSB7Cj4gPiArCX0gZWxzZSBpZiAoSU5URUxfUENIX1RZ
UEUoZGV2X3ByaXYpID49IFBDSF9DTlApIHsKPiA+IAkJcGFuZWwtPmJhY2tsaWdodC5zZXR1cCA9
IGNucF9zZXR1cF9iYWNrbGlnaHQ7Cj4gPiAJCXBhbmVsLT5iYWNrbGlnaHQuZW5hYmxlID0gY25w
X2VuYWJsZV9iYWNrbGlnaHQ7Cj4gPiAJCXBhbmVsLT5iYWNrbGlnaHQuZGlzYWJsZSA9IGNucF9k
aXNhYmxlX2JhY2tsaWdodDsKPiA+IAkJcGFuZWwtPmJhY2tsaWdodC5zZXQgPSBieHRfc2V0X2Jh
Y2tsaWdodDsKPiA+IAkJcGFuZWwtPmJhY2tsaWdodC5nZXQgPSBieHRfZ2V0X2JhY2tsaWdodDsK
PiA+IAkJcGFuZWwtPmJhY2tsaWdodC5oel90b19wd20gPSBjbnBfaHpfdG9fcHdtOwo+ID4gLQl9
IGVsc2UgaWYgKEhBU19QQ0hfTFBUKGRldl9wcml2KSB8fCBIQVNfUENIX1NQVChkZXZfcHJpdikg
fHwKPiA+IC0JCSAgIEhBU19QQ0hfS0JQKGRldl9wcml2KSkgewo+ID4gKwl9IGVsc2UgaWYgKElO
VEVMX1BDSF9UWVBFKGRldl9wcml2KSA+PSBQQ0hfTFBUKSB7Cj4gPiAJCXBhbmVsLT5iYWNrbGln
aHQuc2V0dXAgPSBscHRfc2V0dXBfYmFja2xpZ2h0Owo+ID4gCQlwYW5lbC0+YmFja2xpZ2h0LmVu
YWJsZSA9IGxwdF9lbmFibGVfYmFja2xpZ2h0Owo+ID4gCQlwYW5lbC0+YmFja2xpZ2h0LmRpc2Fi
bGUgPSBscHRfZGlzYWJsZV9iYWNrbGlnaHQ7Cj4gPiAtLSAKPiA+IDIuMjAuMQo+ID4gCj4gX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZngg
bWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8v
bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n
IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk
ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==