From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies
Date: Wed, 13 Mar 2019 20:07:25 +0100 [thread overview]
Message-ID: <20190313200725.33bae840@gmx.net> (raw)
In-Reply-To: <20190313164746.ECDF38B66D@busybox.osuosl.org>
Hello Martin, Thomas,
On Wed, 13 Mar 2019 17:50:39 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=6fb4c14ecb1e8f001449830b65ec2a4606b87682
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> qt5declarative can be built/used without opengl support so fix the
> dependency comment in qt5webengine.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/qt5/qt5webengine/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/qt5/qt5webengine/Config.in b/package/qt5/qt5webengine/Config.in
> index 744d659567..bfc0a02c12 100644
> --- a/package/qt5/qt5webengine/Config.in
> +++ b/package/qt5/qt5webengine/Config.in
> @@ -34,7 +34,7 @@ config BR2_PACKAGE_QT5WEBENGINE
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_85862 || BR2_PACKAGE_QT5_VERSION_5_6 # libnss
> depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2, libvpx, qt5base-dbus
> depends on BR2_USE_WCHAR # libglib2
> - depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5declarative, qt5base-eglfs
> + depends on BR2_PACKAGE_QT5_GL_AVAILABLE # qt5base-eglfs
This comment change is only valid for BR2_PACKAGE_QT5_VERSION_LATEST/Qt5.12.x as
qt5webengine selects BR2_PACKAGE_QT5DECLARATIVE_QUICK and qt5declarative/Config.in
states:
config BR2_PACKAGE_QT5DECLARATIVE_QUICK
bool "quick module"
depends on BR2_PACKAGE_QT5_GL_AVAILABLE || BR2_PACKAGE_QT5_VERSION_LATEST
Regards,
Peter
> depends on BR2_PACKAGE_HAS_LIBEGL # qt5base-eglfs
> depends on BR2_PACKAGE_HAS_UDEV
> # v8 (a chromium 3rd-party) compiles its internal host-tools with the
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2019-03-13 19:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:50 [Buildroot] [git commit] package/qt5/qt5webengine: fix comment on GL dependencies Thomas Petazzoni
2019-03-13 19:07 ` Peter Seiderer [this message]
2019-03-14 7:52 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313200725.33bae840@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.