From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: andrii.nakryiko@gmail.com, dwarves@vger.kernel.org,
bpf@vger.kernel.org, ast@fb.com, yhs@fb.com
Subject: Re: [PATCH pahole] loaders: strip away volatile/const/restrict when fixing bitfields
Date: Wed, 13 Mar 2019 18:21:54 -0300 [thread overview]
Message-ID: <20190313212154.GD4786@kernel.org> (raw)
In-Reply-To: <20190313165301.2739423-1-andriin@fb.com>
Em Wed, Mar 13, 2019 at 09:53:01AM -0700, Andrii Nakryiko escreveu:
> btf_loader and ctf_loader didn't remove const/volatile/restrict, so
> bitfields using modifiers were not adjusted properly.
>
> This patch abstracts logic of stripping aways typedefs and access
> modifiers into tag__strip_typedefs_and_modifiers, which handles any
> interleaving of typedefs and modifiers. dwarf_loader was adapter to
> reuse this function as well, instead of custom goto loop.
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2019-03-13 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:53 [PATCH pahole] loaders: strip away volatile/const/restrict when fixing bitfields Andrii Nakryiko
2019-03-13 21:21 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313212154.GD4786@kernel.org \
--to=arnaldo.melo@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.