From: Pavel Machek <pavel@ucw.cz>
To: Dan Murphy <dmurphy@ti.com>
Cc: robh+dt@kernel.org, jacek.anaszewski@gmail.com, tony@atomide.com,
lee.jones@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc
Date: Thu, 14 Mar 2019 10:39:12 +0100 [thread overview]
Message-ID: <20190314093912.GA10637@amd> (raw)
In-Reply-To: <20190313123249.17258-1-dmurphy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
Hi!
Could you maybe slow down a bit.
"Hey, I should review this". "Hmm, there are two new versions in the
mailbox in the meantime, good thing I waited."
> + ramp-up-ms = <1024>;
> + ramp-down-ms = <65536>;
This is wrong.
> + led@1 {
> + reg = <1>;
> + led-sources = <1>;
> + ti,led-mode = <0>;
> + label = "keypad";
"platform::kbd_backlight"
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-03-14 9:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 12:32 [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-13 12:32 ` Dan Murphy
2019-03-13 12:32 ` [PATCH v4 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-03-13 12:32 ` Dan Murphy
2019-03-13 12:32 ` [PATCH v4 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-13 12:32 ` Dan Murphy
2019-03-13 12:32 ` [PATCH v4 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-13 12:32 ` Dan Murphy
2019-03-20 12:39 ` Dan Murphy
2019-03-20 12:39 ` Dan Murphy
2019-03-20 19:00 ` Jacek Anaszewski
2019-03-20 19:05 ` Dan Murphy
2019-03-20 19:05 ` Dan Murphy
2019-03-20 18:59 ` Jacek Anaszewski
2019-03-20 19:04 ` Dan Murphy
2019-03-20 19:04 ` Dan Murphy
2019-03-21 8:21 ` Lee Jones
2019-03-21 8:20 ` Lee Jones
2019-03-14 9:39 ` Pavel Machek [this message]
2019-03-14 12:52 ` [PATCH v4 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-14 12:52 ` Dan Murphy
2019-03-15 23:35 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314093912.GA10637@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.