From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3765CC43381 for ; Thu, 14 Mar 2019 16:30:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E01C92077B for ; Thu, 14 Mar 2019 16:30:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XsRRGRmT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726889AbfCNQar (ORCPT ); Thu, 14 Mar 2019 12:30:47 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39438 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726564AbfCNQar (ORCPT ); Thu, 14 Mar 2019 12:30:47 -0400 Received: by mail-pg1-f194.google.com with SMTP id h8so4337539pgp.6 for ; Thu, 14 Mar 2019 09:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=KNPyPcP7xNFdviN4Ssdd6342gefBuI4ny72tPTT7LE8=; b=XsRRGRmTD6tLa/R/fA4VKOmckYAgLe3XJaP6Qobe4DcT1gSpL4eQa8v3NE8K8ZH4KR PNt6Vw5lStch2HOhDKtfCspv6swmHDCetPTd8Zq98Fo8IZCbk2B5GEdQc8oU+TS0LdMu LOcc3bYe3Hcva++TT14enFroNpwsvCYAQcPjg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=KNPyPcP7xNFdviN4Ssdd6342gefBuI4ny72tPTT7LE8=; b=j+foyjAJxEL6lLS3TsZlQndYrJcdYpUWRsAj11ytasF69ABIlYIeLhRV4gu0g/VmyV xEcjhsU7m3uXlIKKy0dqhmE0xiqvnRfZ/wf0qyRBL8BxWZ8EuIVAB/WEhSKriptW+Iua 2kYd5UcQ1fyQAMZ4Hg4FX40+hg8JnIesNymKuVDuCzQ3VLczSWM7lHFOuVQuKAqAHbdS v94N2ZxxcQ5FEjeTyU1QBXrj3E/WOyHhrGfBmO/3WoD51HzXDngFkQSJ1qBvMTu/kbcX FNpnaJKjcpFPs3ea7r0TXjDFGxKqgso7Pscb3igrsqillGn3EkqlkV99ly8RZGz8PJIg oJkA== X-Gm-Message-State: APjAAAWhSe2jOM970Dt+8VDxUWSKZTA8RTzUcf52ji9r0xQpqpZ1ZQ3I 4CvaxsK59XlzleKYR+mjSee7prt+ERE= X-Google-Smtp-Source: APXvYqzWPDuRlL3QaT7onlcAoxipsoTIO/a1zP6OA8e2aww2+BHe1nP6NDVQ2kcInb6vGcPAIsvZMg== X-Received: by 2002:a65:4342:: with SMTP id k2mr30785526pgq.445.1552581046052; Thu, 14 Mar 2019 09:30:46 -0700 (PDT) Received: from google.com ([2620:15c:202:201:49ea:b78f:4f04:4d25]) by smtp.googlemail.com with ESMTPSA id t3sm19223749pgv.39.2019.03.14.09.30.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Mar 2019 09:30:45 -0700 (PDT) Date: Thu, 14 Mar 2019 09:30:42 -0700 From: Zubin Mithra To: stable@vger.kernel.org Cc: groeck@chromium.org, gregkh@linuxfoundation.org, ebiggers@google.com, dhowells@redhat.com, jmorris@namei.org, serge@hallyn.com Subject: 4aa68e07d845 ("KEYS: restrict /proc/keys by credentials at open time") Message-ID: <20190314163040.GA36815@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hello, Syzkaller has triggered a kernel BUG when fuzzing a 4.4 kernel with the following stacktrace. Call Trace: [] construct_alloc_key security/keys/request_key.c:388 [inline] [] construct_key_and_link security/keys/request_key.c:479 [inline] [] request_key_and_link+0x49b/0x8c5 security/keys/request_key.c:594 [] SYSC_request_key security/keys/keyctl.c:213 [inline] [] SyS_request_key+0x1ac/0x2a2 security/keys/keyctl.c:158 [] entry_SYSCALL_64_fastpath+0x31/0xb3 Could the following patches be applied to v4.4.y? * 4aa68e07d845 ("KEYS: restrict /proc/keys by credentials at open time") * ede0fa98a900 ("KEYS: always initialize keyring_index_key::desc_len") Note: queue-4.4 currently has a backport for "keys-always-initialize-keyring_index_key-desc_len.patch". This request is to apply the 2 patches above instead of just one, to 4.4.y, as the first patch is a bugfix as well. They apply cleanly if applied one after another. Tests: * Chrome OS tryjob * Syzkaller reproducer * Test to check if 4aa68e07d845 works as intended Thanks, - Zubin