From: aszlig <aszlig@nix.build>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>,
Graham Christensen <graham@grahamc.com>,
Samuel Dionne-Riel <samuel@dionne-riel.com>,
michael bishop <cleverca22@gmail.com>
Subject: Re: Failure to execute file on overlayfs during switch_root/chroot
Date: Thu, 14 Mar 2019 20:45:07 +0100 [thread overview]
Message-ID: <20190314194507.GA27112@dnyarri> (raw)
In-Reply-To: <CAOQ4uxipOHT+OzPtFE1ZoSFEJSrEr-MErwp5KX+tBwXq39sx8g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On Thu, Mar 14, 2019 at 09:38:05PM +0200, Amir Goldstein wrote:
> OTOH, ovl_path_open() from ovl_copy_up_data() does open lower
> file with O_NOATIME, so I am a bit surprised you did not see the
> same issue there.
Good point actually, I did forget about that. The reason we did not run into
this issue is because Nix store paths are *never* changed (only new ones are
added) and the store is mounted read-only (new paths are crated using a mount
namespace where the store path is writable).
So yes, actually the O_NOATIME should also be removed from ovl_copy_up_data().
a!
--
aszlig
Universal dilettante
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-03-14 19:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181207121027.GA5996@dnyarri>
[not found] ` <CAJfpegsu6DUHVVac2PSyGoFW4pAKm3UH0XLg5+SMvN5XZmNzFw@mail.gmail.com>
2019-01-29 19:41 ` Failure to execute file on overlayfs during switch_root/chroot aszlig
2019-02-02 17:29 ` aszlig
2019-02-03 5:37 ` Amir Goldstein
2019-02-03 10:13 ` aszlig
2019-02-03 13:51 ` Amir Goldstein
2019-03-14 1:09 ` aszlig
2019-03-14 1:20 ` aszlig
2019-03-14 7:47 ` Amir Goldstein
2019-03-14 10:37 ` aszlig
2019-03-14 19:38 ` Amir Goldstein
2019-03-14 19:45 ` aszlig [this message]
2019-03-16 3:21 ` [PATCH] ovl: Don't open files with O_NOATIME in lowerdir aszlig
2019-03-16 9:09 ` Amir Goldstein
2019-03-16 11:17 ` aszlig
2019-03-14 10:40 ` Failure to execute file on overlayfs during switch_root/chroot Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314194507.GA27112@dnyarri \
--to=aszlig@nix.build \
--cc=amir73il@gmail.com \
--cc=cleverca22@gmail.com \
--cc=graham@grahamc.com \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=samuel@dionne-riel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.