From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/systemd: use util-linux' agetty, drop patch
Date: Thu, 14 Mar 2019 22:15:18 +0100 [thread overview]
Message-ID: <20190314221518.46974533@windsurf> (raw)
In-Reply-To: <20190312214846.10601-1-yann.morin.1998@free.fr>
On Tue, 12 Mar 2019 22:48:46 +0100
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> We currently have a patch that replaces the use of (hard-coded) agetty
> in systemd, to use just plain getty. That patch dates back to commit
> f4a5eed474c (Add the systemd package), when util-linux was not a
> dependency, and we relied on busybox to actually provide getty.
>
> But nowadays, util-linux is a mandatory dependency of systemd anyway.
> agetty is about 42KiB, while busybox' getty is around 5KiB (give or
> take). That's an extra ~40KiB, but it has to be balanced against the
> rest of the system: systemd only runs on a glibc system, needs dbus and
> thus expat, and kmod, that a ~40KiB overhead is barely noticeable (a
> miminal systemd setup with nothing enabled, on ARM, is already ~20MiB)
>
> So, drop our agetty-dropping patch, and forcibly enable agetty in
> util-linux.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Adam Duskett <aduskett@gmail.com>
> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> ---
> Note: all 6 run-time tests still pass.
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-03-14 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 21:48 [Buildroot] [PATCH v2] package/systemd: use util-linux' agetty, drop patch Yann E. MORIN
2019-03-14 21:15 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190314221518.46974533@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.