From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: xen-devel@lists.xenproject.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
jgross@suse.com, boris.ostrovsky@oracle.com
Cc: andr2000@gmail.com, Volodymyr_Babchuk@epam.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: [Xen-devel][PATCH] Input: xen-kbdfront - signal the backend that we disconnect
Date: Fri, 15 Mar 2019 11:23:48 +0200 [thread overview]
Message-ID: <20190315092348.32613-1-andr2000@gmail.com> (raw)
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
While disconnecting from the backend we clean up shared resources
(event channel, ring buffer), but never let the backend know about
that. This may lead to inconsistent backend state and/or shared
resources use.
Fix this by explicitly letting the backend know that frontend has
destroyed shared resources by changing its Xen bus state accordingly.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
---
drivers/input/misc/xen-kbdfront.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 24bc5c5d876f..ecb6e719e0e2 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -488,6 +488,8 @@ static int xenkbd_connect_backend(struct xenbus_device *dev,
static void xenkbd_disconnect_backend(struct xenkbd_info *info)
{
+ xenbus_switch_state(info->xbdev, XenbusStateClosing);
+
if (info->irq >= 0)
unbind_from_irqhandler(info->irq, info);
info->irq = -1;
--
2.21.0
next reply other threads:[~2019-03-15 9:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 9:23 Oleksandr Andrushchenko [this message]
2019-03-22 11:03 ` [PATCH] Input: xen-kbdfront - signal the backend that we disconnect Juergen Gross
2019-03-22 11:03 ` [Xen-devel][PATCH] " Juergen Gross
2019-03-22 11:09 ` Oleksandr Andrushchenko
2019-03-22 11:09 ` [PATCH] " Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315092348.32613-1-andr2000@gmail.com \
--to=andr2000@gmail.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jgross@suse.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.