From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21135C43381 for ; Fri, 15 Mar 2019 10:54:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB43021871 for ; Fri, 15 Mar 2019 10:54:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728875AbfCOKyy (ORCPT ); Fri, 15 Mar 2019 06:54:54 -0400 Received: from mga03.intel.com ([134.134.136.65]:26416 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728879AbfCOKyy (ORCPT ); Fri, 15 Mar 2019 06:54:54 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 03:51:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,481,1544515200"; d="scan'208";a="155313633" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Mar 2019 03:51:47 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 15 Mar 2019 12:51:46 +0200 Date: Fri, 15 Mar 2019 12:51:46 +0200 From: Heikki Krogerus To: Biju Das , Rob Herring Cc: Yoshihiro Shimoda , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" Subject: Re: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property Message-ID: <20190315105146.GI7752@kuha.fi.intel.com> References: <1552552775-51667-1-git-send-email-biju.das@bp.renesas.com> <1552552775-51667-3-git-send-email-biju.das@bp.renesas.com> <20190314105347.GC7752@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Thanks, On Fri, Mar 15, 2019 at 09:08:19AM +0000, Biju Das wrote: > > Subject: Re: [PATCH v2 2/7] dt-bindings: usb: renesas_usb3: add usb-role- > > > > > a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > > > b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > > > index 35039e7..eecaf4c 100644 > > > > > --- a/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > > > +++ b/Documentation/devicetree/bindings/usb/renesas_usb3.txt > > > > > @@ -22,6 +22,7 @@ Required properties: > > > > > Optional properties: > > > > > - phys: phandle + phy specifier pair > > > > > - phy-names: must be "usb" > > > > > + - usb-role-switch: use USB role switch to support dual-role > > > > > + switch > > > > > > > > I don't think we can add such a property. At least, we have to add > > "renesas," > > > > prefix. > > > > > > usb_role_switch_get api uses "usb-role-switch" property to get role > > switch linked with the device. > > > > > > HD3SS3220 port controller driver gets role switch handle linked with the > > device using usb_role_switch_get api. > > > That is the reason, I have added " usb-role-switch" property here. > > > > > > Do you have any other suggestion to get usb role switch handle? > > > > We can still change the API. Can we use the compatible for this? > > Do you mean usb_role_switch_get API needs to handle compatible "usb-x-connector" wherex= a,b ,c ? > Then it uses the graphs api to get the device linked with it and return the usb role switch handle. > In that case, no need to add generic "usb-role-switch" property here. > > Can you please confirm my understanding is correct? No, I meant the compatible property would have the value "usb-role-switch". Your compatible would probable look something like this: compatible = "renesas,r8a774c0-usb3-peri", "usb-role-switch"; So the idea would be that the device supplying USB role switch functionality, in your case the USB controller, would need to have the compatible property containing "usb-role-switch". I'm really not an expert in DT, so I don't know if that is acceptable. Rob can you comment on this? thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/7] dt-bindings: usb: renesas_usb3: add usb-role-switch property From: Heikki Krogerus Message-Id: <20190315105146.GI7752@kuha.fi.intel.com> Date: Fri, 15 Mar 2019 12:51:46 +0200 To: Biju Das , Rob Herring Cc: Yoshihiro Shimoda , Mark Rutland , Greg Kroah-Hartman , Felipe Balbi , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Simon Horman , Geert Uytterhoeven , Chris Paterson , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" List-ID: VGhhbmtzLAoKT24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDk6MDg6MTlBTSArMDAwMCwgQmlqdSBE YXMgd3JvdGU6Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDIvN10gZHQtYmluZGluZ3M6IHVz YjogcmVuZXNhc191c2IzOiBhZGQgdXNiLXJvbGUtCj4gPiA+ID4gPiBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcmVuZXNhc191c2IzLnR4dAo+ID4gPiA+ID4gYi9Eb2N1 bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3JlbmVzYXNfdXNiMy50eHQKPiA+ID4g PiA+IGluZGV4IDM1MDM5ZTcuLmVlY2FmNGMgMTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL3JlbmVzYXNfdXNiMy50eHQKPiA+ID4gPiA+ ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvcmVuZXNhc191c2Iz LnR4dAo+ID4gPiA+ID4gQEAgLTIyLDYgKzIyLDcgQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiA+ ID4gPiA+ICBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ID4gPiA+ID4gICAgLSBwaHlzOiBwaGFuZGxl ICsgcGh5IHNwZWNpZmllciBwYWlyCj4gPiA+ID4gPiAgICAtIHBoeS1uYW1lczogbXVzdCBiZSAi dXNiIgo+ID4gPiA+ID4gKyAgLSB1c2Itcm9sZS1zd2l0Y2g6IHVzZSBVU0Igcm9sZSBzd2l0Y2gg dG8gc3VwcG9ydCBkdWFsLXJvbGUKPiA+ID4gPiA+ICsgc3dpdGNoCj4gPiA+ID4KPiA+ID4gPiBJ IGRvbid0IHRoaW5rIHdlIGNhbiBhZGQgc3VjaCBhIHByb3BlcnR5LiBBdCBsZWFzdCwgd2UgaGF2 ZSB0byBhZGQKPiA+ICJyZW5lc2FzLCIKPiA+ID4gPiBwcmVmaXguCj4gPiA+Cj4gPiA+IHVzYl9y b2xlX3N3aXRjaF9nZXQgICBhcGkgdXNlcyAgInVzYi1yb2xlLXN3aXRjaCIgIHByb3BlcnR5IHRv IGdldCByb2xlCj4gPiBzd2l0Y2ggbGlua2VkIHdpdGggdGhlIGRldmljZS4KPiA+ID4KPiA+ID4g SEQzU1MzMjIwIHBvcnQgY29udHJvbGxlciBkcml2ZXIgZ2V0cyByb2xlIHN3aXRjaCBoYW5kbGUg bGlua2VkIHdpdGggdGhlCj4gPiBkZXZpY2UgdXNpbmcgdXNiX3JvbGVfc3dpdGNoX2dldCAgYXBp Lgo+ID4gPiBUaGF0IGlzIHRoZSByZWFzb24sIEkgaGF2ZSBhZGRlZCAiIHVzYi1yb2xlLXN3aXRj aCIgcHJvcGVydHkgaGVyZS4KPiA+ID4KPiA+ID4gRG8geW91IGhhdmUgYW55IG90aGVyIHN1Z2dl c3Rpb24gdG8gZ2V0IHVzYiByb2xlIHN3aXRjaCBoYW5kbGU/Cj4gPiAKPiA+IFdlIGNhbiBzdGls bCBjaGFuZ2UgdGhlIEFQSS4gQ2FuIHdlIHVzZSB0aGUgY29tcGF0aWJsZSBmb3IgdGhpcz8KPiAK PiBEbyB5b3UgbWVhbiB1c2Jfcm9sZV9zd2l0Y2hfZ2V0ICBBUEkgbmVlZHMgIHRvIGhhbmRsZSBj b21wYXRpYmxlICJ1c2IteC1jb25uZWN0b3IiICB3aGVyZXg9IGEsYiAsYyA/Cj4gVGhlbiBpdCB1 c2VzIHRoZSBncmFwaHMgYXBpIHRvIGdldCB0aGUgZGV2aWNlIGxpbmtlZCB3aXRoIGl0IGFuZCBy ZXR1cm4gdGhlIHVzYiByb2xlIHN3aXRjaCBoYW5kbGUuCj4gSW4gdGhhdCBjYXNlLCBubyBuZWVk IHRvIGFkZCAgZ2VuZXJpYyAidXNiLXJvbGUtc3dpdGNoIiAgcHJvcGVydHkgaGVyZS4KPiAKPiBD YW4geW91IHBsZWFzZSBjb25maXJtIG15IHVuZGVyc3RhbmRpbmcgaXMgY29ycmVjdD8KCk5vLCBJ IG1lYW50IHRoZSBjb21wYXRpYmxlIHByb3BlcnR5IHdvdWxkIGhhdmUgdGhlIHZhbHVlCiJ1c2It cm9sZS1zd2l0Y2giLiBZb3VyIGNvbXBhdGlibGUgd291bGQgcHJvYmFibGUgbG9vayBzb21ldGhp bmcKbGlrZSB0aGlzOgoKICAgICAgICBjb21wYXRpYmxlID0gInJlbmVzYXMscjhhNzc0YzAtdXNi My1wZXJpIiwKICAgICAgICAgICAgICAgICAgICAgInVzYi1yb2xlLXN3aXRjaCI7CgpTbyB0aGUg aWRlYSB3b3VsZCBiZSB0aGF0IHRoZSBkZXZpY2Ugc3VwcGx5aW5nIFVTQiByb2xlIHN3aXRjaApm dW5jdGlvbmFsaXR5LCBpbiB5b3VyIGNhc2UgdGhlIFVTQiBjb250cm9sbGVyLCB3b3VsZCBuZWVk IHRvIGhhdmUgdGhlCmNvbXBhdGlibGUgcHJvcGVydHkgY29udGFpbmluZyAidXNiLXJvbGUtc3dp dGNoIi4KCkknbSByZWFsbHkgbm90IGFuIGV4cGVydCBpbiBEVCwgc28gSSBkb24ndCBrbm93IGlm IHRoYXQgaXMgYWNjZXB0YWJsZS4KUm9iIGNhbiB5b3UgY29tbWVudCBvbiB0aGlzPwoKCnRoYW5r cywK