diff for duplicates of <20190315113330.5ef0eeef.cohuck@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b4a499c..f422380 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -29,7 +29,7 @@ Pierre Morel <pmorel@linux.ibm.com> wrote: > + list_add(&q->list, &matrix_dev->free_list); > + mutex_unlock(&matrix_dev->lock); -From what I can see, dealing with the free_list is supposed to be +>From what I can see, dealing with the free_list is supposed to be protected by the matrix_dev mutex, and at a glance, it indeed seems to be held every time you interact with the list. I think it would be good to document that with a comment. diff --git a/a/content_digest b/N1/content_digest index f7e7fa0..5473e31 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -50,7 +50,7 @@ "> +\tlist_add(&q->list, &matrix_dev->free_list);\n" "> +\tmutex_unlock(&matrix_dev->lock);\n" "\n" - "From what I can see, dealing with the free_list is supposed to be\n" + ">From what I can see, dealing with the free_list is supposed to be\n" "protected by the matrix_dev mutex, and at a glance, it indeed seems to\n" "be held every time you interact with the list. I think it would be good\n" "to document that with a comment.\n" @@ -62,4 +62,4 @@ "> \treturn 0;\n" > } -8b08d3f558172024841c4e565ad58410104cca1d619e2fd680d176006b62356f +b4d3f44d0959352b2dea85ee12b68855c0475bac1c5c8b7ab0855f5e71ccb08c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.