From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Date: Fri, 15 Mar 2019 13:58:54 +0200 Message-ID: <20190315115854.GJ7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1552641204.10179.133.camel@mhfsdcap03> Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun , Hans de Goede Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > `usb_role_switch_register' > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > `usb_role_switch_unregister' > > the following patch has fixed the issue, but seems not get into kernel, > [v3,08/12] usb: roles: Add usb role switch notifier. > https://patchwork.kernel.org/patch/10836525/ > > What should I do if I add a new API? Thanks So if you are asking should you supply dummy functions for the new API, then I would just say that if you do so, you need to prepare these patches on top of that series from Yu Chen. In general I'm not sure we need dummy functions with this API. Hans, comments? thanks, -- heikki From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,4/6] usb: roles: add API to get usb_role_switch by node From: Heikki Krogerus Message-Id: <20190315115854.GJ7752@kuha.fi.intel.com> Date: Fri, 15 Mar 2019 13:58:54 +0200 To: Chunfeng Yun , Hans de Goede Cc: Andy Shevchenko , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , Badhri Jagan Sridharan , Min Guo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org List-ID: T24gRnJpLCBNYXIgMTUsIDIwMTkgYXQgMDU6MTM6MjRQTSArMDgwMCwgQ2h1bmZlbmcgWXVuIHdy b3RlOgo+IEkgZW5jb3VudGVyIGEgYnVpbGQgZXJyb3Igd2hlbiBDT05GSUdfVVNCX1JPTEVfU1dJ VENIIGlzIG5vdCBlbmFibGVkLAo+IAo+IGRyaXZlcnMvdXNiL210dTMvbXR1M19kci5vOiBJbiBm dW5jdGlvbiBgc3N1c2Jfcm9sZV9zd19yZWdpc3Rlcic6Cj4gLi9kcml2ZXJzL3VzYi9tdHUzL210 dTNfZHIuYzo0NjA6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8KPiBgdXNiX3JvbGVfc3dpdGNoX3Jl Z2lzdGVyJwo+IGRyaXZlcnMvdXNiL210dTMvbXR1M19kci5vOiBJbiBmdW5jdGlvbiBgc3N1c2Jf b3RnX3N3aXRjaF9leGl0JzoKPiAuL2RyaXZlcnMvdXNiL210dTMvbXR1M19kci5jOjQ5MTogdW5k ZWZpbmVkIHJlZmVyZW5jZSB0bwo+IGB1c2Jfcm9sZV9zd2l0Y2hfdW5yZWdpc3RlcicKPiAKPiB0 aGUgZm9sbG93aW5nIHBhdGNoIGhhcyBmaXhlZCB0aGUgaXNzdWUsIGJ1dCBzZWVtcyBub3QgZ2V0 IGludG8ga2VybmVsLAo+IFt2MywwOC8xMl0gdXNiOiByb2xlczogQWRkIHVzYiByb2xlIHN3aXRj aCBub3RpZmllci4KPiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzEwODM2NTI1 Lwo+IAo+IFdoYXQgc2hvdWxkIEkgZG8gaWYgSSBhZGQgYSBuZXcgQVBJPyBUaGFua3MKClNvIGlm IHlvdSBhcmUgYXNraW5nIHNob3VsZCB5b3Ugc3VwcGx5IGR1bW15IGZ1bmN0aW9ucyBmb3IgdGhl IG5ldyBBUEksCnRoZW4gSSB3b3VsZCBqdXN0IHNheSB0aGF0IGlmIHlvdSBkbyBzbywgeW91IG5l ZWQgdG8gcHJlcGFyZSB0aGVzZQpwYXRjaGVzIG9uIHRvcCBvZiB0aGF0IHNlcmllcyBmcm9tIFl1 IENoZW4uIEluIGdlbmVyYWwgSSdtIG5vdCBzdXJlIHdlCm5lZWQgZHVtbXkgZnVuY3Rpb25zIHdp dGggdGhpcyBBUEkuCgpIYW5zLCBjb21tZW50cz8KCgp0aGFua3MsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFED6C43381 for ; Fri, 15 Mar 2019 11:59:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88C9320651 for ; Fri, 15 Mar 2019 11:59:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lCeRX/WZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C9320651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NChmJHy2V4u+V/GwDf0YnRMlug1yIDUByBLYbNF7LYE=; b=lCeRX/WZgZ6ywb 1rlawZv9uYF6FueYCgUtWXyW6JC0U/AIyPOr7G0L0fEAH5gvsXaOqUfk9bGh+rdY2tHaIfoVM4Dlu g1JxQBAKZ0DPkpFP6ulVYN9Q6kP14Pl/xeCvOvVawF+daNRicdwvPCYr1YPvVgVJZKclKvJxGI8hh 6si3HKXCWea2IEGS2rUjgr4YB89aMC2e20MuT0Cq5nGpcnFs1NqqLH811xPw1+Aaeu7yfu0r6amp4 BKk/BQ4AMhqKPrJxmwfF/x1PzadeV2MQeGqCX5cNMyZZo+6Pv4XB2GS8RF7WwHcllSjiMvem4etD5 6KCLRNiEu/d90tQ20EBQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4lUY-000434-8e; Fri, 15 Mar 2019 11:59:14 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h4lUL-0003kj-Ee; Fri, 15 Mar 2019 11:59:03 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Mar 2019 04:58:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,482,1544515200"; d="scan'208";a="155328773" Received: from kuha.fi.intel.com ([10.237.72.189]) by fmsmga001.fm.intel.com with SMTP; 15 Mar 2019 04:58:54 -0700 Received: by kuha.fi.intel.com (sSMTP sendmail emulation); Fri, 15 Mar 2019 13:58:54 +0200 Date: Fri, 15 Mar 2019 13:58:54 +0200 From: Heikki Krogerus To: Chunfeng Yun , Hans de Goede Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Message-ID: <20190315115854.GJ7752@kuha.fi.intel.com> References: <1552635513-2378-1-git-send-email-chunfeng.yun@mediatek.com> <1552635513-2378-5-git-send-email-chunfeng.yun@mediatek.com> <20190315081835.GD7752@kuha.fi.intel.com> <1552641204.10179.133.camel@mhfsdcap03> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1552641204.10179.133.camel@mhfsdcap03> User-Agent: Mutt/1.11.3 (2019-02-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190315_045901_581967_2734DDBF X-CRM114-Status: GOOD ( 13.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Badhri Jagan Sridharan , Andy Shevchenko , Rob Herring , linux-mediatek@lists.infradead.org, Min Guo , Matthias Brugger , Adam Thomson , linux-arm-kernel@lists.infradead.org, Li Jun Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote: > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled, > > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register': > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to > `usb_role_switch_register' > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit': > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to > `usb_role_switch_unregister' > > the following patch has fixed the issue, but seems not get into kernel, > [v3,08/12] usb: roles: Add usb role switch notifier. > https://patchwork.kernel.org/patch/10836525/ > > What should I do if I add a new API? Thanks So if you are asking should you supply dummy functions for the new API, then I would just say that if you do so, you need to prepare these patches on top of that series from Yu Chen. In general I'm not sure we need dummy functions with this API. Hans, comments? thanks, -- heikki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel