From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v4 1/3] nvme: set 0 capacity if namespace block size exceeds PAGE_SIZE
Date: Fri, 15 Mar 2019 17:28:37 +0100 [thread overview]
Message-ID: <20190315162837.GA27308@lst.de> (raw)
In-Reply-To: <8a80ce70-0b98-6c82-a47c-f312a41d2d2a@grimberg.me>
On Tue, Mar 12, 2019@02:15:26PM -0700, Sagi Grimberg wrote:
>
>> I like the idea behind this, but it looks rather convoluted. I think
>> for the unusable namespace case we should warn and have a common label
>> that just sets the capacity, not touching anything else.
>>
>> Does something like this work for you?
>
> No, this is what I had done originally, but we need to always have the
> queue set to a decent block size, otherwise blk_queue_stack_limits()
> panics on div by 0..
I actually tested it by manually hacking a 8k block size into nvmet
and and it works just fine for me. Where do you see a division by
zero with this patch exactly?
next prev parent reply other threads:[~2019-03-15 16:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-11 22:02 [PATCH v4 0/3] Couple of fixes detected with blktests Sagi Grimberg
2019-03-11 22:02 ` [PATCH v4 1/3] nvme: set 0 capacity if namespace block size exceeds PAGE_SIZE Sagi Grimberg
2019-03-11 22:06 ` Keith Busch
2019-03-12 14:32 ` Christoph Hellwig
2019-03-12 15:35 ` Christoph Hellwig
2019-03-12 21:15 ` Sagi Grimberg
2019-03-15 16:28 ` Christoph Hellwig [this message]
2019-03-15 16:38 ` Keith Busch
2019-03-15 16:40 ` Christoph Hellwig
2019-03-15 16:47 ` Keith Busch
2019-03-15 17:17 ` Sagi Grimberg
2019-03-15 18:24 ` Christoph Hellwig
2019-03-15 20:44 ` Sagi Grimberg
2019-04-24 18:50 ` Sagi Grimberg
2019-04-25 14:52 ` Christoph Hellwig
2019-03-11 22:02 ` [PATCH v4 2/3] nvme: put ns_head ref if namespace fails allocation Sagi Grimberg
2019-03-12 14:47 ` Christoph Hellwig
2019-03-11 22:02 ` [PATCH v4 3/3] nvmet-file: clamp-down file namespace lba_shift Sagi Grimberg
2019-03-12 14:33 ` Christoph Hellwig
2019-03-12 21:07 ` Sagi Grimberg
2019-03-15 16:29 ` Christoph Hellwig
2019-03-15 17:18 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190315162837.GA27308@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.