All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruno Wolff III <bruno@wolff.to>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: wireguard@lists.zx2c4.com
Subject: Re: [PATCH] global: the _bh variety of rcu helpers have been unified
Date: Sat, 16 Mar 2019 11:11:11 -0500	[thread overview]
Message-ID: <20190316161111.GA6435@wolff.to> (raw)
In-Reply-To: <20190315051439.19361-1-Jason@zx2c4.com>

On Thu, Mar 14, 2019 at 23:14:39 -0600,
  "Jason A. Donenfeld" <Jason@zx2c4.com> wrote:
>---
>Hey Bruno,
>
>Based on your research, how does the below strike you? It's certainly
>not pretty, but I'm struggling to come up with a better solution.

I think anything that doesn't try to keep the _bh versions around is going to 
be ugly. But keeping the _bh versions is not going to be acceptible upstream, 
so that doesn't seem to be an option. What you did looks pretty good 
given the constraints.

In the talk I saw, the motivation for the change was that mismatching 
rcu functions caused security issues, though I don't know how practical 
it is to exploit those mistakes. So I worry a bit about breaking things 
in old kernels accidentally, in the future. I don't have any good ideas for 
automatically catching misuse in new code.

I did try the version you committed, yesterday, and it seemed to work 
fine on a 5.1 kernel.
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

      reply	other threads:[~2019-03-16 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14  5:16 [PATCH] Merge two rcu types Bruno Wolff III
2019-03-14 12:32 ` Bruno Wolff III
2019-03-14 17:10   ` Bruno Wolff III
2019-03-14 18:58     ` Jason A. Donenfeld
2019-03-14 20:05       ` Bruno Wolff III
2019-03-15  5:14         ` [PATCH] global: the _bh variety of rcu helpers have been unified Jason A. Donenfeld
2019-03-16 16:11           ` Bruno Wolff III [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190316161111.GA6435@wolff.to \
    --to=bruno@wolff.to \
    --cc=Jason@zx2c4.com \
    --cc=wireguard@lists.zx2c4.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.