From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78776C43381 for ; Sat, 16 Mar 2019 20:26:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 504F9218A1 for ; Sat, 16 Mar 2019 20:26:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726606AbfCPU0Y (ORCPT ); Sat, 16 Mar 2019 16:26:24 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:51450 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726493AbfCPU0Y (ORCPT ); Sat, 16 Mar 2019 16:26:24 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1h5Fst-0000ib-2D; Sat, 16 Mar 2019 20:26:23 +0000 Date: Sat, 16 Mar 2019 20:26:23 +0000 From: Al Viro To: Dan Williams Cc: linux-fsdevel Subject: Re: [RFC] what's the point of register_filesystem() in drivers/dax/super.c? Message-ID: <20190316202622.GE2217@ZenIV.linux.org.uk> References: <20190316162353.GD2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Mar 16, 2019 at 01:10:26PM -0700, Dan Williams wrote: > On Sat, Mar 16, 2019 at 9:24 AM Al Viro wrote: > > > > It's not user-mountable, kern_mount() doesn't care about > > looking it up by name, so the only effect of having it registered > > is having it visible in /proc/filesystems. > > > > Do you need that for anything? Because I would rather > > avoid more of that voodoo... > > It can die. It was mindless copy/paste from fs/blockdev.c and the > "bdev" fs. The device-dax unit tests pass just fine with it removed. > I'll send a formal patch with the following: Acked-by: Al Viro Do you prefer it in your tree, or would you rather have it go through vfs.git?