From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v2 1/3] dt-bindings: Add doc for the ingenic-drm driver Date: Sat, 16 Mar 2019 21:59:45 +0100 Message-ID: <20190316205945.GA11309@ravnborg.org> References: <20190315170701.29670-1-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190315170701.29670-1-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Ripard , Rob Herring , Sean Paul List-Id: devicetree@vger.kernel.org SGkgUGF1bC4KCk9uIEZyaSwgTWFyIDE1LCAyMDE5IGF0IDA2OjA2OjU5UE0gKzAxMDAsIFBhdWwg Q2VyY3VlaWwgd3JvdGU6Cj4gQWRkIGRvY3VtZW50YXRpb24gZm9yIHRoZSBkZXZpY2V0cmVlIGJp bmRpbmdzIG9mIHRoZSBEUk0gZHJpdmVyIGZvciB0aGUKPiBKWjQ3eHggZmFtaWx5IG9mIFNvQ3Mg ZnJvbSBJbmdlbmljLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgQ2VyY3VlaWwgPHBhdWxAY3Jh cG91aWxsb3UubmV0Pgo+IFRlc3RlZC1ieTogQXJ0dXIgUm9qZWsgPGNvbnRhY3RAYXJ0dXItcm9q ZWsuZXU+Cj4gLS0tCj4gCj4gTm90ZXM6Cj4gICAgIHYyOiBSZW1vdmUgaW5nZW5pYyxwYW5lbCBw cm9wZXJ0eS4KPiAKPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9pbmdlbmljLGRy bS50eHQgICAgfCAyOSArKysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAy OSBpbnNlcnRpb25zKCspCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2Rldmlj ZXRyZWUvYmluZGluZ3MvZGlzcGxheS9pbmdlbmljLGRybS50eHQKPiAKPiBkaWZmIC0tZ2l0IGEv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvaW5nZW5pYyxkcm0udHh0 IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvaW5nZW5pYyxkcm0u dHh0Cj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAuLmY1N2E0YWUw ZjdhYwo+IC0tLSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvZGlzcGxheS9pbmdlbmljLGRybS50eHQKPiBAQCAtMCwwICsxLDI5IEBACj4gK0luZ2Vu aWMgSlo0N3h4IERSTSBkcml2ZXIKPiArCj4gK1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gKy0gY29t cGF0aWJsZTogb25lIG9mOgo+ICsgICogaW5nZW5pYyxqejQ3NDAtZHJtCj4gKyAgKiBpbmdlbmlj LGp6NDcyNWItZHJtCj4gKy0gcmVnOiBMQ0QgcmVnaXN0ZXJzIGxvY2F0aW9uIGFuZCBsZW5ndGgK PiArLSBjbG9ja3M6IExDRCBwaXhjbG9jayBhbmQgZGV2aWNlIGNsb2NrIHNwZWNpZmllcnMuCj4g KwkgICBUaGUgZGV2aWNlIGNsb2NrIGlzIG9ubHkgcmVxdWlyZWQgb24gdGhlIEpaNDc0MC4KPiAr LSBjbG9jay1uYW1lczogImxjZF9wY2xrIiBhbmQgImxjZCIKPiArLSBpbnRlcnJ1cHRzOiBTcGVj aWZpZXMgdGhlIGludGVycnVwdCBsaW5lIHRoZSBMQ0QgY29udHJvbGxlciBpcyBjb25uZWN0ZWQg dG8uCj4gKwo+ICtPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICstIGluZ2VuaWMsbGNkLW1vZGU6IExD RCBtb2RlIHRvIHVzZSB3aXRoIHRoZSBkaXNwbGF5IHBhbmVsLgo+ICsJCSAgICBTZWUgPGR0LWJp bmRpbmdzL2Rpc3BsYXkvaW5nZW5pYyxkcm0uaD4gZm9yIGFsbCB0aGUKPiArCQkgICAgcG9zc2li bGUgdmFsdWVzLgoKVGhlIHZhbHVlIG9mIHRoZSBpbmdlbmljLGxjZC1tb2RlIGRlcGVuZHMgb24g dGhlIHBhbmVsIHVzZWQuClNvIHRoaXMgbG9va3MgbGlrZSBhIHBhbmVsIHByb3BlcnR5IGFuZCBu b3QgYSBkaXNwbGF5IHByb3BlcnR5LgoKVGhlIHBhbmVsIHNob3VsZCBiZSBzcGVjaWZpZWQgdXNp bmcgYW4gT0YgZ3JhcGggYmluZGluZwppbiBhIHBvcnQgc3ViLW5vZGUuClRoZSByZW1vdGUtZW5k cG9pbnQgd2lsbCBzcGVjaWZpZnkgdGhlIHBhbmVsIHByb3BlcnRpZXMKYW5kIGlmIHRoZSBwYW5l bCByZXF1aXJlcyBzb21ldGhpbmcgc3BlY2lhbCBmcm9tIHRoZSBkaXNwbGF5IGRyaXZlciwKdGhl IHBhbmxlIHNob3VsZCBzcGVjaWZ5IHRoaXMuClNvIG9uZSBjYW4gY2hhbmdlIHBhbmVsIHdpdGhv dXQgdG91Y2hpbmcgdGhlIGRpc3BsYXkgbm9kZQppbiB0aGUgRFQuCgoKPiArCj4gK0V4YW1wbGU6 Cj4gKwo+ICtsY2Q6IGxjZC1jb250cm9sbGVyQDEzMDUwMDAwIHsKPiArCWNvbXBhdGlibGUgPSAi aW5nZW5pYyxqejQ3MjViLWRybSI7Cj4gKwlyZWcgPSA8MHgxMzA1MDAwMCAweDEwMDA+Owo+ICsK PiArCWludGVycnVwdC1wYXJlbnQgPSA8JmludGM+Owo+ICsJaW50ZXJydXB0cyA9IDwzMT47Cj4g Kwo+ICsJY2xvY2tzID0gPCZjZ3UgSlo0NzI1Ql9DTEtfTENEPjsKPiArCWNsb2NrLW5hbWVzID0g ImxjZCI7Cj4gK307CgpBcyBoaW50ZWQgYWJvdmUgdGhlIHBhbmVsIGlzIG5vdCBzcGVjaWZpZWQg YWJvdmUgYW5kIHRvIGZvbGxvdyB0aGUKbW9kZXJuIHdheSB0byBkbyBzbyB3b3VsZCBiZSB0byB1 c2UgYSBPRiBncmFwaCBiaW5kaW5nLgoKCVNhbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FAEEC43381 for ; Sat, 16 Mar 2019 20:59:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00964218A1 for ; Sat, 16 Mar 2019 20:59:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727075AbfCPU7w (ORCPT ); Sat, 16 Mar 2019 16:59:52 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:35953 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726833AbfCPU7v (ORCPT ); Sat, 16 Mar 2019 16:59:51 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 9B2BE8053A; Sat, 16 Mar 2019 21:59:46 +0100 (CET) Date: Sat, 16 Mar 2019 21:59:45 +0100 From: Sam Ravnborg To: Paul Cercueil , Rob Herring Cc: David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Maarten Lankhorst , Maxime Ripard , Sean Paul , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/3] dt-bindings: Add doc for the ingenic-drm driver Message-ID: <20190316205945.GA11309@ravnborg.org> References: <20190315170701.29670-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190315170701.29670-1-paul@crapouillou.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=p6pI0oa4AAAA:8 a=ebqaEtIYvt-xgtW2S2sA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=9cw2y2bKwytFd151gpuR:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul. On Fri, Mar 15, 2019 at 06:06:59PM +0100, Paul Cercueil wrote: > Add documentation for the devicetree bindings of the DRM driver for the > JZ47xx family of SoCs from Ingenic. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > --- > > Notes: > v2: Remove ingenic,panel property. > > .../devicetree/bindings/display/ingenic,drm.txt | 29 ++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ingenic,drm.txt > > diff --git a/Documentation/devicetree/bindings/display/ingenic,drm.txt b/Documentation/devicetree/bindings/display/ingenic,drm.txt > new file mode 100644 > index 000000000000..f57a4ae0f7ac > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ingenic,drm.txt > @@ -0,0 +1,29 @@ > +Ingenic JZ47xx DRM driver > + > +Required properties: > +- compatible: one of: > + * ingenic,jz4740-drm > + * ingenic,jz4725b-drm > +- reg: LCD registers location and length > +- clocks: LCD pixclock and device clock specifiers. > + The device clock is only required on the JZ4740. > +- clock-names: "lcd_pclk" and "lcd" > +- interrupts: Specifies the interrupt line the LCD controller is connected to. > + > +Optional properties: > +- ingenic,lcd-mode: LCD mode to use with the display panel. > + See for all the > + possible values. The value of the ingenic,lcd-mode depends on the panel used. So this looks like a panel property and not a display property. The panel should be specified using an OF graph binding in a port sub-node. The remote-endpoint will specifify the panel properties and if the panel requires something special from the display driver, the panle should specify this. So one can change panel without touching the display node in the DT. > + > +Example: > + > +lcd: lcd-controller@13050000 { > + compatible = "ingenic,jz4725b-drm"; > + reg = <0x13050000 0x1000>; > + > + interrupt-parent = <&intc>; > + interrupts = <31>; > + > + clocks = <&cgu JZ4725B_CLK_LCD>; > + clock-names = "lcd"; > +}; As hinted above the panel is not specified above and to follow the modern way to do so would be to use a OF graph binding. Sam