From: Wolfram Sang <wsa@the-dreams.de>
To: marek.vasut@gmail.com
Cc: linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Phil Edworthy <phil.edworthy@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values
Date: Sun, 17 Mar 2019 10:09:01 +0100 [thread overview]
Message-ID: <20190317090901.GA2268@kunai> (raw)
In-Reply-To: <20190317000608.24881-1-marek.vasut@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
On Sun, Mar 17, 2019 at 01:06:06AM +0100, marek.vasut@gmail.com wrote:
> From: Marek Vasut <marek.vasut+renesas@gmail.com>
>
> Replace unsigned long with u32 type for variables holding
s/unsigned long/various variable types/
> register values, since the registers are 32bit. Note that
> rcar_pcie_msi_irq() still uses unsigned long because both
> find_first_bit() and __fls() require unsigned long as an
> argument.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
...
> - int shift = 8 * (where & 3);
> + u32 shift = 8 * (where & 3);
Minor nit: Since this is about shifting, maybe replace 8 with << 3 while
we are here?
There is also a 'shift' var in rcar_pcie_write_conf(). I think we should
convert this for consistency, too?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-03-17 9:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 0:06 [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values marek.vasut
2019-03-17 0:06 ` [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses marek.vasut
2019-03-17 8:03 ` Sergei Shtylyov
2019-03-17 22:59 ` Marek Vasut
2019-03-17 9:12 ` Wolfram Sang
2019-03-17 23:37 ` Marek Vasut
2019-03-18 8:39 ` Geert Uytterhoeven
2019-03-18 9:30 ` Geert Uytterhoeven
2019-03-19 1:16 ` Marek Vasut
2019-03-18 8:35 ` Geert Uytterhoeven
2019-03-22 2:30 ` Marek Vasut
2019-03-17 0:06 ` [PATCH 3/3] PCI: rcar: Clean up debug messages marek.vasut
2019-03-17 9:15 ` Wolfram Sang
2019-03-18 8:20 ` Geert Uytterhoeven
2019-03-17 9:09 ` Wolfram Sang [this message]
2019-03-17 22:58 ` [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values Marek Vasut
2019-03-18 7:33 ` Wolfram Sang
2019-03-18 8:47 ` Geert Uytterhoeven
2019-03-21 3:25 ` Marek Vasut
2019-03-21 7:31 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317090901.GA2268@kunai \
--to=wsa@the-dreams.de \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.