All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bhanusree Pola <bhanusreemahesh@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
	Matthias Brugger <matthias.bgg@gmail.com>
Subject: Re: [PATCH v4 2/2] Staging: mt7621-mmc: Modify the return type for all possible values
Date: Sun, 17 Mar 2019 11:19:57 +0100	[thread overview]
Message-ID: <20190317101957.GD20773@kroah.com> (raw)
In-Reply-To: <20190317031331.11965-3-bhanusreemahesh@gmail.com>

On Sun, Mar 17, 2019 at 08:43:31AM +0530, Bhanusree Pola wrote:
> Modify the return type of the function msdc_do_command to static int
> as the member error of the structure struct mmc_command is of type int.

This looks good, but I do not understand the subject line.  What does
"for all possible values" have to do with the change you made here?

Please fix it up to match the changelog text here.

thanks,

greg k-h


      reply	other threads:[~2019-03-17 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-17  3:13 [PATCH v4 0/2] Staging: mt7621-mmc: Remove ret.cocci warnings Bhanusree Pola
2019-03-17  3:13 ` [PATCH v4 1/2] Staging: mt7621-mmc: Fix ret.cooci warnings Bhanusree Pola
2019-03-17  3:13 ` [PATCH v4 2/2] Staging: mt7621-mmc: Modify the return type for all possible values Bhanusree Pola
2019-03-17 10:19   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190317101957.GD20773@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhanusreemahesh@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.